desktop/source/lib/init.cxx | 2 ++ sc/source/core/tool/formularesult.cxx | 2 +- sd/source/ui/view/drviews2.cxx | 6 +++--- sfx2/source/control/unoctitm.cxx | 2 ++ sw/source/uibase/shells/drwbassh.cxx | 12 ++++++++---- vcl/jsdialog/enabled.cxx | 2 ++ 6 files changed, 18 insertions(+), 8 deletions(-)
New commits: commit 642e1809eb59872e6ca02e1bc8fb5dd897c63212 Author: Caolán McNamara <[email protected]> AuthorDate: Sat May 11 22:03:04 2024 +0100 Commit: Caolán McNamara <[email protected]> CommitDate: Sun May 12 14:04:34 2024 +0200 extend comment on parallel group calculation a titch Change-Id: I3cdb757d1959af17b74a8b973010a8d0f477cfe9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167525 Tested-by: Jenkins Reviewed-by: Caolán McNamara <[email protected]> diff --git a/sc/source/core/tool/formularesult.cxx b/sc/source/core/tool/formularesult.cxx index 234c17780b4e..e326da7f2121 100644 --- a/sc/source/core/tool/formularesult.cxx +++ b/sc/source/core/tool/formularesult.cxx @@ -664,7 +664,7 @@ void ScFormulaResult::HandleStuffAfterParallelCalculation() // If ScInterpreter::CreateFormulaDoubleToken tokens make it into a result if (mbToken && mpToken) { - // temp check to look for this + // I don't see any evidence that this can happen, but assert if it arises assert(mpToken->GetRefCntPolicy() == formula::RefCntPolicy::ThreadSafe); const_cast<formula::FormulaToken*>(mpToken)->SetRefCntPolicy(formula::RefCntPolicy::ThreadSafe); } commit fd14f65baf4de94c053cb3e2cc277e7d3650d4fa Author: Szymon Kłos <[email protected]> AuthorDate: Tue May 7 21:59:04 2024 +0200 Commit: Caolán McNamara <[email protected]> CommitDate: Sun May 12 14:04:26 2024 +0200 jsdialog: enable Object Name and Description dialog and send uno command enable/disable status Signed-off-by: Szymon Kłos <[email protected]> Change-Id: Id643a27308809b6960be72fb368b9f078ff9cf6c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167296 Reviewed-by: Michael Meeks <[email protected]> Tested-by: Jenkins CollaboraOffice <[email protected]> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167521 Tested-by: Caolán McNamara <[email protected]> Reviewed-by: Caolán McNamara <[email protected]> diff --git a/desktop/source/lib/init.cxx b/desktop/source/lib/init.cxx index e093bf7ff4f2..635bca3b5de9 100644 --- a/desktop/source/lib/init.cxx +++ b/desktop/source/lib/init.cxx @@ -3709,6 +3709,8 @@ static void doc_iniUnoCommands () u".uno:Context"_ustr, u".uno:WrapText"_ustr, u".uno:ToggleMergeCells"_ustr, + u".uno:NameGroup"_ustr, + u".uno:ObjectTitleDescription"_ustr, u".uno:NumberFormatCurrency"_ustr, u".uno:NumberFormatPercent"_ustr, u".uno:NumberFormatDecimal"_ustr, diff --git a/sd/source/ui/view/drviews2.cxx b/sd/source/ui/view/drviews2.cxx index 94ddb161ea88..69568b497e77 100644 --- a/sd/source/ui/view/drviews2.cxx +++ b/sd/source/ui/view/drviews2.cxx @@ -2665,7 +2665,7 @@ void DrawViewShell::FuTemporary(SfxRequest& rReq) if(1 == mpDrawView->GetMarkedObjectCount()) { // #i68101# - SdrObject* pSelected = mpDrawView->GetMarkedObjectByIndex(0); + rtl::Reference<SdrObject> pSelected = mpDrawView->GetMarkedObjectByIndex(0); OSL_ENSURE(pSelected, "DrawViewShell::FuTemp03: nMarkCount, but no object (!)"); OUString aName(pSelected->GetName()); @@ -2683,7 +2683,7 @@ void DrawViewShell::FuTemporary(SfxRequest& rReq) SdPage* pPage = GetActualPage(); if (pPage) - pPage->notifyObjectRenamed(pSelected); + pPage->notifyObjectRenamed(pSelected.get()); } pDlg->disposeOnce(); SfxBindings& rBindings = GetViewFrame()->GetBindings(); @@ -2703,7 +2703,7 @@ void DrawViewShell::FuTemporary(SfxRequest& rReq) { if(1 == mpDrawView->GetMarkedObjectCount()) { - SdrObject* pSelected = mpDrawView->GetMarkedObjectByIndex(0); + rtl::Reference<SdrObject> pSelected = mpDrawView->GetMarkedObjectByIndex(0); OSL_ENSURE(pSelected, "DrawViewShell::FuTemp03: nMarkCount, but no object (!)"); OUString aTitle(pSelected->GetTitle()); OUString aDescription(pSelected->GetDescription()); diff --git a/sfx2/source/control/unoctitm.cxx b/sfx2/source/control/unoctitm.cxx index be86988ce9fd..b267c6157b57 100644 --- a/sfx2/source/control/unoctitm.cxx +++ b/sfx2/source/control/unoctitm.cxx @@ -1001,6 +1001,8 @@ static void InterceptLOKStateChangeEvent(sal_uInt16 nSID, SfxViewFrame* pViewFra aEvent.FeatureURL.Path == "InsertRowsAfter" || aEvent.FeatureURL.Path == "InsertColumnsBefore" || aEvent.FeatureURL.Path == "InsertColumnsAfter" || + aEvent.FeatureURL.Path == "NameGroup" || + aEvent.FeatureURL.Path == "ObjectTitleDescription" || aEvent.FeatureURL.Path == "MergeCells" || aEvent.FeatureURL.Path == "InsertObjectChart" || aEvent.FeatureURL.Path == "InsertSection" || diff --git a/sw/source/uibase/shells/drwbassh.cxx b/sw/source/uibase/shells/drwbassh.cxx index a0394cdb5598..01673532ecbd 100644 --- a/sw/source/uibase/shells/drwbassh.cxx +++ b/sw/source/uibase/shells/drwbassh.cxx @@ -607,7 +607,7 @@ void SwDrawBaseShell::Execute(SfxRequest& rReq) if(1 == pSdrView->GetMarkedObjectCount()) { // #i68101# - SdrObject* pSelected = pSdrView->GetMarkedObjectByIndex(0); + rtl::Reference<SdrObject> pSelected = pSdrView->GetMarkedObjectByIndex(0); assert(pSelected && "DrawViewShell::FuTemp03: nMarkCount, but no object (!)"); OUString aOrigName(pSelected->GetName()); @@ -628,8 +628,12 @@ void SwDrawBaseShell::Execute(SfxRequest& rReq) // update accessibility sidebar object name if we modify the object name on the navigator bar if (!aNewName.isEmpty() && aOrigName != aNewName) { - if (SwNode* pSwNode = FindFrameFormat(pSelected)->GetAnchor().GetAnchorNode()) - pSwNode->resetAndQueueAccessibilityCheck(true); + auto pFrameFormat = FindFrameFormat(pSelected.get()); + if (pFrameFormat) + { + if (SwNode* pSwNode = pFrameFormat->GetAnchor().GetAnchorNode()) + pSwNode->resetAndQueueAccessibilityCheck(true); + } } } pDlg->disposeOnce(); @@ -647,7 +651,7 @@ void SwDrawBaseShell::Execute(SfxRequest& rReq) if(1 == pSdrView->GetMarkedObjectCount()) { - SdrObject* pSelected = pSdrView->GetMarkedObjectByIndex(0); + rtl::Reference<SdrObject> pSelected = pSdrView->GetMarkedObjectByIndex(0); assert(pSelected && "DrawViewShell::FuTemp03: nMarkCount, but no object (!)"); OUString aTitle(pSelected->GetTitle()); OUString aDescription(pSelected->GetDescription()); diff --git a/vcl/jsdialog/enabled.cxx b/vcl/jsdialog/enabled.cxx index fd05cc3ff569..ab0fbdbd7751 100644 --- a/vcl/jsdialog/enabled.cxx +++ b/vcl/jsdialog/enabled.cxx @@ -58,6 +58,8 @@ bool isBuilderEnabled(std::u16string_view rUIFile, bool bMobile) || rUIFile == u"cui/ui/numberingformatpage.ui" || rUIFile == u"cui/ui/numberingoptionspage.ui" || rUIFile == u"cui/ui/numberingpositionpage.ui" + || rUIFile == u"cui/ui/objectnamedialog.ui" + || rUIFile == u"cui/ui/objecttitledescdialog.ui" || rUIFile == u"cui/ui/optlingupage.ui" || rUIFile == u"cui/ui/pageformatpage.ui" || rUIFile == u"cui/ui/paragalignpage.ui"
