New branch 'private/quwex/notespanesquashed' available with the following
commits:
commit a5e08f0631b7cd3976c9fc1afe8317ecc3b406a2
Author: Sarper Akdemir <[email protected]>
Date: Fri Apr 19 00:40:28 2024 +0200
related tdf#33603: sd: do not assume there's always a viewshell
Change-Id: I171639150a84372e7e25b5246d4882c467edd58b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166271
Tested-by: Jenkins
Reviewed-by: Sarper Akdemir <[email protected]>
commit 6b2c57f772fe16329d6c218237b1e087e5a0cbbe
Author: Sarper Akdemir <[email protected]>
Date: Tue Apr 16 17:09:28 2024 +0200
tdf#33603: make the notes pane handle placeholder text on focus
Change-Id: Id2bca2b8a8bafa9da44a5f97a8e763b512078ef7
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166152
Tested-by: Jenkins
Reviewed-by: Sarper Akdemir <[email protected]>
commit f8bf22e68bd8e19a41360f8d49c9e70206e9d493
Author: Samuel Mehrbrodt <[email protected]>
Date: Thu Apr 11 11:24:22 2024 +0200
tdf#33603 Typo: 'Notes Panel' -> 'Notes Pane'
Similiar to 'Slide Pane'
Change-Id: If96afc4c054bbbff7c9bf8c5f4309e8eeb419d77
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166005
Tested-by: Jenkins
Reviewed-by: Adolfo Jayme Barrientos <[email protected]>
Reviewed-by: Sarper Akdemir <[email protected]>
commit eb4eabb5cbd91816020eeaf7f0a9f864d68b7f4f
Author: Samuel Mehrbrodt <[email protected]>
Date: Thu Apr 11 10:55:31 2024 +0200
tdf#33603 Allow adding Notes Panel to toolbar/menubar/keyboard shortcuts
Change-Id: Ic3e8f6b5a0cc8697c62e8f10f69ff53859f33d3a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166004
Tested-by: Jenkins
Reviewed-by: Sarper Akdemir <[email protected]>
commit e348b294334ae678a8e69703431ecd912105d3c5
Author: Samuel Mehrbrodt <[email protected]>
Date: Thu Apr 11 10:55:01 2024 +0200
tdf#33603 Make notes panel available in readonly mode
Change-Id: I2dd10802f3798b2e87833d3cd8ebd21366e0f546
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166003
Tested-by: Jenkins
Reviewed-by: Sarper Akdemir <[email protected]>
commit b00684769335f3ec7e37e1ccd577da52db1e39ad
Author: Sarper Akdemir <[email protected]>
Date: Fri Apr 5 09:39:24 2024 +0300
related tdf#33603: sd: fix notespanel crash on drag and drop
Change-Id: I067fd3f3eccd8e0fa0d13795f660fe43410b0aa3
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165809
Tested-by: Jenkins
Reviewed-by: Samuel Mehrbrodt <[email protected]>
commit e312b3322e7bce998ddfb90b336559fafdc3f800
Author: Sarper Akdemir <[email protected]>
Date: Fri Apr 5 09:23:55 2024 +0300
related tdf#33603: sd: force invalidate notespanel
This is likely not the correct thing to do here, but is a working
solution that fixes the view lagging behind the resize for now.
Change-Id: I662e59cfd0f1259eeb10a49b6e9c5fd616afa7a0
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165808
Tested-by: Jenkins
Reviewed-by: Samuel Mehrbrodt <[email protected]>
commit e3a1e1e6d652e9b1b24ae480cc6315badb6b4b2a
Author: Sarper Akdemir <[email protected]>
Date: Thu Apr 4 18:41:33 2024 +0300
related tdf#33603: fix notespanel missing outliner on mode change
When MainViewShell changed editing mode, two EventMultipexerEvents
arrive in succession - if while processing the first one links are
reset, second one was ignored.
Do not remove EventMultiplexer listener on FillOutliner()
Change-Id: I9c41c823ca74574238d1199ed38f92d9c75a113e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165807
Tested-by: Jenkins
Reviewed-by: Samuel Mehrbrodt <[email protected]>
commit 7ccb329214fcf12edf1b4c0422625cbafe4adfbb
Author: Sarper Akdemir <[email protected]>
Date: Thu Nov 9 20:18:44 2023 +0300
tdf#33603: introduce reworked notes panel
this commit is the squash of the four commits below
instead of introducing the initial NotesPanel implementation
and then deleting the left-over implementation
(at commit ede2f1e6eefbc6471f0163c21430c2f747bb0e67 on
master)
provides all the relevant notes panel new implementation
patches into one.
=====
tdf#33603: sd: add notes panel for normal view
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159288
Tested-by: Jenkins
Reviewed-by: Thorsten Behrens <[email protected]>
related tdf#33603: do not register NotesChildWindow for Draw
Draw doesn't need the notes panel introduced in
c4c1ca58bb587a56a30c7f4817c346054ce37f2a, so don't register
that for it's shell (GraphicViewShell).
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163775
Tested-by: Jenkins
Reviewed-by: Thorsten Behrens <[email protected]>
tdf#33603: sd: rework notes panel
To be able to support various dispatch commands, sidebar, proper
user configuration, and more - reworked the previous notes panel
implementation as a sd::View/sd::ViewShell pair that plays nice
with Impress framework.
To be able to support TextObjectBar(Shell) functionality, without
having TextObjectBar as a SubShell (In the current sd::framework
implementation AFAICS, SubShells are only possible for the
MainViewShell - this doesn't work for notes panel which is never
used as the MainViewShell.).
A workaround is implemented where NotesPanel inherits dispatching
slots from TextObjectBar, and for these inherited slots forwards
the calls to TextObjectBar's implementation.
This workaround could be removed if/when, SubShell support
outside of MainViewShell is implemented.
Known issues/TODO:
- Drag & Drop crashes / doesn't work.
- Some notes placeholder syncing problems on page change, edit mode
change.
- A rendering issue related to resizing when ArrangeGUIElements
isn't called on resize.
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165770
Tested-by: Jenkins
Reviewed-by: Samuel Mehrbrodt <[email protected]>
tdf#33603 Fix Close button not working in Notes Pane
Remove duplicate command and now unused NotesChildWindow
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166002
Tested-by: Jenkins
Reviewed-by: Sarper Akdemir <[email protected]>
=====
Change-Id: Ifea0921b59635611656783ef14ed1a399d84fc7a
commit 3dd8f5f69b0f70a29852b27732c552500ac9b0ca
Author: Thorsten Behrens <[email protected]>
Date: Mon Mar 25 00:22:13 2024 +0100
fix linker error for PCH build
Error was:
ld.lld: error: undefined symbol: LanguageTag::~LanguageTag()
>>> referenced by stl_construct.h:119
(/usr/lib64/gcc/x86_64-suse-linux/13/../../../../include/c++/13/bits/stl_construct.h:119)
>>>
core/workdir/CxxObject/sc/inc/pch/precompiled_vbaobj.o:(void
std::_Construct<LocaleDataWrapper,
com::sun::star::uno::Reference<com::sun::star::uno::XComponentContext>&,
LanguageTag const&>(LocaleDataWrapper*,
com::sun::star::uno::Reference<com::sun::star::uno::XComponentContext>&,
LanguageTag const&))
>>> referenced by stl_construct.h:119
(/usr/lib64/gcc/x86_64-suse-linux/13/../../../../include/c++/13/bits/stl_construct.h:119)
>>>
core/workdir/CxxObject/sc/inc/pch/precompiled_vbaobj.o:(void
std::_Construct<LocaleDataWrapper,
com::sun::star::uno::Reference<com::sun::star::uno::XComponentContext>&,
LanguageTag const&>(LocaleDataWrapper*,
com::sun::star::uno::Reference<com::sun::star::uno::XComponentContext>&,
LanguageTag const&))
>>> referenced by stl_construct.h:119
(/usr/lib64/gcc/x86_64-suse-linux/13/../../../../include/c++/13/bits/stl_construct.h:119)
>>>
core/workdir/CxxObject/sc/inc/pch/precompiled_vbaobj.o:(void
std::_Construct<CharClass,
com::sun::star::uno::Reference<com::sun::star::uno::XComponentContext> const&,
LanguageTag const&>(CharClass*,
com::sun::star::uno::Reference<com::sun::star::uno::XComponentContext> const&,
LanguageTag const&))
>>> referenced 5 more times
Change-Id: Ie84d062d1815aa8e8118171862e0f8f64331d769
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166346
Tested-by: Jenkins
Reviewed-by: Thorsten Behrens <[email protected]>
commit bb55248d254ffaf12336257d19a55b9ed765c74d
Author: Noel Grandin <[email protected]>
Date: Wed Mar 6 09:43:28 2024 +0200
tdf#158773 reduce cost of ContentInfo::GetText
The specific path that is showing up on the perf profile is
SdrTextObj::HasText -> EditTextObjectImpl::GetText ->
ContentInfo::GetText
Reduce the cost by 10% there by adding a method to check if we have text,
and
avoid the cost of constructing an OUString from an svl::SharedString.
Also make use of the new method in places.
Change-Id: Ibc2e0f61c4a2a6c33eea7f2cce09d692d82fd2b2
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164449
Tested-by: Noel Grandin <[email protected]>
Reviewed-by: Noel Grandin <[email protected]>
commit caebec3a84068767b0a88af0eacabf27df3d4651
Author: Sarper Akdemir <[email protected]>
Date: Tue Apr 23 16:00:32 2024 +0200
tdf#38164: sd: allow panning across pages when zoomed in
Change-Id: I513b2b8cbdc91733e551da71a1e6782fecc981a3
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166542
Tested-by: Jenkins
Reviewed-by: Sarper Akdemir <[email protected]>
commit dd7e07960481044c0e69ddd6ea2b2534c782ee14
Author: Thorsten Behrens <[email protected]>
Date: Fri Jan 12 12:01:29 2024 +0100
Fix system-libfixmath
Seems distros start to disagree on whether its liblibfixmath or just
libfixmath.
Change-Id: I54a42b2ba050980ae632ab3c82254131cad7787e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161969
Tested-by: Jenkins
Reviewed-by: Thorsten Behrens <[email protected]>
commit d04c89f2052655b416f0f893743cac35770f5cee
Author: Oliver Specht <[email protected]>
Date: Wed Apr 10 17:11:10 2024 +0200
tdf#160621 Redesign name and value fields in variabe fields dialog page
The space available in the bottom of the dialog page
is now used to make the input fields longer
Change-Id: If936decbcc44ff356095fc291ff8306084c248ef
commit 9696609d5176230e102fb32a7b18ca2b5a7ef0f0
Author: Caolán McNamara <[email protected]>
Date: Sun Apr 7 20:04:57 2024 +0100
Failed to set property GtkEntry.valign to top: Could not parse enum: 'top'
Change-Id: I2d73204bda451bb87b64652b4dd934fc16e3b65d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165875
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <[email protected]>
commit 725e2e27d7aa7d537081ed6db275b737208303ab
Author: Oliver Specht <[email protected]>
Date: Thu Apr 11 08:56:17 2024 +0200
Improve case rotation in sentence case
Rotating case (Shift+F3) applies sentence case only
if multiple words are already selected or selects
sentence if SENTENCE_CASE is going to be applied.
Change-Id: I9e8536d7744a344d7ad54150783e91e843e0e81e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165986
Tested-by: Jenkins
Reviewed-by: Thorsten Behrens <[email protected]>
commit 1abbd14028b5bc57f640d9c86528c8a6f877fd4b
Author: Oliver Specht <[email protected]>
Date: Mon Apr 15 11:40:12 2024 +0200
Case rotation in Impress: skip sentence case
Sentence case does not make sense if a selection contains less than two
words.
Rotation then skkips to the next case mode.
Change-Id: I79d6560c494b716a53bfed654027f6f37dc6c362
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166115
Tested-by: Jenkins
Reviewed-by: Thorsten Behrens <[email protected]>
commit e39d7978dd8b28c09b3994442145deee916f79e1
Author: Xisco Fauli <[email protected]>
Date: Wed Feb 21 15:49:56 2024 +0100
tdf#159797: sw_uiwriter6: Add unittest
Change-Id: I69b8ea673f676f1106e257cef507937cbd5ebd2c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163695
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <[email protected]>
commit 1b6310ef575e349d30a0f6bbfa888af31f87539d
Author: Balazs Varga <[email protected]>
Date: Wed Apr 10 17:48:20 2024 +0100
tdf#160616 - Fix SUMPRODUCT calculation is broken in some cases
Double refs with operators only trimmable in case of one root paramater.
Follow up of: ba0ec4a5d2b025b675410cd18890d1cca3bc5a2f
Change-Id: If61fb39696d9539ffc9d32a6ecad79bfa1bf92e5
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165957
Tested-by: Gabor Kelemen <[email protected]>
Tested-by: Jenkins
Reviewed-by: Gabor Kelemen <[email protected]>
(cherry picked from commit 2af433f11cf24db655677bdf26e39fabaf3611fc)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165932
Tested-by: allotropia jenkins <[email protected]>
Reviewed-by: Thorsten Behrens <[email protected]>
commit b15a9078eeb4e3fd6397f0cf75273114f6e61dc3
Author: Rene Engelhard <[email protected]>
Date: Wed Apr 3 23:26:08 2024 +0200
clean up after removal of patched rhino
Change-Id: I193fd0c10d297555faa7a832718dbd6cd929a406
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165762
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <[email protected]>
commit b995e86d1fc6d36ee8ab084b4ed792e4d7018993
Author: Stephan Bergmann <[email protected]>
Date: Fri Mar 22 15:53:49 2024 +0100
Update to latest Rhino 1.7.14
...at the expense of losing, at least for now, the script editor for it
(which
had been hacked into the old upstream sources in a hard-to-maintain way).
rhino-1.7.14.zip is taken from
<https://github.com/mozilla/rhino/releases/download/Rhino1_7_14_Release/rhino-1.7.14.zip>.
Building it would now use Gradle, but instead just hack together an
invocation
of javac and jar in external/rhino/ExternalProject_rhino.mk that effectively
generates the same jar as the upstream-built jar available at
<https://github.com/mozilla/rhino/releases/download/Rhino1_7_14_Release/rhino-1.7.14.jar>.
All the various patches are no longer necessary:
* external/rhino/rhino1_5R5.patch and external/rhino/OfficeScriptInfo.java
were
mostly for the hacked-in script editor, which has been abandoned at least
for
now (see above).
* external/rhino/rhino1_5R5-find_swing.patch (originally from
0a7f9346503a557f583bced269655fa1996550af "ause109: #i106296# make
build.xml
aware of TARFILE_LOCATION") appears to be obsolete.
* external/rhino/rhino1_5R5-updateToolTip.patch is covered by
<https://github.com/mozilla/rhino/commit/ab20a73b16f68daf715c7ac4808c119bb15d698c>
"Fix bug 414869: Rhino debugger fails to launch due to updates in mac os x
leopard".
* external/rhino/rhino-classpath.patch.1 from
bb58293296f843654045d7b0eba6899d11533a4a "rhino: unbreak build on Fedora
34"
was only relevant when building with Ant.
Change-Id: I5fca5915d785716f7aaf313ff2469a20f55f707a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165416
Tested-by: allotropia jenkins <[email protected]>
Reviewed-by: Thorsten Behrens <[email protected]>
commit 10c25383c83d6aa66a15222caf0287d7b748e430
Author: Samuel Mehrbrodt <[email protected]>
Date: Thu Feb 22 11:55:30 2024 +0100
tdf#108697 Allow modifying default bullet selection
Allow to change bullets in configuration.
Change-Id: Iab26118dd597417997d6f0a7355f516a4da97ee4
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163735
Tested-by: Jenkins
Reviewed-by: Samuel Mehrbrodt <[email protected]>
commit df018aaf024ec00656733c274675bc5f3d6379fb
Author: Oliver Specht <[email protected]>
Date: Wed Apr 3 14:57:29 2024 +0200
improve usability of variable fields
The value field of the Variables page of the field dialog is changed
into a scrollable field to enhance usability in combination with longer
values of variable or user fields
Change-Id: Ib268cf22ff54604214fb090c3c93b7d145a9c9a5
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165750
Tested-by: Jenkins
Reviewed-by: Thorsten Behrens <[email protected]>
commit a94eb9eb0343526f4b36e45e0a2e2c2105e84bdd
Author: Balazs Varga <[email protected]>
Date: Fri Mar 29 23:00:50 2024 +0100
Related: tdf#39052 - chart ooxml: export formatted chart titles
texts properly to ooxml.
Also adding "FormattedStrings" property for title objects
to simplify the working of character formattings in editable
chart shapes.
TODO: odf import/export
Change-Id: Ie27b4dee72c24fa6a2a4e2a7db8da7fa50eb8937
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165583
Tested-by: Jenkins
Tested-by: Gabor Kelemen <[email protected]>
Reviewed-by: Balazs Varga <[email protected]>
commit 1e1975e6c4f2369e757324d3a2b7910b5c0aed99
Author: Balazs Varga <[email protected]>
Date: Thu Mar 28 17:55:30 2024 +0100
tdf#39052 - Chart: make characters formatable in editable chart textshapes
Editable textshapes include main chart title, sub chart title, axis titles.
In chart2 the chart2::XFormattedString and chart2::XFormattedString2 store
the formatted characters from textshapes, so we need to set all the
character
properties from the EditTextObject and need to add them to to the
XFormattedString
array with all the related texts which are formatted individually.
For formatting of the characters the .uno:FontDialog command can be used,
which can be called from the chart menubar, toolbar and with right click
on the text when we are in edit mode in the textshape.
(Note: in the next patch the OOXML export will be fixed.)
cherry-pick from commit: 4f994cec388377cc5c2bddb804bd92eb4cd7dc8d
Change-Id: I5750a5fe694b384dc6b28e2ef03ac1f2b03957db
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165501
Tested-by: Jenkins
Tested-by: Gabor Kelemen <[email protected]>
Reviewed-by: Balazs Varga <[email protected]>
commit 4023cd276990cdced46eaafd148f034dea42005e
Author: Balazs Varga <[email protected]>
Date: Thu Mar 28 17:17:47 2024 +0100
tdf#78027 - Fix Chart OOXML Import with non-uniform formatted titles
Character formats are disappeared from Chart Title textobjects if they were
formatted non-uniform. In this patch only the OOXML import and the chartview
part will be fixed which make it visible after the import.
(Note: next patch will contain the chart controller part where the
characters
can be formatted during title editing).
cherry-picked from commit: f31a8ff9ea15ad81aeac265fce6eafe6342a68b7
Change-Id: I4fb5c3d80b7889935d198e70fb49e2c68108b235
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165500
Tested-by: Jenkins
Tested-by: Gabor Kelemen <[email protected]>
Reviewed-by: Balazs Varga <[email protected]>
commit 47b0c33eb0e4defda6f2e8c3eb143f1345cdc1b9
Author: Balazs Varga <[email protected]>
Date: Wed Mar 20 18:32:44 2024 +0100
tdf#159687 sc formula SUMPRODUCT performance fix: add more binary
operators which need to be checked if they are next to a trimmable
DoubleRef arguments or not.
Example:
=SUMPRODUCT(($D:$D>M47:M47)*($D:$D<M48:M48)*($I:$I=N$41)) -->
$D:$D and $I:$I columns are trimmable.
Recalculation of formulas with a lot of SUMPRODUCT where we comparing
full columns could take minutes during editing a sheet. With reducing
the size of the compared ranges to the actual data could significantly
speed up the recalculation.
This takes the recalculation time from ~50 sec to <1 sec on my machine.
Note: probabaly the same could be applied to the SUM function.
Change-Id: I758660d0b638ef7255bd5a41a96755289b5a2b41
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165074
Tested-by: Jenkins
Reviewed-by: Noel Grandin <[email protected]>
Reviewed-by: Balazs Varga <[email protected]>
commit 41e8bdf9ca2415eda7125b199e828c82346c33e0
Author: Balazs Varga <[email protected]>
Date: Thu Mar 7 14:32:44 2024 +0100
tdf#159456 - chart view: fix wrongly shifted value Y axis
We only have to shift the category axis only, and not the
value axis, if we have a chart data table.
Change-Id: Ie77ea829e8f8987702dce7d17cb3e20054f3d8cc
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164539
Tested-by: Jenkins
Reviewed-by: Balazs Varga <[email protected]>
commit 0441c5b001f636ab6833d3682db26fcaaa127e3a
Author: Balazs Varga <[email protected]>
Date: Wed Mar 6 22:52:44 2024 +0100
tdf#159422 - chart view: fix symbols position of data table legend
Calculate the correct/optimal row height after calculating and set
correct width of a table cell. Then we will have the correct row height
for the symbol positions.
Change-Id: I65bc0f0579ea100906b0b32449c2200a54c2a353
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164512
Tested-by: Jenkins
Reviewed-by: Balazs Varga <[email protected]>
commit a50a7ab13c62de28b8da5f8c4245caa160674016
Author: Balazs Varga <[email protected]>
Date: Wed Mar 6 14:54:22 2024 +0100
tdf#159443 - chart view: fix Data table is not rendered below chart
If we have 1 dataseries we will have no tickmarks, in that case the
distance between two tickmarks is the width of the chart.
Change-Id: Ifea11329f1dcb80e8e390c1408306d1df7d49ded
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164471
Tested-by: Jenkins
Reviewed-by: Balazs Varga <[email protected]>
commit b5c45f9995ccae16abd46af056e79928ae5d19db
Author: Samuel Mehrbrodt <[email protected]>
Date: Thu Mar 7 22:51:51 2024 +0100
tdf#160071 Don't clone formatting to whole boxes
when clicking into an empty area of that box
Change-Id: I383f1584f446e29454eda2177c8bae0f6587e42d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164555
Tested-by: Jenkins
Reviewed-by: Thorsten Behrens <[email protected]>
commit 09e9c7313656a40174ace4d3a9f78ed7f907c53c
Author: Oliver Specht <[email protected]>
Date: Thu Mar 7 12:47:22 2024 +0100
tdf#159726 Improve Clone formatting
Paragraph attributes and lists are copied if there is no source
selection or the source selection includes at least a full paragraph.
They are only applied to an empty or a paragraph selection.
As in tdf#160069 requested the clone formatting function is only enabled
in text edit mode.
Change-Id: I789402a7928837bb85ec941fd6f958d12585ac40
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164533
Tested-by: Thorsten Behrens <[email protected]>
Reviewed-by: Thorsten Behrens <[email protected]>
(cherry picked from commit 456d0216aae69c39b12a5df749525589871272a7)
commit 27f85a8a640cfa5ee5be807f447150b20a2b0632
Author: Tibor Nagy <[email protected]>
Date: Wed Feb 28 11:13:10 2024 +0100
tdf#155218 sc: fix regression page orientation in print dialog
The print page orientation set in the Print Dialog displays incorrect
print area borders on the sheet after closing the Print Dialog or
interrupting the printing process.
The print dialog increase in size if the "Pages" and "All pages" radio
buttons are toggled many times.(problem is not reproduced on Windows)
regression was made by: I5e494a0714e398221bee00744d7e25c419a41df7
Includes "Read of uninitialized Printer::mbResetPrintArea" fixup by Stephan.
Change-Id: I5a0ab3d781b21eff575afaebb233237eff1827d5
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164085
Tested-by: Jenkins
Reviewed-by: Nagy Tibor <[email protected]>
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164312
Tested-by: Thorsten Behrens <[email protected]>
Reviewed-by: Thorsten Behrens <[email protected]>
commit 2dabf3780b2246867f5fad66302529937fb428b9
Author: Tibor Nagy <[email protected]>
Date: Sun Feb 11 16:25:48 2024 +0100
tdf#155218 sc: fix incorrect print area
In the print dialog, changes to the page orientation should not alter
the print area that is defined by the page style.
issue caused by commit I5e494a0714e398221bee00744d7e25c419a41df7
(tdf#155218 sc: fix different page orientation in print dialog)
Change-Id: I44eb3b30df0e8a227743df334da35316f86a0679
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163231
Tested-by: Jenkins
Reviewed-by: Nagy Tibor <[email protected]>
commit f3e33e5e4504fb9e7beee02dfc3001a6b302c8a4
Author: Tibor Nagy <[email protected]>
Date: Wed Jan 31 16:49:24 2024 +0100
tdf#155218 sc: fix different page orientation in print dialog
The page orientation is correct if you set it in the page style first.
However, if you change it in the Print dialog the page layout and size
refresh but the content orientation remains the same.
Change-Id: I5e494a0714e398221bee00744d7e25c419a41df7
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162845
Tested-by: Jenkins
Reviewed-by: Nagy Tibor <[email protected]>
commit a9eac986b89adffbe4f4bc50a2c0f325511fbca9
Author: Armin Le Grand <[email protected]>
Date: Thu Apr 18 11:59:26 2024 +0200
Revert "IASS: Correct Buffering of last Slide"
This reverts commit 77eb3f1a76892b6070e77324e260204408383ef4.
Reason for revert:
Better solution in https://gerrit.libreoffice.org/c/core/+/166177
which is 052c668da38b70943d24770895abc8119aace2a6
Change-Id: I42248771c993bcd04c2fe368795db4e1fe7a2586
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166212
Tested-by: Jenkins
Reviewed-by: Armin Le Grand <[email protected]>
commit c53a948107eb388db29ed2b747195db840fe124f
Author: Armin Le Grand (allotropia) <[email protected]>
Date: Wed Apr 17 12:58:18 2024 +0200
tdf#160669 IASS: flush Prefetch for SLideShow as needed
Change-Id: I3c0e2be658358ab5b412ab18cce197eb28e5c0db
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166177
Tested-by: Jenkins
Reviewed-by: Armin Le Grand <[email protected]>
commit 703613799086aa6b98d6eb8480e3fcc2cbf6f623
Author: Armin Le Grand (allotropia) <[email protected]>
Date: Thu Apr 11 16:37:30 2024 +0200
IASS: Correct Buffering of last Slide
There is a mechanism to pre-fetch the next slide, but
at the last slide that just gets not reset/refreshed.
Thus the last slide *is* the buffered slide.
When making changes and refreshing the SlideShow display
for the last slide this pe-fetched one is just used, so
the slide content gets not re-created and thus not
updated.
I added needed code to do that now when reacing the last
slide to make that work.
Change-Id: Ie57e6917e0996d5fce46021aeb933064c47dd90f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166011
Tested-by: Jenkins
Reviewed-by: Armin Le Grand <[email protected]>
commit 9c453a269403ae3bd5f6a092d3d07218bae3caad
Author: Armin Le Grand (allotropia) <[email protected]>
Date: Wed Apr 10 15:29:13 2024 +0200
IASS: Support Mouse-Wheel Actions
The support for MouseWheel was missing. That showed
when using it in IASS the scroll commands were always
feeded to the SlideShow. Thus it was not possible
to e.g. scroll using MouseWheel in EditView when
IASS was active and SlideShow running.
This happens in ViewShell::HandleScrollCommand. It
needs to be made focus-dependent when IASS is active.
This is the same as already done for keyboard input,
so I consolidated this now to a method called
ViewShell::useInputForSlideShow() that does all the
necessary stuff and answers as needed. Using that
in various places: keyboard and MouseWheel, but also
adapted other places where the same has to happen,
mainly some gesture stuff.
Change-Id: I1a697e4b35b195695f1a5ea2305a3cee8851fa8d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165929
Tested-by: Jenkins
Reviewed-by: Armin Le Grand <[email protected]>
commit 5359e588925d8addf7eb2259259098b97ec4551f
Author: Armin Le Grand (allotropia) <[email protected]>
Date: Tue Apr 9 15:01:30 2024 +0200
IASS: Missing updates in OutlinerView mode
It looked like in OutlinerMode in IASS when doing
changes updating the other views were missing. After
debugging and finding no error I found out that the
text as COL_AUTO is painted white on white - all
updates happen but are invisible - argh.
After some more debugging I found that in
ViewShellBase::GetColorConfigColor only the
DrawViewShell case was handled, so I added the
OutlineViewShell now. Since that ViewShell has
no SdViewOptions I hard-coded the DOCCOLOR
to COL_WHITE.
That method returns {} aka COL_BLACK as default
which is a bad default for an office package
with paper as target, so I also changed that
to COL_WHITE - which is the default for unknown
ViewShells now that way. Also adapted the warning
to mention an 'unknown ViewShell' now.
Change-Id: I580a151b4c0a9eb46d190ba84b0c6d0798dc21d7
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165907
Tested-by: Jenkins
Reviewed-by: Armin Le Grand <[email protected]>
commit 0991d601663835bb15cd864f9ef9a7cf68c0d271
Author: Thorsten Behrens <[email protected]>
Date: Thu Apr 4 21:19:02 2024 +0200
IASS: make live slideshow non-experimental
Change-Id: I36fb6eae8f77f02fa1a9bcf96a7c074d78ba86c8
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165804
Tested-by: Jenkins
Reviewed-by: Thorsten Behrens <[email protected]>
commit 4ac5dbe30b746bb001953d65ad2554e9a472d12f
Author: Armin Le Grand (allotropia) <[email protected]>
Date: Thu Mar 28 12:22:12 2024 +0100
IASS: Update NextSlide in PresenterConsole
Change-Id: I6060e95aabfdb5956bf2f4a71d047bdf5c97a723
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165458
Tested-by: Jenkins
Reviewed-by: Armin Le Grand <[email protected]>
commit d973f11a56d434e5f6bdd91b010fda62f5c5b18d
Author: Armin Le Grand (allotropia) <[email protected]>
Date: Thu Mar 28 16:21:24 2024 +0100
IASS: SlidePane/Sorter updates were missing
Change-Id: I75ce5311a74f15397dd5a1762e17ddff3203fc7f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165468
Tested-by: Jenkins
Reviewed-by: Armin Le Grand <[email protected]>
commit cbb97ed54d5b0488d4fc3a5511b9656cc85f1810
Author: Armin Le Grand (allotropia) <[email protected]>
Date: Tue Mar 26 18:35:21 2024 +0100
IASS: Fix crash with PresenterConsole
When being in IASS mode and adding e.g. an effect to
a Shape (or anything else that triggers a preview)
and the PresenterConsole being active, we got a
crash. That happend due to the PresenterConsole
being initialized *twice* due to interpreting that
preview as SlideShow start. It also closed due to
interpreting the preview end as SlideShow end. The
next SlideShow end then bites the dust in an already
messed up situation.
To solve this, SlideshowImpl::startShowImpl now only
uses NotifyDocumentEvent "OnStartPresentation" when
this is not a SlideShow startup.
I also secured PresenterScreen using a local bool
to remember if it is initialized to avoid when that
would be done twice (also used for shutdown).
Change-Id: Ice588e0783fd39ec46d90a40affcaf2f789df8ec
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165356
Tested-by: Jenkins
Reviewed-by: Armin Le Grand <[email protected]>
commit d4cf021c769481cd2177ee53e4c51e31aaae4eca
Author: Armin Le Grand (allotropia) <[email protected]>
Date: Thu Feb 29 16:08:29 2024 +0100
IASS: Update edited Text in other Views
This was not working for multiple Windows for
a document, and also not supported for SlideShow
until now.
If you edit a Text on a Slide (Object, PresObj,
...) that text is not yet set at the Model until
the TextEdit ends. In that situation those changes
are now propagated to other views visualizing that
object. This is done with slight slowdown to not
do it all the time while typing, (currently 350ms,
grepped from other places in the office).
It will be shown in a running open SlideShow (and
evtl. trigger an effect at the Object as Preview).
This will allow to get a good preview for how it
looks in the SlideShow.
This is also done for further EditViews opened
for that Document. This was not done before. It
is fine-tuned to do this only for the Views besides
the EditView with the running TextEdit to not
cause slowdowns in that active view - the TextEdit
is already running on the Overlay to have no
problems with speed, this needs to be preserved.
I had to fix a multi-view error in the a11y stack
that implied that only one view exists and thus
has to have an Outliner - that is wrong for
multiple views, only one will have one.
Change-Id: I781d32a8fcb8732ee8fcfbae72c02d1f99b6cd06
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164160
Tested-by: Jenkins
Reviewed-by: Armin Le Grand <[email protected]>
commit d77c5b11d84a9f6ece07ca341ee0f3240c5042bf
Author: Armin Le Grand (allotropia) <[email protected]>
Date: Fri Feb 23 16:30:23 2024 +0100
IASS: make live slideshow experimental and configurable
* adding an option button to slideshow settings dlg
* switch from env var to officecfg
Change-Id: I9713fde374b04264947daaab73759eb585c4a3f6
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163851
Tested-by: Jenkins
Reviewed-by: Thorsten Behrens <[email protected]>
commit e8531717a309cf287e915643f8252c7e5171e048
Author: Armin Le Grand (allotropia) <[email protected]>
Date: Thu Feb 22 23:25:39 2024 +0100
IASS: Added SdrObject Insert/Remove suppport
Change-Id: I7f6aad0ec12de3c3b2677f1ca07e8efd5a881982
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163797
Tested-by: Jenkins
Reviewed-by: Armin Le Grand <[email protected]>
commit dccb481a564f33e23f12e59081837554872fa3a0
Author: Armin Le Grand (allotropia) <[email protected]>
Date: Thu Feb 22 15:13:33 2024 +0100
IASS: Re-define Text suppression for TextEdit
The current version suppressed text for Objects
in edit mode for the paint in the view since that
text is painted/visualized by the EditEngine/Overlay
while it is being edited, so that would be displayed
twice - and in different states.
That is correct, but e.g. also suppressed display
for e.g. an opened second Window for the Document or
in a running SlideShow.
The mechanism uses embedding the Text in case it gets
edited to a simple Primitive that then can be
suppressed by the view rendering it. It decomposed
to empty, thus to visualize it a renderer had to
actively identify and process it.
I now turnedd this around - it is a normal
GroupPrimitive2D and decomposes to the text content,
so will be visualized by all renderers that do not
actively suppress it. To actively suppress it I added
a get/setTextEditActive marker to ViewInformation2D
that will be used by the ObjectContactOfPageView
to signal exactly that and to suppress in the pixel
based VCLRenderer in that case.
This is important e.g. for 2nd view window, but also
for PDF export with active TextEdit (yes, happens)
and SlideShow.
There was also support missing for an up-to-now
empty/new object (no text yet) so that text from the
active TextEdit was not provided, corrected that.
Change-Id: I0d8befdb023028d78ce341091331e9a83a0173bd
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163773
Tested-by: Jenkins
Reviewed-by: Armin Le Grand <[email protected]>
commit 5aace287d4f54d5c86d899fb59d605d949964a3c
Author: Armin Le Grand (allotropia) <[email protected]>
Date: Wed Feb 21 15:51:23 2024 +0100
IASS: Allow exit Impress when SlideShow is running
Change-Id: Iffccf2c7fe37845f9da44fd911cf974db026af89
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163697
Tested-by: Jenkins
Reviewed-by: Armin Le Grand <[email protected]>
commit b9231bd2929f244eae77f32e05939d11690984e8
Author: Armin Le Grand (allotropia) <[email protected]>
Date: Tue Feb 20 20:03:51 2024 +0100
IASS: Avoid more SlideShow shutdowns
There are many ways the SlideShow may be stopped,
but with IASS mode less are needed. Identified
quite some and added needed code.
Also added that for setting transitions or adding
an effect to an Object when the SlideShow is up
(the FullScreen one, makes no sense in-place)
the Preview for that is show in the running
SlideShow by switching to it, showing, and back.
So this is used in this mode as a permanent
preview for those changes.
Change-Id: I5cc34e230358aecad30fec8aee05acfa937f9270
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163669
Tested-by: Jenkins
Reviewed-by: Armin Le Grand <[email protected]>
commit de0eb878e82fc67fd7a409e80e8ff3e4f1638a8b
Author: Armin Le Grand (allotropia) <[email protected]>
Date: Fri Feb 16 17:01:39 2024 +0100
IASS: Preparations for InterActiveSlideShow
The idea is a long wanted feature, to allow the
EditView to stay active during a running Presentation
so that you can do changes which then directly show
up in the running presentation. This will need quite
some steps. To be on the safe side all of the changes
are isolated by a variable to cause no harm. For
now this uses ENVVAR ENABLE_INTERACTIVE_SLIDESHOW,
but that may change e.g. as config entry or option.
Change-Id: Id0ab9a473603225456206fbd933e932248681509
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163514
Tested-by: Jenkins
Reviewed-by: Armin Le Grand <[email protected]>
commit d3232b07432e8a7dadf80dc4db61ca4c5a558630
Author: Oliver Specht <[email protected]>
Date: Tue Jan 30 17:07:46 2024 +0100
tdf#159662 Add table alignment and left/right spacing to sidebar in Writer
Change-Id: I12d898f21ca8c7d581aaa1c587c5b6434a35f516
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162769
Tested-by: Jenkins
Reviewed-by: Gabor Kelemen <[email protected]>
commit 53097d69179732b20f822e166fb8a6c9c3476cc2
Author: Samuel Mehrbrodt <[email protected]>
Date: Mon Jan 29 16:04:45 2024 +0100
tdf#159428 Prefer heading over bookmarks in Navigator
When a bookmark is in a heading, highlighting the heading
is more important than highlighting the bookmark.
Change-Id: I6348e42b14ece226a25961bd3145193645972e79
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162694
Tested-by: Jenkins
Reviewed-by: Samuel Mehrbrodt <[email protected]>
commit 2ef7628a25627fafa2fabfb094ba4027cfb5d143
Author: Thorsten Behrens <[email protected]>
Date: Tue Feb 20 01:33:17 2024 -0800
perf: hard-disable D2DWriteTextRenderer code path
On certain Windows / hardware / driver combinations, this triggers a
real slow path. It also tends to be used more widely since 7.5,
overall slowing down scrolling large text documents measurably.
Change-Id: I64a76e7470b5ed1fd4d38f0e9dce28ca6f52ef04
commit 46218dcfbaf27e6ebb4229b6d8226fca333c72fe
Author: Oliver Specht <[email protected]>
Date: Mon Feb 19 09:52:46 2024 +0100
Make Clone Formatting in Impress similar to PP
In Powerpoint paragraph attributes are only applied from and to
fully/multiple selected paragraphs.
Change-Id: I7c1f3afb6c0d6fd9b3f8acf34cb5f5b3dcaf22d7
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163583
Tested-by: Jenkins
Reviewed-by: Thorsten Behrens <[email protected]>
commit 7ceb9eec4a79904aef0586b08f46f2c317624261
Author: Oliver Specht <[email protected]>
Date: Thu Feb 1 11:06:02 2024 +0100
prefer simple HTML format over RTF while pasting clipboard content
This changes applies to draw text, only
JUnit test is included
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162871
Change-Id: I00387f3932c0aa54099c9bc7390ad86b4398b417
