Hi,
Please find the latest report on new defect(s) introduced to LibreOffice found
with Coverity Scan.
3 new defect(s) introduced to LibreOffice found with Coverity Scan.
2 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent
build analyzed by Coverity Scan.
New defect(s) Reported-by: Coverity Scan
Showing 3 of 3 defect(s)
** CID 1592910: Null pointer dereferences (NULL_RETURNS)
________________________________________________________________________________________________________
*** CID 1592910: Null pointer dereferences (NULL_RETURNS)
/sw/source/core/edit/edsect.cxx: 349 in lcl_SpecialInsertNode(const SwPosition
*)()
343 // only protection outside needs to be checked
344 if( pSection &&
345 (SectionType::ToxHeader == pSection->GetType() ||
346 SectionType::ToxContent == pSection->GetType()))
347 {
348 if (SectionType::ToxHeader == pSection->GetType())
>>> CID 1592910: Null pointer dereferences (NULL_RETURNS)
>>> Dereferencing a pointer that might be "nullptr" "pSection->GetParent()"
>>> when calling "GetFormat".
349 pInnermostNode =
pSection->GetParent()->GetFormat()->GetSectionNode();
350 bIsProtected = static_cast<const
SwSectionNode*>(pInnermostNode)->IsInProtectSect();
351 }
352
353 // The previous version had a check to skip empty read-only
sections. Those
354 // shouldn't occur, so we only need to check whether our
pInnermostNode is
** CID 1592909: Null pointer dereferences (REVERSE_INULL)
/sw/source/core/edit/edsect.cxx: 337 in lcl_SpecialInsertNode(const SwPosition
*)()
________________________________________________________________________________________________________
*** CID 1592909: Null pointer dereferences (REVERSE_INULL)
/sw/source/core/edit/edsect.cxx: 337 in lcl_SpecialInsertNode(const SwPosition
*)()
331 }
332 else
333 pInnermostNode = pTableNode;
334 }
335 }
336 bool bIsProtected = pInnermostNode->IsProtect();
>>> CID 1592909: Null pointer dereferences (REVERSE_INULL)
>>> Null-checking "pInnermostNode" suggests that it may be null, but it has
>>> already been dereferenced on all paths leading to the check.
337 if(pInnermostNode != nullptr)
338 {
339 //special case - ToxSection
340 // - in this case the inner section could be tox header
341 // section but the new node should be before the content
section
342 // protection of the tox should not prevent the insertion
** CID 1592908: Null pointer dereferences (NULL_RETURNS)
________________________________________________________________________________________________________
*** CID 1592908: Null pointer dereferences (NULL_RETURNS)
/sw/source/core/edit/edsect.cxx: 336 in lcl_SpecialInsertNode(const SwPosition
*)()
330 pSection = &static_cast<const
SwSectionNode*>(pSectionNode)->GetSection();
331 }
332 else
333 pInnermostNode = pTableNode;
334 }
335 }
>>> CID 1592908: Null pointer dereferences (NULL_RETURNS)
>>> Dereferencing a pointer that might be "nullptr" "pInnermostNode" when
>>> calling "IsProtect".
336 bool bIsProtected = pInnermostNode->IsProtect();
337 if(pInnermostNode != nullptr)
338 {
339 //special case - ToxSection
340 // - in this case the inner section could be tox header
341 // section but the new node should be before the content
section
________________________________________________________________________________________________________
To view the defects in Coverity Scan visit,
https://u15810271.ct.sendgrid.net/ls/click?upn=u001.AxU2LYlgjL6eX23u9ErQy-2BKADyCpvUKOL6EWmZljiu6VvXBlQRUbS683tC8265rGNPXqJ1ffcoLZCnTuJFQbNcTEkb4XaEQkzovKhJ5DB3c-3DoByu_A9M4dSy7guk8NP6DcfgslOyvJRzavztVIKj6nRqYjYpWom7SJFyX0y710bz0kUGtQnnP2Sl-2BcQ8L7jLCiUvR0e20beDprWglfuXB9hxvFXmlxGvnqQ6tKW7XlK3i8VGudPmeOrrs0Wv9ppjT9Kvmk0vnqDB7iIZaTN8mBl-2BIFQpqyiv4ZzeA3By8mGuMOg99GWdNOmQeHQ3EaGZtYA33KPc43G0l-2Beciq31oEU-2BnMJk-3D
