include/sfx2/IDocumentModelAccessor.hxx | 1 + 1 file changed, 1 insertion(+)
New commits: commit 9d2f0af3593449c6909cf8122a84d0104aeb27c0 Author: Marco Cecchetti <[email protected]> AuthorDate: Tue Jan 30 16:28:38 2024 +0100 Commit: Tomaž Vajngerl <[email protected]> CommitDate: Wed Jan 31 09:01:36 2024 +0100 IDocumentModelAccessor: fix for clang warning include/c++/13/bits/shared_ptr_base.h:921:8: error: delete called on non-final 'sc::DocumentModelAccessor' that has virtual functions but non-virtual destructor [-Werror,-Wdelete-non-abstract-non-virtual-dtor] sc/source/ui/docshell/docsh.cxx:226:13: note: in instantiation of function template specialization 'std::__shared_ptr<sfx::IDocumentModelAccessor>::reset<sc::DocumentModelAccessor>' requested here 226 | pReturn.reset(new sc::DocumentModelAccessor(m_pDocument)); Change-Id: I7c6827107530afc39ee69f7e17db3cf159e18ed8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162774 Tested-by: Jenkins CollaboraOffice <[email protected]> Reviewed-by: Tomaž Vajngerl <[email protected]> diff --git a/include/sfx2/IDocumentModelAccessor.hxx b/include/sfx2/IDocumentModelAccessor.hxx index 8bd0f6b68c95..d843a1b41ed8 100644 --- a/include/sfx2/IDocumentModelAccessor.hxx +++ b/include/sfx2/IDocumentModelAccessor.hxx @@ -35,6 +35,7 @@ class SFX2_DLLPUBLIC IDocumentModelAccessor { public: virtual std::vector<CurrencyID> getDocumentCurrencies() const { return {}; } + virtual ~IDocumentModelAccessor() = default; }; } // end sfx namespace
