comphelper/source/streaming/seqinputstreamserv.cxx | 3 +-- tools/source/generic/bigint.cxx | 9 +++++---- 2 files changed, 6 insertions(+), 6 deletions(-)
New commits: commit cee019927fe3beaf20653e1a98beb85147d14aad Author: Caolán McNamara <[email protected]> AuthorDate: Fri Dec 22 21:45:02 2023 +0000 Commit: Caolán McNamara <[email protected]> CommitDate: Sat Dec 23 14:40:16 2023 +0100 cid#1545209 COPY_INSTEAD_OF_MOVE Change-Id: Idd82be5f2354787735f4e47e8cfe9e9a7371a973 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161203 Tested-by: Jenkins Reviewed-by: Caolán McNamara <[email protected]> diff --git a/comphelper/source/streaming/seqinputstreamserv.cxx b/comphelper/source/streaming/seqinputstreamserv.cxx index 5d10029a5024..22fe8f8f0ea1 100644 --- a/comphelper/source/streaming/seqinputstreamserv.cxx +++ b/comphelper/source/streaming/seqinputstreamserv.cxx @@ -196,9 +196,8 @@ void SAL_CALL SequenceInputStreamService::initialize( const uno::Sequence< css:: uno::Reference< io::XInputStream > xInputStream( static_cast< ::cppu::OWeakObject* >( new ::comphelper::SequenceInputStream( aSeq ) ), uno::UNO_QUERY_THROW ); - uno::Reference< io::XSeekable > xSeekable( xInputStream, uno::UNO_QUERY_THROW ); + m_xSeekable.set(xInputStream, uno::UNO_QUERY_THROW); m_xInputStream = xInputStream; - m_xSeekable = xSeekable; m_bInitialized = true; } commit 8013fcadd975d5e72e86afd96de41feaca42a23a Author: Caolán McNamara <[email protected]> AuthorDate: Fri Dec 22 21:42:05 2023 +0000 Commit: Caolán McNamara <[email protected]> CommitDate: Sat Dec 23 14:40:09 2023 +0100 cid#1471704 Assignment of overlapping memory overlapping_assignment: Assigning (*this).nNum[0] to (*this).nVal, which have overlapping memory locations and different types. Change-Id: I70d7236af27bf5399ad5eb5553befd2eb33e37db Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161202 Tested-by: Jenkins Reviewed-by: Caolán McNamara <[email protected]> diff --git a/tools/source/generic/bigint.cxx b/tools/source/generic/bigint.cxx index 240494dfc15d..80b86af6013c 100644 --- a/tools/source/generic/bigint.cxx +++ b/tools/source/generic/bigint.cxx @@ -76,14 +76,15 @@ void BigInt::Normalize() { constexpr sal_uInt32 maxForPosInt32 = std::numeric_limits<sal_Int32>::max(); constexpr sal_uInt32 maxForNegInt32 = -sal_Int64(std::numeric_limits<sal_Int32>::min()); - if (bIsNeg && nNum[0] <= maxForNegInt32) + sal_uInt32 nNum0 = nNum[0]; + if (bIsNeg && nNum0 <= maxForNegInt32) { - nVal = -sal_Int64(nNum[0]); + nVal = -sal_Int64(nNum0); nLen = 0; } - else if (!bIsNeg && nNum[0] <= maxForPosInt32) + else if (!bIsNeg && nNum0 <= maxForPosInt32) { - nVal = nNum[0]; + nVal = nNum0; nLen = 0; } }
