tools/qa/cppunit/test_bigint.cxx |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

New commits:
commit 448276b27d5239eca0173b3c7a1c8563040d1db6
Author:     Mike Kaganski <[email protected]>
AuthorDate: Sat Dec 16 18:48:40 2023 +0100
Commit:     René Engelhard <[email protected]>
CommitDate: Sun Dec 17 19:52:57 2023 +0100

    Drop incorrect conditional compilation
    
    Since commit 396196d6143e377f83a81557f4630ac7e7ad9471 (BigInt's
    non-big value type is currently sal_Int32, 2020-11-14), fixed-size
    sal_Int32 is used in the unit test; so it must not depend on size
    of unrelated long type.
    
    Change-Id: Ida276e87b927381d093796f4137774a18acded82
    Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160857
    Tested-by: Jenkins
    Reviewed-by: Mike Kaganski <[email protected]>
    (cherry picked from commit 1d2f9683c664bd3af9331fb2901eaa4dbff29351)
    Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160858
    Tested-by: René Engelhard <[email protected]>
    Reviewed-by: René Engelhard <[email protected]>

diff --git a/tools/qa/cppunit/test_bigint.cxx b/tools/qa/cppunit/test_bigint.cxx
index 140562df0e23..3c7740fb7651 100644
--- a/tools/qa/cppunit/test_bigint.cxx
+++ b/tools/qa/cppunit/test_bigint.cxx
@@ -22,6 +22,8 @@
 
 #include <tools/bigint.hxx>
 
+#include <limits>
+
 namespace tools
 {
 class BigIntTest : public CppUnit::TestFixture
@@ -54,7 +56,6 @@ void BigIntTest::testConstructionFromLongLong()
         CPPUNIT_ASSERT_EQUAL(static_cast<sal_Int32>(-42), 
static_cast<sal_Int32>(bi));
     }
 
-#if SAL_TYPES_SIZEOFLONG < SAL_TYPES_SIZEOFLONGLONG
     // positive number just fitting to sal_Int32
     {
         BigInt 
bi(static_cast<sal_Int64>(std::numeric_limits<sal_Int32>::max()));
@@ -88,7 +89,6 @@ void BigIntTest::testConstructionFromLongLong()
         CPPUNIT_ASSERT(bi.IsNeg());
         CPPUNIT_ASSERT(!bi.IsLong());
     }
-#endif
 }
 
 CPPUNIT_TEST_SUITE_REGISTRATION(BigIntTest);

Reply via email to