android/source/lint-baseline.xml | 291 ++-------------------------------- android/source/res/values/strings.xml | 14 - 2 files changed, 19 insertions(+), 286 deletions(-)
New commits: commit da292a61c48876c742138271becb42e201d48ee5 Author: Michael Weghorn <[email protected]> AuthorDate: Fri Dec 15 11:21:18 2023 +0100 Commit: Michael Weghorn <[email protected]> CommitDate: Fri Dec 15 17:28:14 2023 +0100 android: Update lint baseline Update the list of known (tolerated for now) issues by deleting lint-baseline.xml and running `make` to regenerate the file, so recent translation-related (config) changes are reflected. Change-Id: If8a39d72ba83c2a2e0bab9830c69095445943b09 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160818 Tested-by: Jenkins Reviewed-by: Michael Weghorn <[email protected]> diff --git a/android/source/lint-baseline.xml b/android/source/lint-baseline.xml index b4c05e26dc6b..24e6447295e3 100644 --- a/android/source/lint-baseline.xml +++ b/android/source/lint-baseline.xml @@ -188,116 +188,6 @@ column="36"/> </issue> - <issue - id="MissingTranslation" - message=""about_privacy_policy" is not translated in "tr" (Turkish)" - errorLine1=" <string name="about_privacy_policy">Privacy Policy</string>" - errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~"> - <location - file="res/values/strings.xml" - line="16" - column="13"/> - </issue> - - <issue - id="MissingTranslation" - message=""create_file" is not translated in "de" (German) or "tr" (Turkish)" - errorLine1=" <string name="create_file">Create New File</string>" - errorLine2=" ~~~~~~~~~~~~~~~~~~"> - <location - file="res/values/strings.xml" - line="18" - column="13"/> - </issue> - - <issue - id="MissingTranslation" - message=""select_file_to_open" is not translated in "tr" (Turkish)" - errorLine1=" <string name="select_file_to_open">Select file to open</string>" - errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~"> - <location - file="res/values/strings.xml" - line="25" - column="13"/> - </issue> - - <issue - id="MissingTranslation" - message=""search_find_next" is not translated in "de" (German) or "tr" (Turkish)" - errorLine1=" <string name="search_find_next">Find Next</string>" - errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~"> - <location - file="res/values/strings.xml" - line="30" - column="13"/> - </issue> - - <issue - id="MissingTranslation" - message=""search_find_previous" is not translated in "de" (German) or "tr" (Turkish)" - errorLine1=" <string name="search_find_previous">Find Previous</string>" - errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~"> - <location - file="res/values/strings.xml" - line="31" - column="13"/> - </issue> - - <issue - id="MissingTranslation" - message=""action_save_as" is not translated in "tr" (Turkish)" - errorLine1=" <string name="action_save_as">Save As...</string>" - errorLine2=" ~~~~~~~~~~~~~~~~~~~~~"> - <location - file="res/values/strings.xml" - line="53" - column="13"/> - </issue> - - <issue - id="MissingTranslation" - message=""message_saving_failed" is not translated in "tr" (Turkish)" - errorLine1=" <string name="message_saving_failed">Saving the document failed.</string>" - errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~"> - <location - file="res/values/strings.xml" - line="61" - column="13"/> - </issue> - - <issue - id="MissingTranslation" - message=""pdf_export_finished" is not translated in "tr" (Turkish)" - errorLine1=" <string name="pdf_export_finished">PDF export finished</string>" - errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~"> - <location - file="res/values/strings.xml" - line="158" - column="13"/> - </issue> - - <issue - id="MissingTranslation" - message=""unable_to_save" is not translated in "tr" (Turkish)" - errorLine1=" <string name="unable_to_save">Unable to save file</string>" - errorLine2=" ~~~~~~~~~~~~~~~~~~~~~"> - <location - file="res/values/strings.xml" - line="160" - column="13"/> - </issue> - - <issue - id="MissingTranslation" - message=""automatic" is not translated in "tr" (Turkish)" - errorLine1=" <string name="automatic">Automatic</string>" - errorLine2=" ~~~~~~~~~~~~~~~~"> - <location - file="res/values/strings.xml" - line="172" - column="13"/> - </issue> - <issue id="SetJavaScriptEnabled" message="Using `setJavaScriptEnabled` can introduce XSS vulnerabilities into your application, review carefully" @@ -1257,160 +1147,6 @@ file="res/drawable-mdpi/shadow.png"/> </issue> - <issue - id="UnusedResources" - message="The resource `R.string.app_about_name` appears to be unused" - errorLine1=" <string name="app_about_name"><b>LibreOffice Viewer \'Beta\'</b></string>" - errorLine2=" ~~~~~~~~~~~~~~~~~~~~~"> - <location - file="res/values/strings.xml" - line="7" - column="13"/> - </issue> - - <issue - id="UnusedResources" - message="The resource `R.string.browser_app_name` appears to be unused" - errorLine1=" <string name="browser_app_name">LibreOffice Browser</string>" - errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~"> - <location - file="res/values/strings.xml" - line="27" - column="13"/> - </issue> - - <issue - id="UnusedResources" - message="The resource `R.string.menu_search` appears to be unused" - errorLine1=" <string name="menu_search">Search</string>" - errorLine2=" ~~~~~~~~~~~~~~~~~~"> - <location - file="res/values/strings.xml" - line="28" - column="13"/> - </issue> - - <issue - id="UnusedResources" - message="The resource `R.string.search_not_found` appears to be unused" - errorLine1=" <string name="search_not_found">Keyword not found</string>" - errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~"> - <location - file="res/values/strings.xml" - line="29" - column="13"/> - </issue> - - <issue - id="UnusedResources" - message="The resource `R.string.menu_preferences` appears to be unused" - errorLine1=" <string name="menu_preferences">Preferences</string>" - errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~"> - <location - file="res/values/strings.xml" - line="32" - column="13"/> - </issue> - - <issue - id="UnusedResources" - message="The resource `R.string.action_bold` appears to be unused" - errorLine1=" <string name="action_bold">Bold</string>" - errorLine2=" ~~~~~~~~~~~~~~~~~~"> - <location - file="res/values/strings.xml" - line="47" - column="13"/> - </issue> - - <issue - id="UnusedResources" - message="The resource `R.string.action_underline` appears to be unused" - errorLine1=" <string name="action_underline">Underline</string>" - errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~"> - <location - file="res/values/strings.xml" - line="48" - column="13"/> - </issue> - - <issue - id="UnusedResources" - message="The resource `R.string.action_italic` appears to be unused" - errorLine1=" <string name="action_italic">Italic</string>" - errorLine2=" ~~~~~~~~~~~~~~~~~~~~"> - <location - file="res/values/strings.xml" - line="49" - column="13"/> - </issue> - - <issue - id="UnusedResources" - message="The resource `R.string.action_strikeout` appears to be unused" - errorLine1=" <string name="action_strikeout">Strike Out</string>" - errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~"> - <location - file="res/values/strings.xml" - line="50" - column="13"/> - </issue> - - <issue - id="UnusedResources" - message="The resource `R.string.message_save_incomplete` appears to be unused" - errorLine1=" <string name="message_save_incomplete">Save incomplete. Were there any changes?</string>" - errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"> - <location - file="res/values/strings.xml" - line="62" - column="13"/> - </issue> - - <issue - id="UnusedResources" - message="The resource `R.string.alert_copy_svg_slide_show_to_clipboard` appears to be unused" - errorLine1=" <string name="alert_copy_svg_slide_show_to_clipboard">Your Android device doesn\'t support in-app svg slideshow. We copied the slideshow link to clipboard. Please press home button, open a modern web browser, paste in the address bar, and go.</string>" - errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"> - <location - file="res/values/strings.xml" - line="77" - column="13"/> - </issue> - - <issue - id="UnusedResources" - message="The resource `R.string.alert_copy_svg_slide_show_to_clipboard_dismiss` appears to be unused" - errorLine1=" <string name="alert_copy_svg_slide_show_to_clipboard_dismiss">OK</string>" - errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"> - <location - file="res/values/strings.xml" - line="78" - column="13"/> - </issue> - - <issue - id="UnusedResources" - message="The resource `R.string.unable_to_go_further` appears to be unused" - errorLine1=" <string name="unable_to_go_further">Unable to go further.</string>" - errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~"> - <location - file="res/values/strings.xml" - line="154" - column="13"/> - </issue> - - <issue - id="UnusedResources" - message="The resource `R.string.directory_not_saved` appears to be unused" - errorLine1=" <string name="directory_not_saved">Directory not saved.</string>" - errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~"> - <location - file="res/values/strings.xml" - line="164" - column="13"/> - </issue> - <issue id="UnusedResources" message="The resource `R.layout.text_selection_handles` appears to be unused" @@ -1513,22 +1249,33 @@ <issue id="TypographyEllipsis" message="Replace "..." with ellipsis character (…, &#8230;) ?" - errorLine1=" <string name="action_save_as">Speichern unter...</string>" - errorLine2=" ~~~~~~~~~~~~~~~~~~"> + errorLine1=" <string name="action_save_as">Պահել որպես...</string>" + errorLine2=" ~~~~~~~~~~~~~~"> <location - file="res/values-de/strings.xml" - line="50" + file="res/values-hy/strings.xml" + line="36" column="35"/> </issue> <issue id="TypographyEllipsis" message="Replace "..." with ellipsis character (…, &#8230;) ?" - errorLine1=" <string name="action_save_as">Save As...</string>" - errorLine2=" ~~~~~~~~~~"> + errorLine1=" <string name="action_save_as">Cadw Fel...</string>" + errorLine2=" ~~~~~~~~~~~"> <location - file="res/values/strings.xml" - line="53" + file="res/values-cy/strings.xml" + line="40" + column="35"/> + </issue> + + <issue + id="TypographyEllipsis" + message="Replace "..." with ellipsis character (…, &#8230;) ?" + errorLine1=" <string name="action_save_as">Gardar como...</string>" + errorLine2=" ~~~~~~~~~~~~~~"> + <location + file="res/values-gl/strings.xml" + line="42" column="35"/> </issue> commit a6616674216dfa758484724ea283e2c50be22bc3 Author: Michael Weghorn <[email protected]> AuthorDate: Fri Dec 15 10:28:21 2023 +0100 Commit: Michael Weghorn <[email protected]> CommitDate: Fri Dec 15 17:27:59 2023 +0100 android lint: Drop unused string resources This also avoids that these will show up in Weblate, causing unnecessary work for translators since they're unused anyway. IIUC, dropping the strings in already existing translations should be handled automatically by Weblate. (Leave them there to see whether this actually works as expected.) Change-Id: Icab66a1768f5c6250598fcf788377575d3f6f611 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160821 Tested-by: Jenkins Reviewed-by: Michael Weghorn <[email protected]> diff --git a/android/source/res/values/strings.xml b/android/source/res/values/strings.xml index 1460b525192f..3766db146098 100644 --- a/android/source/res/values/strings.xml +++ b/android/source/res/values/strings.xml @@ -4,7 +4,6 @@ <string name="app_name">LibreOffice Viewer</string> <string name="app_name_settings">LibreOffice Viewer Settings</string> - <string name="app_about_name"><b>LibreOffice Viewer \'Beta\'</b></string> <string name="app_version">Version: %1$s<br>Build ID: <a href="https://hub.libreoffice.org/git-core/%2$s">%2$s</a></string> <string name="app_description">LibreOffice Viewer is a document viewer based on LibreOffice.</string> <string name="app_credits">https://www.libreoffice.org</string> @@ -24,12 +23,8 @@ <string name="select_file_to_open">Select file to open</string> - <string name="browser_app_name">LibreOffice Browser</string> - <string name="menu_search">Search</string> - <string name="search_not_found">Keyword not found</string> <string name="search_find_next">Find Next</string> <string name="search_find_previous">Find Previous</string> - <string name="menu_preferences">Preferences</string> <string name="file_icon_desc">fileicon</string> <string name="title_recents">Recent files</string> <string name="title_browser">All files</string> @@ -44,10 +39,6 @@ <string name="action_settings">Settings</string> <!-- Edit action names --> - <string name="action_bold">Bold</string> - <string name="action_underline">Underline</string> - <string name="action_italic">Italic</string> - <string name="action_strikeout">Strike Out</string> <string name="action_keyboard">Show keyboard</string> <string name="action_save">Save</string> <string name="action_save_as">Save As…</string> @@ -59,7 +50,6 @@ <string name="message_saved">Save complete</string> <string name="message_saving">Saving the document…</string> <string name="message_saving_failed">Saving the document failed.</string> - <string name="message_save_incomplete">Save incomplete. Were there any changes?</string> <string name="password">Password</string> <string name="action_undo">Undo</string> @@ -74,8 +64,6 @@ <!-- Presentation Mode Strings --> <string name="action_presentation">Slide show</string> <string name="action_add_slide">Add Slide</string> - <string name="alert_copy_svg_slide_show_to_clipboard">Your Android device doesn\'t support in-app svg slideshow. We copied the slideshow link to clipboard. Please press home button, open a modern web browser, paste in the address bar, and go.</string> - <string name="alert_copy_svg_slide_show_to_clipboard_dismiss">OK</string> <string name="slideshow_action_back">Back</string> <!-- Calc Header Menu Strings --> @@ -151,7 +139,6 @@ <string name="tabhost_style">Style</string> <string name="alert_ok">OK</string> <string name="alert_cancel">Cancel</string> - <string name="unable_to_go_further">Unable to go further.</string> <string name="current_uno_command">Current UNO command</string> <string name="display_language">Display Language</string> <string name="display_language_summary">Set the default display language</string> @@ -161,7 +148,6 @@ <string name="error">Error</string> <string name="enter_part_name">Enter a part name</string> <string name="bmp_null">Bmp is null!</string> - <string name="directory_not_saved">Directory not saved.</string> <string name="page">Page</string> <string name="sheet">Sheet</string> <string name="slide">Slide</string>
