Hi,
Please find the latest report on new defect(s) introduced to LibreOffice found
with Coverity Scan.
423 new defect(s) introduced to LibreOffice found with Coverity Scan.
22 defect(s), reported by Coverity Scan earlier, were marked fixed in the
recent build analyzed by Coverity Scan.
New defect(s) Reported-by: Coverity Scan
Showing 20 of 423 defect(s)
** CID 1557302: Performance inefficiencies (COPY_INSTEAD_OF_MOVE)
/vcl/source/gdi/pdfwriter_impl.cxx: 10686 in
vcl::PDFWriterImpl::addRoleMap(rtl::OString, vcl::PDFWriter::StructElement)()
________________________________________________________________________________________________________
*** CID 1557302: Performance inefficiencies (COPY_INSTEAD_OF_MOVE)
/vcl/source/gdi/pdfwriter_impl.cxx: 10686 in
vcl::PDFWriterImpl::addRoleMap(rtl::OString, vcl::PDFWriter::StructElement)()
10680 void PDFWriterImpl::addRoleMap(OString aAlias,
PDFWriter::StructElement eType)
10681 {
10682 OString aTag = getStructureTag(eType);
10683 // For PDF/UA it's not allowed to map an alias with the same name.
10684 // Not aware of a reason for doing it in any case, so just don't
do it.
10685 if (aAlias != aTag)
>>> CID 1557302: Performance inefficiencies (COPY_INSTEAD_OF_MOVE)
>>> "aTag" is copied in a call to copy assignment "operator =", when it
>>> could be moved instead.
10686 m_aRoleMap[aAlias] = aTag;
10687 }
10688
10689 void PDFWriterImpl::beginStructureElementMCSeq()
10690 {
10691 assert(m_nCurrentStructElement == 0 ||
m_aStructure[m_nCurrentStructElement].m_oType);
** CID 1557301: Performance inefficiencies (COPY_INSTEAD_OF_MOVE)
/svl/source/items/custritm.cxx: 59 in CntUnencodedStringItem::PutValue(const
com::sun::star::uno::Any &, unsigned char)()
________________________________________________________________________________________________________
*** CID 1557301: Performance inefficiencies (COPY_INSTEAD_OF_MOVE)
/svl/source/items/custritm.cxx: 59 in CntUnencodedStringItem::PutValue(const
com::sun::star::uno::Any &, unsigned char)()
53 bool CntUnencodedStringItem::PutValue(const css::uno::Any& rVal,
54 sal_uInt8)
55 {
56 OUString aTheValue;
57 if (rVal >>= aTheValue)
58 {
>>> CID 1557301: Performance inefficiencies (COPY_INSTEAD_OF_MOVE)
>>> "aTheValue" is copied in a call to copy assignment "operator =", when
>>> it could be moved instead.
59 m_aValue = aTheValue;
60 return true;
61 }
62 OSL_FAIL("CntUnencodedStringItem::PutValue(): Wrong type");
63 return false;
64 }
** CID 1557300: Performance inefficiencies (COPY_INSTEAD_OF_MOVE)
/connectivity/source/drivers/jdbc/ResultSet.cxx: 119 in
connectivity::java_sql_ResultSet::queryInterface(const
com::sun::star::uno::Type &)()
________________________________________________________________________________________________________
*** CID 1557300: Performance inefficiencies (COPY_INSTEAD_OF_MOVE)
/connectivity/source/drivers/jdbc/ResultSet.cxx: 119 in
connectivity::java_sql_ResultSet::queryInterface(const
com::sun::star::uno::Type &)()
113 SDBThreadAttach::releaseRef();
114 }
115
116 css::uno::Any SAL_CALL java_sql_ResultSet::queryInterface( const
css::uno::Type & rType )
117 {
118 css::uno::Any aRet = OPropertySetHelper::queryInterface(rType);
>>> CID 1557300: Performance inefficiencies (COPY_INSTEAD_OF_MOVE)
>>> "aRet" is copied in call to copy constructor
>>> "com::sun::star::uno::Any", when it could be moved instead.
119 return aRet.hasValue() ? aRet :
java_sql_ResultSet_BASE::queryInterface(rType);
120 }
121
122 css::uno::Sequence< css::uno::Type > SAL_CALL
java_sql_ResultSet::getTypes( )
123 {
124 ::cppu::OTypeCollection aTypes(
cppu::UnoType<css::beans::XMultiPropertySet>::get(),
** CID 1557299: Low impact quality (MISSING_MOVE_ASSIGNMENT)
/include/svl/itemset.hxx: 45 in ()
________________________________________________________________________________________________________
*** CID 1557299: Low impact quality (MISSING_MOVE_ASSIGNMENT)
/include/svl/itemset.hxx: 45 in ()
39 #endif
40
41 // ItemSet/ItemPool helpers
42 SfxPoolItem const* implCreateItemEntry(SfxItemPool& rPool, SfxPoolItem
const* pSource, sal_uInt16 nWhich, bool bPassingOwnership);
43 void implCleanupItemEntry(SfxItemPool& rPool, SfxPoolItem const*
pSource);
44
>>> CID 1557299: Low impact quality (MISSING_MOVE_ASSIGNMENT)
>>> Class "SfxPoolItemHolder" may benefit from adding a move assignment
>>> operator. See other events which show the copy assignment operator being
>>> applied to rvalues, where a move assignment may be faster.
45 class SAL_WARN_UNUSED SVL_DLLPUBLIC SfxPoolItemHolder
46 {
47 SfxItemPool* m_pPool;
48 const SfxPoolItem* m_pItem;
49 public:
50 SfxPoolItemHolder(SfxItemPool&, const SfxPoolItem* = nullptr);
** CID 1557298: Performance inefficiencies (COPY_INSTEAD_OF_MOVE)
/sw/source/core/doc/DocumentFieldsManager.cxx: 452 in
sw::DocumentFieldsManager::InsDeletedFieldType(SwFieldType &)()
________________________________________________________________________________________________________
*** CID 1557298: Performance inefficiencies (COPY_INSTEAD_OF_MOVE)
/sw/source/core/doc/DocumentFieldsManager.cxx: 452 in
sw::DocumentFieldsManager::InsDeletedFieldType(SwFieldType &)()
446 if( nFieldWhich == pFnd->Which() &&
447 rSCmp.isEqual( sSrch, pFnd->GetName() ) )
448 break;
449 }
450 if( i >= nSize ) // not found
451 {
>>> CID 1557298: Performance inefficiencies (COPY_INSTEAD_OF_MOVE)
>>> "sSrch" is copied in a call to copy assignment "operator =", when it
>>> could be moved instead.
452 const_cast<OUString&>(rFieldNm) = sSrch;
453 break; // exit while loop
454 }
455 ++nNum;
456 } while( true );
457 break;
** CID 1557297: Performance inefficiencies (COPY_INSTEAD_OF_MOVE)
/sfx2/source/doc/objserv.cxx: 1317 in SfxObjectShell::ExecFile_Impl(SfxRequest
&)()
________________________________________________________________________________________________________
*** CID 1557297: Performance inefficiencies (COPY_INSTEAD_OF_MOVE)
/sfx2/source/doc/objserv.cxx: 1317 in SfxObjectShell::ExecFile_Impl(SfxRequest
&)()
1311 }
1312
1313 SetModified( false );
1314 ErrCodeMsg lErr = GetErrorCode();
1315
1316 if (comphelper::LibreOfficeKit::isActive())
>>> CID 1557297: Performance inefficiencies (COPY_INSTEAD_OF_MOVE)
>>> "lErr" is passed-by-value as parameter to "sendErrorToLOK" when it
>>> could be moved instead.
1317 sendErrorToLOK(lErr);
1318 else
1319 ErrorHandler::HandleError(lErr, pDialogParent);
1320
1321 rReq.SetReturnValue( SfxBoolItem(0, true) );
1322 rReq.Done();
** CID 1557296: Performance inefficiencies (COPY_INSTEAD_OF_MOVE)
/svx/source/items/galleryitem.cxx: 118 in SvxGalleryItem::PutValue(const
com::sun::star::uno::Any &, unsigned char)()
________________________________________________________________________________________________________
*** CID 1557296: Performance inefficiencies (COPY_INSTEAD_OF_MOVE)
/svx/source/items/galleryitem.cxx: 118 in SvxGalleryItem::PutValue(const
com::sun::star::uno::Any &, unsigned char)()
112 if ( !bAllConverted || nConverted != SVXGALLERYITEM_PARAMS )
113 return false;
114
115 m_nType = nType;
116 m_aURL = aURL;
117 m_xDrawing = xDrawing;
>>> CID 1557296: Performance inefficiencies (COPY_INSTEAD_OF_MOVE)
>>> "xGraphic" is copied in a call to copy assignment "operator =", when it
>>> could be moved instead.
118 m_xGraphic = xGraphic;
119
120 return true;
121 }
122
123 bool SvxGalleryItem::operator==( const SfxPoolItem& rAttr ) const
** CID 1557295: Performance inefficiencies (COPY_INSTEAD_OF_MOVE)
/vcl/source/gdi/embeddedfontshelper.cxx: 360 in
EmbeddedFontsHelper::fontFileUrl(std::basic_string_view<char16_t,
std::char_traits<char16_t>>, FontFamily, FontItalic, FontWeight, FontPitch,
EmbeddedFontsHelper::FontRights)()
________________________________________________________________________________________________________
*** CID 1557295: Performance inefficiencies (COPY_INSTEAD_OF_MOVE)
/vcl/source/gdi/embeddedfontshelper.cxx: 360 in
EmbeddedFontsHelper::fontFileUrl(std::basic_string_view<char16_t,
std::char_traits<char16_t>>, FontFamily, FontItalic, FontWeight, FontPitch,
EmbeddedFontsHelper::FontRights)()
354 else
355 ok = true;
356 }
357 }
358 }
359 }
>>> CID 1557295: Performance inefficiencies (COPY_INSTEAD_OF_MOVE)
>>> "url" is copied in call to copy constructor "rtl::OUString", when it
>>> could be moved instead.
360 return ok ? url : "";
361 }
362
** CID 1557294: Performance inefficiencies (COPY_INSTEAD_OF_MOVE)
/sw/source/filter/ww8/ww8par3.cxx: 216 in
SwWW8ImplReader::Read_F_FormCheckBox(WW8FieldDesc *, rtl::OUString &)()
________________________________________________________________________________________________________
*** CID 1557294: Performance inefficiencies (COPY_INSTEAD_OF_MOVE)
/sw/source/filter/ww8/ww8par3.cxx: 216 in
SwWW8ImplReader::Read_F_FormCheckBox(WW8FieldDesc *, rtl::OUString &)()
210 sal_uInt16 bkmFindIdx;
211 OUString aBookmarkFind=pB->GetBookmark(currentCP-1,
currentCP+currentLen-1, bkmFindIdx);
212
213 if (!aBookmarkFind.isEmpty()) {
214 pB->SetStatus(bkmFindIdx, BOOK_FIELD); // mark as consumed
by field
215 if (!aBookmarkFind.isEmpty()) {
>>> CID 1557294: Performance inefficiencies (COPY_INSTEAD_OF_MOVE)
>>> "aBookmarkFind" is copied in a call to copy assignment "operator =",
>>> when it could be moved instead.
216 aBookmarkName=aBookmarkFind;
217 }
218 }
219 }
220
221 if (pB!=nullptr && aBookmarkName.isEmpty()) {
** CID 1557293: Performance inefficiencies (COPY_INSTEAD_OF_MOVE)
/xmloff/source/chart/SchXMLChartContext.cxx: 364 in
SchXMLChartContext::startFastElement(int, const
com::sun::star::uno::Reference<com::sun::star::xml::sax::XFastAttributeList>
&)()
________________________________________________________________________________________________________
*** CID 1557293: Performance inefficiencies (COPY_INSTEAD_OF_MOVE)
/xmloff/source/chart/SchXMLChartContext.cxx: 364 in
SchXMLChartContext::startFastElement(int, const
com::sun::star::uno::Reference<com::sun::star::xml::sax::XFastAttributeList>
&)()
358 else if( XML_NAMESPACE_OOO == nClassPrefix )
359 {
360 // service is taken from add-in-name attribute
361 bHasAddin = true;
362
363 aOldChartTypeName = sClassName;
>>> CID 1557293: Performance inefficiencies (COPY_INSTEAD_OF_MOVE)
>>> "sClassName" is copied in a call to copy assignment "operator =", when
>>> it could be moved instead.
364 maChartTypeServiceName = sClassName;
365 }
366 }
367 break;
368
369 case XML_ELEMENT(SVG, XML_WIDTH):
** CID 1557292: Performance inefficiencies (COPY_INSTEAD_OF_MOVE)
/oox/source/drawingml/table/predefined-table-styles.cxx: 910 in
CreateTableStyle(const rtl::OUString &)()
________________________________________________________________________________________________________
*** CID 1557292: Performance inefficiencies (COPY_INSTEAD_OF_MOVE)
/oox/source/drawingml/table/predefined-table-styles.cxx: 910 in
CreateTableStyle(const rtl::OUString &)()
904 pTableStyle->getBand1V().getTextColor() = band1VTextColor;
905 pTableStyle->getBand2H().getTextColor() = band2HTextColor;
906 pTableStyle->getBand2V().getTextColor() = band2VTextColor;
907
908 pTableStyle->getBackgroundFillProperties() = pTblBgFillProperties;
909 pTableStyle->getWholeTbl().getFillProperties() =
pWholeTblFillProperties;
>>> CID 1557292: Performance inefficiencies (COPY_INSTEAD_OF_MOVE)
>>> "pFirstRowFillProperties" is copied in a call to copy assignment
>>> "operator =", when it could be moved instead.
910 pTableStyle->getFirstRow().getFillProperties() =
pFirstRowFillProperties;
911 pTableStyle->getFirstCol().getFillProperties() =
pFirstColFillProperties;
912 pTableStyle->getLastRow().getFillProperties() =
pLastRowFillProperties;
913 pTableStyle->getLastCol().getFillProperties() =
pLastColFillProperties;
914 pTableStyle->getBand1H().getFillProperties() =
pBand1HFillProperties;
915 pTableStyle->getBand1V().getFillProperties() =
pBand1VFillProperties;
** CID 1557291: Performance inefficiencies (COPY_INSTEAD_OF_MOVE)
/drawinglayer/source/processor2d/vclmetafileprocessor2d.cxx: 2222 in
drawinglayer::processor2d::VclMetafileProcessor2D::processMaskPrimitive2D(const
drawinglayer::primitive2d::MaskPrimitive2D &)()
________________________________________________________________________________________________________
*** CID 1557291: Performance inefficiencies (COPY_INSTEAD_OF_MOVE)
/drawinglayer/source/processor2d/vclmetafileprocessor2d.cxx: 2222 in
drawinglayer::processor2d::VclMetafileProcessor2D::processMaskPrimitive2D(const
drawinglayer::primitive2d::MaskPrimitive2D &)()
2216 true, // #i106516# we want the inside of aMask, not
the outside
2217 false);
2218 }
2219 else
2220 {
2221 // use mask directly
>>> CID 1557291: Performance inefficiencies (COPY_INSTEAD_OF_MOVE)
>>> "aMask" is copied in a call to copy assignment "operator =", when it
>>> could be moved instead.
2222 maClipPolyPolygon = aMask;
2223 }
2224
2225 if (maClipPolyPolygon.count())
2226 {
2227 // set VCL clip region; subdivide before conversion to
tools polygon. Subdivision necessary (!)
** CID 1557290: Performance inefficiencies (COPY_INSTEAD_OF_MOVE)
/sc/source/ui/unoobj/linkuno.cxx: 1563 in
ScExternalDocLinkObj::getByIndex(int)()
________________________________________________________________________________________________________
*** CID 1557290: Performance inefficiencies (COPY_INSTEAD_OF_MOVE)
/sc/source/ui/unoobj/linkuno.cxx: 1563 in
ScExternalDocLinkObj::getByIndex(int)()
1557
1558 size_t nIndex = 0;
1559 ScExternalRefCache::TableTypeRef pTable =
mpRefMgr->getCacheTable(mnFileId, aNames[nApiIndex], false, &nIndex);
1560 if (!pTable)
1561 throw lang::IndexOutOfBoundsException();
1562
>>> CID 1557290: Performance inefficiencies (COPY_INSTEAD_OF_MOVE)
>>> "pTable" is passed-by-value as parameter to
>>> "ScExternalSheetCacheObj::ScExternalSheetCacheObj(ScDocShell *,
>>> ScExternalRefCache::TableTypeRef, size_t)" when it could be moved instead.
1563 uno::Reference< sheet::XExternalSheetCache > aSheetCache(new
ScExternalSheetCacheObj(mpDocShell, pTable, nIndex));
1564
1565 return Any(aSheetCache);
1566 }
1567
1568 uno::Reference< container::XEnumeration > SAL_CALL
ScExternalDocLinkObj::createEnumeration()
** CID 1557289: Performance inefficiencies (COPY_INSTEAD_OF_MOVE)
/sc/source/core/tool/rangeutl.cxx: 498 in
ScRangeStringConverter::GetRangeFromString(ScRange &,
std::basic_string_view<char16_t, std::char_traits<char16_t>>, const ScDocument
&, formula::FormulaGrammar::AddressConvention, int &, char16_t, char16_t)()
________________________________________________________________________________________________________
*** CID 1557289: Performance inefficiencies (COPY_INSTEAD_OF_MOVE)
/sc/source/core/tool/rangeutl.cxx: 498 in
ScRangeStringConverter::GetRangeFromString(ScRange &,
std::basic_string_view<char16_t, std::char_traits<char16_t>>, const ScDocument
&, formula::FormulaGrammar::AddressConvention, int &, char16_t, char16_t)()
492 OUString sToken;
493 bool bResult(false);
494 GetTokenByOffset( sToken, rRangeStr, nOffset, cSeparator, cQuote );
495 if( nOffset >= 0 )
496 {
497 sal_Int32 nIndex = IndexOf( sToken, ':', 0, cQuote );
>>> CID 1557289: Performance inefficiencies (COPY_INSTEAD_OF_MOVE)
>>> "sToken" is copied in call to copy constructor "rtl::OUString", when it
>>> could be moved instead.
498 OUString aUIString(sToken);
499
500 if( nIndex < 0 )
501 {
502 if ( aUIString[0] == '.' )
503 aUIString = aUIString.copy( 1 );
** CID 1557288: Performance inefficiencies (COPY_INSTEAD_OF_MOVE)
/sw/source/ui/misc/srtdlg.cxx: 393 in SwSortDlg::LanguageHdl(const
weld::ComboBox *)()
________________________________________________________________________________________________________
*** CID 1557288: Performance inefficiencies (COPY_INSTEAD_OF_MOVE)
/sw/source/ui/misc/srtdlg.cxx: 393 in SwSortDlg::LanguageHdl(const
weld::ComboBox *)()
387
388 for( int n = 0; n < nLstBoxCnt; ++n )
389 {
390 weld::ComboBox* pL = aLstArr[ n ];
391 OUString sUserData = pL->get_active_id();
392 if (!sUserData.isEmpty())
>>> CID 1557288: Performance inefficiencies (COPY_INSTEAD_OF_MOVE)
>>> "sUserData" is copied in a call to copy assignment "operator =", when
>>> it could be moved instead.
393 aOldStrArr[ n ] = sUserData;
394 pL->clear();
395 }
396
397 OUString sAlg, sUINm;
398 const sal_Int32 nEnd = aSeq.getLength();
** CID 1557287: Performance inefficiencies (AUTO_CAUSES_COPY)
/sc/source/ui/unoobj/viewuno.cxx: 2048 in ScTabViewObj::RangeSelAborted(const
rtl::OUString &)()
________________________________________________________________________________________________________
*** CID 1557287: Performance inefficiencies (AUTO_CAUSES_COPY)
/sc/source/ui/unoobj/viewuno.cxx: 2048 in ScTabViewObj::RangeSelAborted(const
rtl::OUString &)()
2042 {
2043 sheet::RangeSelectionEvent aEvent;
2044 aEvent.Source.set(getXWeak());
2045 aEvent.RangeDescriptor = rText;
2046
2047 // copy on the stack because listener could remove itself
>>> CID 1557287: Performance inefficiencies (AUTO_CAUSES_COPY)
>>> Using the "auto" keyword without an "&" causes the copy of an object of
>>> type
>>> "std::vector<com::sun::star::uno::Reference<com::sun::star::sheet::XRangeSelectionListener>,
>>>
>>> std::allocator<com::sun::star::uno::Reference<com::sun::star::sheet::XRangeSelectionListener>
>>> > >".
2048 auto const listeners(aRangeSelListeners);
2049
2050 for (const auto& rListener : listeners)
2051 rListener->aborted( aEvent );
2052 }
2053
** CID 1557286: Performance inefficiencies (COPY_INSTEAD_OF_MOVE)
/sw/source/filter/ww8/wrtw8sty.cxx: 451 in MSWordStyles::BuildStyleIds()()
________________________________________________________________________________________________________
*** CID 1557286: Performance inefficiencies (COPY_INSTEAD_OF_MOVE)
/sw/source/filter/ww8/wrtw8sty.cxx: 451 in MSWordStyles::BuildStyleIds()()
445 int nFree = 1;
446 while (!aUsed.insert(aLower +
OString::number(nFree)).second)
447 ++nFree;
448
449 aStyleId += OString::number(nFree);
450 }
>>> CID 1557286: Performance inefficiencies (COPY_INSTEAD_OF_MOVE)
>>> "aStyleId" is copied in a call to copy assignment "operator =", when it
>>> could be moved instead.
451 entry.style_id = aStyleId;
452 }
453 }
454
455 OString const & MSWordStyles::GetStyleId(sal_uInt16 nSlot) const
456 {
** CID 1557285: Performance inefficiencies (COPY_INSTEAD_OF_MOVE)
/framework/source/uiconfiguration/CommandImageResolver.cxx: 109 in
vcl::CommandImageResolver::registerCommands(const
com::sun::star::uno::Sequence<rtl::OUString> &)()
________________________________________________________________________________________________________
*** CID 1557285: Performance inefficiencies (COPY_INSTEAD_OF_MOVE)
/framework/source/uiconfiguration/CommandImageResolver.cxx: 109 in
vcl::CommandImageResolver::registerCommands(const
com::sun::star::uno::Sequence<rtl::OUString> &)()
103
104 // Image names are not case-dependent. Always use lower case
characters to
105 // reflect this.
106 aImageName = aImageName.toAsciiLowerCase() + ".png";
107
108 m_aImageNameVector[i] = aImageName;
>>> CID 1557285: Performance inefficiencies (COPY_INSTEAD_OF_MOVE)
>>> "aImageName" is copied in a call to copy assignment "operator =", when
>>> it could be moved instead.
109 m_aCommandToImageNameMap[aCommandName] = aImageName;
110 }
111 }
112
113 bool CommandImageResolver::hasImage(const OUString& rCommandURL)
114 {
** CID 1557284: Performance inefficiencies (COPY_INSTEAD_OF_MOVE)
/dbaccess/source/core/api/SingleSelectQueryComposer.cxx: 1434 in
dbaccess::OSingleSelectQueryComposer::getParameters()()
________________________________________________________________________________________________________
*** CID 1557284: Performance inefficiencies (COPY_INSTEAD_OF_MOVE)
/dbaccess/source/core/api/SingleSelectQueryComposer.cxx: 1434 in
dbaccess::OSingleSelectQueryComposer::getParameters()()
1428 if ( !m_aCurrentColumns[ParameterColumns] )
1429 {
1430 ::rtl::Reference< OSQLColumns> aCols =
m_aSqlIterator.getParameters();
1431 std::vector< OUString> aNames;
1432 for (auto const& elem : *aCols)
1433
aNames.push_back(getString(elem->getPropertyValue(PROPERTY_NAME)));
>>> CID 1557284: Performance inefficiencies (COPY_INSTEAD_OF_MOVE)
>>> "aCols" is passed-by-value as parameter to
>>> "dbaccess::OPrivateColumns::OPrivateColumns(rtl::Reference<connectivity::ORefVector<com::sun::star::uno::Reference<com::sun::star::beans::XPropertySet>
>>> > >, bool, cppu::OWeakObject &, osl::Mutex &, std::vector<rtl::OUString,
>>> std::allocator<rtl::OUString> > const &, bool)" when it could be moved
>>> instead.
1434 m_aCurrentColumns[ParameterColumns].reset( new
OPrivateColumns(aCols,m_xMetaData->supportsMixedCaseQuotedIdentifiers(),*this,m_aMutex,aNames,true)
);
1435 }
1436
1437 return m_aCurrentColumns[ParameterColumns].get();
1438 }
1439
** CID 1557283: Performance inefficiencies (COPY_INSTEAD_OF_MOVE)
/framework/source/uiconfiguration/windowstateconfiguration.cxx: 703 in
<unnamed>::ConfigurationAccess_WindowState::impl_insertCacheAndReturnSequence(const
rtl::OUString &, const
com::sun::star::uno::Reference<com::sun::star::container::XNameAccess> &)()
________________________________________________________________________________________________________
*** CID 1557283: Performance inefficiencies (COPY_INSTEAD_OF_MOVE)
/framework/source/uiconfiguration/windowstateconfiguration.cxx: 703 in
<unnamed>::ConfigurationAccess_WindowState::impl_insertCacheAndReturnSequence(const
rtl::OUString &, const
com::sun::star::uno::Reference<com::sun::star::container::XNameAccess> &)()
697 case PROPERTY_UINAME:
698 {
699 OUString aValue;
700 if ( a >>= aValue )
701 {
702 nMask |= WINDOWSTATE_MASK_UINAME;
>>> CID 1557283: Performance inefficiencies (COPY_INSTEAD_OF_MOVE)
>>> "aValue" is copied in a call to copy assignment "operator =", when it
>>> could be moved instead.
703 aWindowStateInfo.aUIName = aValue;
704 bAddToSeq = true;
705 }
706 }
707 break;
708
________________________________________________________________________________________________________
To view the defects in Coverity Scan visit,
https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P0qcxCbhZ31OYv50ypSs1kiFPuCn2xFdlMIFBirii0zZ9j2-2F9F2XPBcBm2BNnPiSHxWPOELPnIxzXoBNaw-3DreFx_OTq2XUZbbipYjyLSo6GRo-2FpVxQ9OzkDINu9UTS-2FQhSdO0F0jQniitrGlNxDIzPJif9GI9NUHWDZpYwHRebBSZ45jpsFc9q1pRpvArIGek-2FL5hgMAroH3eSY-2Bbk3BIMLRSFNkSEwtBxhMsNkG6mIDe8XoLe85XhSnxn0hQqkLaUhdG5MQtC6-2Bl-2FUfgy3PWPLfl7pueU9gK5aWIG8XULfxX-2FVFW3Rgf26UKvu8b7yk2RA-3D
