cui/source/customize/cfgutil.cxx |    5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

New commits:
commit bc5856c5c77a7ee18377cd274960950d8943178f
Author:     Rafael Lima <rafael.palma.l...@gmail.com>
AuthorDate: Fri Nov 25 20:13:51 2022 +0100
Commit:     Jim Raykowski <rayk...@gmail.com>
CommitDate: Sat Nov 26 20:51:30 2022 +0100

    Related tdf#145978 Fix workaround in kf5
    
    In commit 792e41314f321f54b3b2fc4d01c8b62a3b704e9e (about saving the last 
used macro) I used a workaround to make scroll_to_row work in kf5.
    
    However, this workaround based on hide() / show() calls was causing an 
error: qt.qpa.xcb: internal error:  void 
QXcbWindow::setNetWmStateOnUnmappedWindow() called on mapped window.
    
    As pointed out by Jim in the original patch, using resize_to_request has 
the same effect and does not cause the aforementioned error.
    
    Change-Id: Ie61e8529fccfdae88d56f223573eb0fd6a82b8b0
    Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143261
    Tested-by: Jenkins
    Reviewed-by: Jim Raykowski <rayk...@gmail.com>

diff --git a/cui/source/customize/cfgutil.cxx b/cui/source/customize/cfgutil.cxx
index 2b7a4ef0c226..621238da0cb8 100644
--- a/cui/source/customize/cfgutil.cxx
+++ b/cui/source/customize/cfgutil.cxx
@@ -1162,9 +1162,8 @@ SvxScriptSelectorDialog::SvxScriptSelectorDialog(
     m_aStylesInfo.init(aModuleName, xModel);
     m_xCategories->SetStylesInfo(&m_aStylesInfo);
 
-    // The hide/show commands below are a workaround to make scroll_to_row 
work as expected in kf5/x11
-    m_xDialog->hide();
-    m_xDialog->show();
+    // The following call is a workaround to make scroll_to_row work as 
expected in kf5/x11
+    m_xDialog->resize_to_request();
 
     LoadLastUsedMacro();
     UpdateUI();

Reply via email to