Stephan van den Akker wrote: > I believe I found the cause of fdo#49859 "FORMATTING, UI: numbering > alignment or > indentation is not applied in Impress" > Excellent, thanks so much - now finally pushed, to both master and -3-6 -
> I propose an addition to DeactivatePage():
>
> int SvxNumPositionTabPage::DeactivatePage(SfxItemSet *_pSet)
> {
> if(_pSet)
> {
> if(aDistBorderMF.IsEnabled())
> DistanceHdl_Impl(&aDistBorderMF);
> DistanceHdl_Impl(&aIndentMF);
> FillItemSet(*_pSet);
> }
> return sal_True;
> }
>
Yep, makes sense.
> Question:
>
> Ideally, I would wrap the DistanceHdl_Impl() calls in ..MF.HasFocus() checks
> to prevent unnecessary calls:
>
> if(aDistBorderMF.HasFocus() && aDistBorderMF.IsEnabled())
> DistanceHdl_Impl(&aDistBorderMF);
> if(aIndentMF.HasFocus())
> DistanceHdl_Impl(&aIndentMF);
> FillItemSet(*_pSet);
>
> But both aDistBorderMF.HasFocus() and aIndentMF.HasFocus() always seem to
> return
> false! Is this intentional, or a bug?
>
Looks like the same reason as for the actual bug - stuff gets
messaged in different orders here. I wouldn't bother too much.
Cheers,
-- Thorsten
pgplMmADoIQx3.pgp
Description: PGP signature
_______________________________________________ LibreOffice mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/libreoffice
