formula/source/core/api/token.cxx | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-)
New commits: commit dff039e61ac737c779b538d20a57a5e0a401cf60 Author: Caolán McNamara <[email protected]> AuthorDate: Wed Jun 22 16:05:53 2022 +0100 Commit: Xisco Fauli <[email protected]> CommitDate: Thu Jun 23 11:17:54 2022 +0200 crashtesting: assert seen with forum-mso-de-53682 not reproducible for me, but appears to be an empty string here sometimes. Change-Id: I8465f178cc7e5a6efdc08c1d15c154eeb2277c7b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136247 Tested-by: Jenkins Reviewed-by: Xisco Fauli <[email protected]> diff --git a/formula/source/core/api/token.cxx b/formula/source/core/api/token.cxx index 89ae03162778..a7d44f897a24 100644 --- a/formula/source/core/api/token.cxx +++ b/formula/source/core/api/token.cxx @@ -1249,8 +1249,12 @@ bool FormulaMissingContext::AddMissingExternal( FormulaTokenArray *pNewArr ) con const OUString &rName = mpFunc->GetExternal(); - // initial (fast) check: - sal_Unicode nLastChar = rName[ rName.getLength() - 1]; + // initial (fast) checks: + sal_Int32 nLength = rName.getLength(); + if (!nLength) + return false; + + sal_Unicode nLastChar = rName[ nLength - 1]; if ( nLastChar != 't' && nLastChar != 'm' ) return false;
