vcl/source/gdi/impglyphitem.cxx | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
New commits: commit cd1b93aafad2bd868025d363be9a913a2913ef39 Author: Luboš Luňák <[email protected]> AuthorDate: Wed Apr 13 15:42:26 2022 +0200 Commit: Luboš Luňák <[email protected]> CommitDate: Wed Apr 13 17:42:46 2022 +0200 empty SalLayoutGlyphsImpl is not automatically invalid Empty SalLayoutGlyphs is considered invalid, because otherwise it should have at least one *Impl, but an empty *Impl is apparently possible if it's a fallback but it doesn't find a single glyph. This avoid the warning in OutputDevice::ImplLayout(), triggered e.g. by CppunitTest_writerperfect_writer. Change-Id: I410d269b07ffb73f9860806ede9cd0b809668342 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132968 Tested-by: Jenkins Reviewed-by: Luboš Luňák <[email protected]> diff --git a/vcl/source/gdi/impglyphitem.cxx b/vcl/source/gdi/impglyphitem.cxx index b97096cd199c..bd1138c8d68a 100644 --- a/vcl/source/gdi/impglyphitem.cxx +++ b/vcl/source/gdi/impglyphitem.cxx @@ -25,6 +25,7 @@ #include <TextLayoutCache.hxx> #include <config_fuzzers.h> +// These need being explicit because of SalLayoutGlyphsImpl being private in vcl. SalLayoutGlyphs::SalLayoutGlyphs() {} SalLayoutGlyphs::~SalLayoutGlyphs() {} @@ -92,8 +93,6 @@ bool SalLayoutGlyphsImpl::IsValid() const { if (!m_rFontInstance.is()) return false; - if (empty()) - return false; return true; }
