lotuswordpro/source/filter/lwpsdwgrouploaderv0102.cxx | 11 +++-------- 1 file changed, 3 insertions(+), 8 deletions(-)
New commits: commit e9443070888628f7643741c1abcaaef28de6a53f Author: Caolán McNamara <[email protected]> AuthorDate: Wed Jan 19 20:43:58 2022 +0000 Commit: Caolán McNamara <[email protected]> CommitDate: Thu Jan 20 09:44:16 2022 +0100 ofz: Use-of-uninitialized-value Change-Id: Ia19985b7c042e6ab9608220343e3b678890f7215 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128638 Tested-by: Jenkins Reviewed-by: Caolán McNamara <[email protected]> diff --git a/lotuswordpro/source/filter/lwpsdwgrouploaderv0102.cxx b/lotuswordpro/source/filter/lwpsdwgrouploaderv0102.cxx index 35920fb2e7ec..47362c809892 100644 --- a/lotuswordpro/source/filter/lwpsdwgrouploaderv0102.cxx +++ b/lotuswordpro/source/filter/lwpsdwgrouploaderv0102.cxx @@ -238,20 +238,15 @@ XFDrawGroup* LwpSdwGroupLoaderV0102::CreateDrawGroupObject() { //flag unsigned char BinSignature[2]; - m_pStream->ReadBytes(BinSignature, 2); + if (m_pStream->ReadBytes(BinSignature, 2) != 2) + return nullptr; if (BinSignature[0] != 'S' || BinSignature[1] != 'M') - { - assert(false); return nullptr; - } //version - unsigned short nVersion; + unsigned short nVersion(0); m_pStream->ReadUInt16(nVersion); if (nVersion<0x0102) - { - assert(false); return nullptr; - } // topObj, botObj m_pStream->SeekRel(4); //record count
