cui/source/options/dbregister.cxx | 2 +- cui/source/options/dbregisterednamesconfig.cxx | 2 +- cui/source/options/dbregistersettings.cxx | 4 ++-- cui/source/options/dbregistersettings.hxx | 2 +- reportdesign/inc/PropertyForward.hxx | 2 +- reportdesign/source/core/sdr/PropertyForward.cxx | 4 ++-- reportdesign/source/core/sdr/RptObject.cxx | 2 +- reportdesign/source/ui/inspection/DataProviderHandler.cxx | 2 +- reportdesign/source/ui/report/ReportController.cxx | 2 +- 9 files changed, 11 insertions(+), 11 deletions(-)
New commits: commit c36f569242a116f88749f9c5e2cd449351a39ea4 Author: Noel Grandin <[email protected]> AuthorDate: Mon Oct 11 13:53:20 2021 +0200 Commit: Noel Grandin <[email protected]> CommitDate: Mon Oct 11 21:06:20 2021 +0200 loplugin:moveparam in cui Change-Id: I059fae3520b06bc733721fe130cf41da13803b9c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123383 Tested-by: Jenkins Reviewed-by: Noel Grandin <[email protected]> diff --git a/cui/source/options/dbregister.cxx b/cui/source/options/dbregister.cxx index 7bcf13435bbf..add9eda6e93c 100644 --- a/cui/source/options/dbregister.cxx +++ b/cui/source/options/dbregister.cxx @@ -140,7 +140,7 @@ bool DbRegistrationOptionsPage::FillItemSet( SfxItemSet* rCoreSet ) } if ( m_nOldCount != aRegistrations.size() || m_bModified ) { - rCoreSet->Put(DatabaseMapItem( SID_SB_DB_REGISTER, aRegistrations )); + rCoreSet->Put(DatabaseMapItem( SID_SB_DB_REGISTER, std::move(aRegistrations) )); bModified = true; } diff --git a/cui/source/options/dbregisterednamesconfig.cxx b/cui/source/options/dbregisterednamesconfig.cxx index 87681866e067..b33e9ded61c5 100644 --- a/cui/source/options/dbregisterednamesconfig.cxx +++ b/cui/source/options/dbregisterednamesconfig.cxx @@ -59,7 +59,7 @@ namespace svx DBG_UNHANDLED_EXCEPTION("cui.options"); } - _rFillItems.Put( DatabaseMapItem( SID_SB_DB_REGISTER, aSettings ) ); + _rFillItems.Put( DatabaseMapItem( SID_SB_DB_REGISTER, std::move(aSettings) ) ); } diff --git a/cui/source/options/dbregistersettings.cxx b/cui/source/options/dbregistersettings.cxx index f7739a1092cc..c544e1111fe3 100644 --- a/cui/source/options/dbregistersettings.cxx +++ b/cui/source/options/dbregistersettings.cxx @@ -25,9 +25,9 @@ namespace svx { - DatabaseMapItem::DatabaseMapItem( sal_uInt16 _nId, const DatabaseRegistrations& _rRegistrations ) + DatabaseMapItem::DatabaseMapItem( sal_uInt16 _nId, DatabaseRegistrations&& _rRegistrations ) :SfxPoolItem( _nId ) - ,m_aRegistrations( _rRegistrations ) + ,m_aRegistrations( std::move(_rRegistrations) ) { } diff --git a/cui/source/options/dbregistersettings.hxx b/cui/source/options/dbregistersettings.hxx index 9146afe7b1d3..2f86392bc9cf 100644 --- a/cui/source/options/dbregistersettings.hxx +++ b/cui/source/options/dbregistersettings.hxx @@ -64,7 +64,7 @@ namespace svx public: - DatabaseMapItem( sal_uInt16 _nId, const DatabaseRegistrations& _rRegistrations ); + DatabaseMapItem( sal_uInt16 _nId, DatabaseRegistrations&& _rRegistrations ); virtual bool operator==( const SfxPoolItem& ) const override; virtual DatabaseMapItem* Clone( SfxItemPool *pPool = nullptr ) const override; commit 01bb611effe7de983e4872a33fe849e4d0fc7874 Author: Noel Grandin <[email protected]> AuthorDate: Mon Oct 11 18:51:28 2021 +0200 Commit: Noel Grandin <[email protected]> CommitDate: Mon Oct 11 21:06:08 2021 +0200 loplugin:moveparam in reportdesign Change-Id: Ifefccc5d500331960baa8a48bb9ed64c86c91f9b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123424 Tested-by: Jenkins Reviewed-by: Noel Grandin <[email protected]> diff --git a/reportdesign/inc/PropertyForward.hxx b/reportdesign/inc/PropertyForward.hxx index 4f467c2a0fe0..8a9a058a0500 100644 --- a/reportdesign/inc/PropertyForward.hxx +++ b/reportdesign/inc/PropertyForward.hxx @@ -59,7 +59,7 @@ namespace rptui public: OPropertyMediator(const css::uno::Reference< css::beans::XPropertySet>& _xSource ,const css::uno::Reference< css::beans::XPropertySet>& _xDest - ,const TPropertyNamePair& _aNameMap + ,TPropertyNamePair&& _aNameMap ,bool _bReverse = false); // css::beans::XPropertyChangeListener diff --git a/reportdesign/source/core/sdr/PropertyForward.cxx b/reportdesign/source/core/sdr/PropertyForward.cxx index 0450e2d342ba..394edfc12f43 100644 --- a/reportdesign/source/core/sdr/PropertyForward.cxx +++ b/reportdesign/source/core/sdr/PropertyForward.cxx @@ -30,10 +30,10 @@ namespace rptui OPropertyMediator::OPropertyMediator(const Reference< XPropertySet>& _xSource ,const Reference< XPropertySet>& _xDest - ,const TPropertyNamePair& _aNameMap + ,TPropertyNamePair&& _aNameMap ,bool _bReverse) : OPropertyForward_Base(m_aMutex) - ,m_aNameMap(_aNameMap) + ,m_aNameMap(std::move(_aNameMap)) ,m_xSource(_xSource) ,m_xDest(_xDest) ,m_bInChange(false) diff --git a/reportdesign/source/core/sdr/RptObject.cxx b/reportdesign/source/core/sdr/RptObject.cxx index cdcb355e7729..75ba20f61479 100644 --- a/reportdesign/source/core/sdr/RptObject.cxx +++ b/reportdesign/source/core/sdr/RptObject.cxx @@ -875,7 +875,7 @@ void OUnoObject::CreateMediator(bool _bReverse) m_xMediator = new OPropertyMediator( m_xReportComponent, xControlModel, - getPropertyNameMap(GetObjIdentifier()), + TPropertyNamePair(getPropertyNameMap(GetObjIdentifier())), _bReverse); } } diff --git a/reportdesign/source/ui/inspection/DataProviderHandler.cxx b/reportdesign/source/ui/inspection/DataProviderHandler.cxx index f4c8abd97497..a6c1214704a7 100644 --- a/reportdesign/source/ui/inspection/DataProviderHandler.cxx +++ b/reportdesign/source/ui/inspection/DataProviderHandler.cxx @@ -132,7 +132,7 @@ void SAL_CALL DataProviderHandler::inspect(const uno::Reference< uno::XInterface aPropertyMediation.emplace( PROPERTY_MASTERFIELDS, TPropertyConverter(PROPERTY_MASTERFIELDS,aNoConverter) ); aPropertyMediation.emplace( PROPERTY_DETAILFIELDS, TPropertyConverter(PROPERTY_DETAILFIELDS,aNoConverter) ); - m_xMasterDetails = new OPropertyMediator( m_xDataProvider, m_xReportComponent, aPropertyMediation,true ); + m_xMasterDetails = new OPropertyMediator( m_xDataProvider, m_xReportComponent, std::move(aPropertyMediation), true ); } } catch(const uno::Exception &) diff --git a/reportdesign/source/ui/report/ReportController.cxx b/reportdesign/source/ui/report/ReportController.cxx index 0adc915ea055..886e3390adf6 100644 --- a/reportdesign/source/ui/report/ReportController.cxx +++ b/reportdesign/source/ui/report/ReportController.cxx @@ -2976,7 +2976,7 @@ uno::Reference< sdbc::XRowSet > const & OReportController::getRowSet() aPropertyMediation.emplace( PROPERTY_ESCAPEPROCESSING, TPropertyConverter(PROPERTY_ESCAPEPROCESSING,aNoConverter) ); aPropertyMediation.emplace( PROPERTY_FILTER, TPropertyConverter(PROPERTY_FILTER,aNoConverter) ); - m_xRowSetMediator = new OPropertyMediator( m_xReportDefinition, xRowSetProp, aPropertyMediation ); + m_xRowSetMediator = new OPropertyMediator( m_xReportDefinition, xRowSetProp, std::move(aPropertyMediation) ); m_xRowSet = xRowSet; } catch(const uno::Exception&)
