jvmfwk/inc/vendorbase.hxx | 2 +- jvmfwk/plugins/sunmajor/pluginlib/gnujre.cxx | 2 +- jvmfwk/plugins/sunmajor/pluginlib/gnujre.hxx | 2 +- jvmfwk/plugins/sunmajor/pluginlib/vendorbase.cxx | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-)
New commits: commit 47331ae6f95070ff7460e541895895b59eb15103 Author: Noel Grandin <[email protected]> AuthorDate: Mon Oct 11 16:08:46 2021 +0200 Commit: Noel Grandin <[email protected]> CommitDate: Mon Oct 11 18:37:07 2021 +0200 loplugin:moveparam in jvmfwk Change-Id: I78970269bfd3eb7ad6b069ac99eeee707619d3e4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123416 Tested-by: Jenkins Reviewed-by: Noel Grandin <[email protected]> diff --git a/jvmfwk/inc/vendorbase.hxx b/jvmfwk/inc/vendorbase.hxx index 47e407a1b4a2..4a0190eb0bb8 100644 --- a/jvmfwk/inc/vendorbase.hxx +++ b/jvmfwk/inc/vendorbase.hxx @@ -154,7 +154,7 @@ protected: false - the object could not completely initialize. In this case it will be discarded by the caller. */ - virtual bool initialize(std::vector<std::pair<OUString, OUString>> props); + virtual bool initialize(const std::vector<std::pair<OUString, OUString>>& props); /* returns relative file URLs to the runtime library. For example "/bin/client/jvm.dll" diff --git a/jvmfwk/plugins/sunmajor/pluginlib/gnujre.cxx b/jvmfwk/plugins/sunmajor/pluginlib/gnujre.cxx index 99e07bda8c41..1003e6eec411 100644 --- a/jvmfwk/plugins/sunmajor/pluginlib/gnujre.cxx +++ b/jvmfwk/plugins/sunmajor/pluginlib/gnujre.cxx @@ -89,7 +89,7 @@ char const* const* GnuInfo::getLibraryPaths(int* /*size*/) return nullptr; } -bool GnuInfo::initialize(std::vector<std::pair<OUString, OUString> > props) +bool GnuInfo::initialize(const std::vector<std::pair<OUString, OUString> >& props) { //get java.vendor, java.version, java.home //from system properties diff --git a/jvmfwk/plugins/sunmajor/pluginlib/gnujre.hxx b/jvmfwk/plugins/sunmajor/pluginlib/gnujre.hxx index dd3e15cb99c0..5d2f78d1fd17 100644 --- a/jvmfwk/plugins/sunmajor/pluginlib/gnujre.hxx +++ b/jvmfwk/plugins/sunmajor/pluginlib/gnujre.hxx @@ -38,7 +38,7 @@ public: virtual char const* const* getLibraryPaths(int* size) override; - virtual bool initialize(std::vector<std::pair<OUString, OUString>> props) override; + virtual bool initialize(const std::vector<std::pair<OUString, OUString>>& props) override; virtual int compareVersions(const OUString& sSecond) const override; }; } diff --git a/jvmfwk/plugins/sunmajor/pluginlib/vendorbase.cxx b/jvmfwk/plugins/sunmajor/pluginlib/vendorbase.cxx index e9c26778a461..8863df3352ff 100644 --- a/jvmfwk/plugins/sunmajor/pluginlib/vendorbase.cxx +++ b/jvmfwk/plugins/sunmajor/pluginlib/vendorbase.cxx @@ -35,7 +35,7 @@ VendorBase::VendorBase() { } -bool VendorBase::initialize(std::vector<std::pair<OUString, OUString> > props) +bool VendorBase::initialize(const std::vector<std::pair<OUString, OUString> >& props) { //get java.vendor, java.version, java.home //from system properties
