Hi Daniel, On Wed, May 9, 2012 at 7:36 PM, Daniel Bankston <[email protected]> wrote: > Hi, Kohei and Markus, > > I understand that when dealing with the master branch, a contributing > developer is supposed to send a patch to the mailing list with the subject > prefixed with [PATCH]. What process should I follow when pushing to the > feature/gsoc-calc-perf branch? Should I notify you in some fashion or > simply push at my discretion? Is it ok to push several small commits, > should I try to push only a few large commits, or push commits at my > discretion?
You can push commits at your discretion as long as you are pushing them to your own feature branch. You can also choose to post a patch to the mailing list if you are not sure, but that's not required. As far as whether to make small commits or large ones, that's also up to you. We normally recommend you make smaller commits as opposed to larger ones, but sometimes you need to make a large change so it also depends on the kind of change you are making. A good rule of thumb is to make each commit have a distinct purpose, and that make each commit buildable. But that's just a guideline and certainly subject to exceptions. Hope that clarifies things a bit. Kohei _______________________________________________ LibreOffice mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/libreoffice
