sc/source/core/data/dptabsrc.cxx |    6 ++++++
 1 file changed, 6 insertions(+)

New commits:
commit 5661e36bda03ccb580a653352cdc84335fd6410c
Author:     Julien Nabet <[email protected]>
AuthorDate: Sat Aug 22 08:54:02 2020 +0200
Commit:     Eike Rathke <[email protected]>
CommitDate: Sat Aug 22 16:22:14 2020 +0200

    Explain on purpose typos in sc/dptabsrc.cxx
    
    Change-Id: I90403dab934013259e724f7017bb2c85dd01b16a
    Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101181
    Reviewed-by: Noel Grandin <[email protected]>
    Reviewed-by: Eike Rathke <[email protected]>
    Tested-by: Jenkins

diff --git a/sc/source/core/data/dptabsrc.cxx b/sc/source/core/data/dptabsrc.cxx
index 2ed6f458a675..0d6f91179437 100644
--- a/sc/source/core/data/dptabsrc.cxx
+++ b/sc/source/core/data/dptabsrc.cxx
@@ -68,10 +68,16 @@ using ::com::sun::star::sheet::DataPilotFieldAutoShowInfo;
 SC_SIMPLE_SERVICE_INFO( ScDPSource,      "ScDPSource",      
"com.sun.star.sheet.DataPilotSource" )
 SC_SIMPLE_SERVICE_INFO( ScDPDimensions,  "ScDPDimensions",  
"com.sun.star.sheet.DataPilotSourceDimensions" )
 SC_SIMPLE_SERVICE_INFO( ScDPDimension,   "ScDPDimension",   
"com.sun.star.sheet.DataPilotSourceDimension" )
+
+// Typos are on purpose here, quote from Eike Rathke (see 
https://gerrit.libreoffice.org/c/core/+/101116):
+// "The typo is exactly why the SC_SIMPLE_SERVICE_INFO_COMPAT() lists both 
service names,
+// the old with the typo and the new corrected one. Correcting the typo in the 
old name
+// will make all extensions fail that use it. This is not to be changed."
 SC_SIMPLE_SERVICE_INFO_COMPAT( ScDPHierarchies, "ScDPHierarchies",
         "com.sun.star.sheet.DataPilotSourceHierarchies", 
"com.sun.star.sheet.DataPilotSourceHierarcies" )
 SC_SIMPLE_SERVICE_INFO_COMPAT( ScDPHierarchy,   "ScDPHierarchy",
         "com.sun.star.sheet.DataPilotSourceHierarchy", 
"com.sun.star.sheet.DataPilotSourceHierarcy" )
+
 SC_SIMPLE_SERVICE_INFO( ScDPLevels,      "ScDPLevels",      
"com.sun.star.sheet.DataPilotSourceLevels" )
 SC_SIMPLE_SERVICE_INFO( ScDPLevel,       "ScDPLevel",       
"com.sun.star.sheet.DataPilotSourceLevel" )
 SC_SIMPLE_SERVICE_INFO( ScDPMembers,     "ScDPMembers",     
"com.sun.star.sheet.DataPilotSourceMembers" )
_______________________________________________
Libreoffice-commits mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

Reply via email to