vcl/source/app/scheduler.cxx | 6 ++++++ 1 file changed, 6 insertions(+)
New commits: commit 29ad99649866ffed13ea0936e9daf51463a04d92 Author: Noel Grandin <[email protected]> AuthorDate: Sat Aug 1 13:18:18 2020 +0200 Commit: Noel Grandin <[email protected]> CommitDate: Wed Aug 5 08:26:17 2020 +0200 document the abort in ProcessTaskScheduling Change-Id: I8a30e9abbf437cdf4f91a14755e5cc639dd172b5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99937 Tested-by: Jenkins Reviewed-by: Noel Grandin <[email protected]> diff --git a/vcl/source/app/scheduler.cxx b/vcl/source/app/scheduler.cxx index aa716f88b763..fa18087e9fd8 100644 --- a/vcl/source/app/scheduler.cxx +++ b/vcl/source/app/scheduler.cxx @@ -473,6 +473,12 @@ bool Scheduler::ProcessTaskScheduling() // invoke the task sal_uInt32 nLockCount = Unlock( true ); + /* + * Current policy is that scheduler tasks aren't allowed to throw an exception. + * Because otherwise the exception is caught somewhere totally unrelated. + * TODO Ideally we could capture a proper backtrace and feed this into breakpad, + * which is do-able, but requires writing some assembly. + */ try { pTask->Invoke(); _______________________________________________ Libreoffice-commits mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
