net/FakeSocket.cpp | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
New commits: commit ba14da5982f25c8a3a7cb651787c328ecd659d34 Author: Tor Lillqvist <[email protected]> AuthorDate: Tue Jul 7 12:15:37 2020 +0300 Commit: Tor Lillqvist <[email protected]> CommitDate: Tue Jul 7 15:38:40 2020 +0200 Expand on comment Change-Id: I4523e25ff91ff9a51bb13c585bec6ef0547b7e2f Reviewed-on: https://gerrit.libreoffice.org/c/online/+/98260 Tested-by: Jenkins Reviewed-by: Tor Lillqvist <[email protected]> diff --git a/net/FakeSocket.cpp b/net/FakeSocket.cpp index a4ef761e5..51346eb7e 100644 --- a/net/FakeSocket.cpp +++ b/net/FakeSocket.cpp @@ -125,7 +125,9 @@ static int fakeSocketAllocate() // We always allocate a new FakeSocketPair struct. Let's not bother with potential issues with // reusing them. It isn't like we would be allocating thousands anyway during the typical - // lifetime of an app. + // lifetime of an app. Also, not reusing FakeSocket fd numbers means that it is easier to set a + // conditional breakpoint on an operation on a specific fd when debugging some problematic + // scenario. const int i = fds.size(); fds.resize(i + 1); _______________________________________________ Libreoffice-commits mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
