gerrit/auto-submit/gerrit-autosubmit | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
New commits: commit 7cd868c5f48f7138eb2d6f9e16ca1db74e0db492 Author: Guilhem Moulin <[email protected]> AuthorDate: Tue Feb 18 03:37:18 2020 +0100 Commit: Miklos Vajna <[email protected]> CommitDate: Thu Feb 20 08:46:02 2020 +0100 gerrit-autosubmit: redirect background SSH's stdin from /dev/null Without that there is a risk of stdin pollution between the two commands. Moreover on multiplexed connection the background command might be lingering around once the script terminates, and without redirection it starts grabs the parent shell's stdin. That flag predates the initial revision in OpenSSH's code repository in 1999, so should be safe to use on all systems :-) Change-Id: I820338385808938396b02470130632cc3df1b473 Reviewed-on: https://gerrit.libreoffice.org/c/dev-tools/+/88914 Tested-by: Miklos Vajna <[email protected]> Reviewed-by: Miklos Vajna <[email protected]> diff --git a/gerrit/auto-submit/gerrit-autosubmit b/gerrit/auto-submit/gerrit-autosubmit index ca231e5..fec0bd2 100755 --- a/gerrit/auto-submit/gerrit-autosubmit +++ b/gerrit/auto-submit/gerrit-autosubmit @@ -27,7 +27,7 @@ if port != None and port != "": sshcommand.extend(["-p", port]) while True: - cmd = sshcommand + ["-o", "ServerAliveInterval=5", server, "gerrit", "stream-events"] + cmd = sshcommand + ["-n", "-o", "ServerAliveInterval=5", server, "gerrit", "stream-events"] sock = subprocess.Popen(cmd, stdout=subprocess.PIPE, bufsize=1) try: _______________________________________________ Libreoffice-commits mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
