sfx2/source/view/viewsh.cxx | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-)
New commits: commit a2f4bdb191d8d11824a0292880377dd4a20ac145 Author: Ashod Nakashian <[email protected]> AuthorDate: Sun Oct 21 12:56:52 2018 -0400 Commit: Jan Holesovsky <[email protected]> CommitDate: Thu Jun 6 14:34:16 2019 +0200 sfx2: warn when invoking LOK callback before setup Change-Id: I2c845c357f73dbce71b1e420979aecf2cff38827 Reviewed-on: https://gerrit.libreoffice.org/68255 Reviewed-by: Andras Timar <[email protected]> Tested-by: Andras Timar <[email protected]> Reviewed-on: https://gerrit.libreoffice.org/73482 Tested-by: Jenkins Reviewed-by: Jan Holesovsky <[email protected]> diff --git a/sfx2/source/view/viewsh.cxx b/sfx2/source/view/viewsh.cxx index eeafd198cb5e..3727f254a7fe 100644 --- a/sfx2/source/view/viewsh.cxx +++ b/sfx2/source/view/viewsh.cxx @@ -1472,7 +1472,7 @@ void SfxViewShell::registerLibreOfficeKitViewCallback(LibreOfficeKitCallback pCa void SfxViewShell::libreOfficeKitViewCallback(int nType, const char* pPayload) const { - if (comphelper::LibreOfficeKit::isTiledPainting()) + if (!comphelper::LibreOfficeKit::isActive() || comphelper::LibreOfficeKit::isTiledPainting()) return; if (pImpl->m_bTiledSearching) @@ -1491,6 +1491,11 @@ void SfxViewShell::libreOfficeKitViewCallback(int nType, const char* pPayload) c if (pImpl->m_pLibreOfficeKitViewCallback) pImpl->m_pLibreOfficeKitViewCallback(nType, pPayload, pImpl->m_pLibreOfficeKitViewData); + else + SAL_WARN( + "sfx.view", + "SfxViewShell::libreOfficeKitViewCallback no callback set! Dropped payload of type " + << nType << ": [" << pPayload << ']'); } void SfxViewShell::afterCallbackRegistered() _______________________________________________ Libreoffice-commits mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
