On Tue, Feb 14, 2012 at 01:43:11PM +0000, Caolán McNamara wrote: > On Tue, 2012-02-14 at 06:06 +0100, Lionel Elie Mamane wrote:
>> Thanks, but this one should actually be used in >> ODatabaseMetaData::getTableTypes. It is probably a bug that it is not, >> I'll convert getTableTypes to using it > How about the other one ? Ah yes, I had missed that there was a second part. Let's see... On Mon, Feb 13, 2012 at 10:06:17PM +0000, Kate Goss wrote: > Subject: [PATCH 2/2] Remove unused code from > connectivity::odbc::OPreparedStatement > --- a/connectivity/source/drivers/odbcbase/OPreparedStatement.cxx > +++ b/connectivity/source/drivers/odbcbase/OPreparedStatement.cxx > -sal_Int8* OPreparedStatement::getDataBuf (sal_Int32 index) Not particularly attached to it. > -sal_Int32 OPreparedStatement::getParamLength ( sal_Int32 index) That's a near-duplicate of getLengthBuf, and is buggy anyway: it copies the bottom 32 bits of a 64 bit integer into a 32 bit integer. Depending on the endianess, that's either (value % 2^32) or (value / 2^32). Remove! > -sal_Int32 OPreparedStatement::getPrecision ( sal_Int32 sqlType) Not particularly attached to it. OK, I'm pushing the second patch to master. -- Lionel _______________________________________________ LibreOffice mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/libreoffice
