vcl/inc/listbox.hxx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
New commits: commit 698942ac73b8502eb1957b70dd165023e8d54c82 Author: Luboš Luňák <[email protected]> AuthorDate: Thu Nov 8 13:48:42 2018 +0100 Commit: Luboš Luňák <[email protected]> CommitDate: Wed Nov 14 16:05:17 2018 +0100 avoid valgrind uninitialized jump warning with clang I'm not sure what exactly the actual problem is, but valgrind reports unitialized reads of mbMulti, although that one is fine and the culprint is in fact mbCenter. Which happens to be bit 16 of the bitfield, and the generated assembly looks fishy, just for that one specific bit. Adding extra padding, extra statements or even just reordering avoids it. So this is lame, but just reorder it and be done with it, this should be otherwise harmless and I've spent enough time on this. Change-Id: I25be55ebe0e9b6dc981793aa7caeae2a40bb27a5 Reviewed-on: https://gerrit.libreoffice.org/63186 Tested-by: Jenkins Reviewed-by: Luboš Luňák <[email protected]> diff --git a/vcl/inc/listbox.hxx b/vcl/inc/listbox.hxx index c448c923ed9f..8591d9696764 100644 --- a/vcl/inc/listbox.hxx +++ b/vcl/inc/listbox.hxx @@ -215,8 +215,8 @@ private: bool mbInUserDraw : 1; ///< In UserDraw bool mbReadOnly : 1; ///< ReadOnly bool mbMirroring : 1; ///< pb: #106948# explicit mirroring for calc - bool mbRight : 1; ///< right align Text output bool mbCenter : 1; ///< center Text output + bool mbRight : 1; ///< right align Text output bool mbEdgeBlending : 1; Link<ImplListBoxWindow*,void> maScrollHdl; _______________________________________________ Libreoffice-commits mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
