tools/Config.cpp | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
New commits: commit 3304e909359040607f0a08a51dce852e4e6f7009 Author: Jan Holesovsky <[email protected]> Date: Wed Mar 28 09:26:56 2018 +0200 The return value of system() shouldn't be ignored. Change-Id: I7422bfb3997c205333a8558884c65f2ff3795e38 diff --git a/tools/Config.cpp b/tools/Config.cpp index 0f4914180..aaa06e2c6 100644 --- a/tools/Config.cpp +++ b/tools/Config.cpp @@ -197,6 +197,7 @@ int Config::main(const std::vector<std::string>& args) return Application::EXIT_NOINPUT; } + int retval = Application::EXIT_OK; bool changed = false; _loolConfig.load(ConfigFile); @@ -328,7 +329,7 @@ int Config::main(const std::vector<std::string>& args) const char command[] = "su lool --shell=/bin/sh -c 'loolwsd-systemplate-setup /opt/lool/systemplate " LO_PATH " >/dev/null 2>&1'"; std::cout << "Running the following command:" << std::endl << command << std::endl; - system(command); + retval = system(command); } else { @@ -343,8 +344,7 @@ int Config::main(const std::vector<std::string>& args) std::cout << "Saved" << std::endl; } - // This tool only handles options, nothing to do here - return Application::EXIT_OK; + return retval; } POCO_APP_MAIN(Config); _______________________________________________ Libreoffice-commits mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
