On 10/01/12 21:45, Matúš Kukan wrote: > On 10 January 2012 16:14, Michael Stahl <[email protected]> wrote: >> well the .def file is only for Windows, we don't have anything in gbuild >> to convert between a bunch of different map file formats like the old >> build system could because we're trying for "less insane"... >> >> so something like #ifdef UNX SAL_DLLPUBLIC_EXPORT would be needed... >> >> on the other hand the npapi.h header is checked into git, does not come >> from a tarball, and has already been modified; i wonder if editing that >> to add dll-exports is the easiest way to fix this? > > I think we should add DLLPUBLIC_EXPORT macros .. > And we don't have to modify npapi.h directly but create different > npapi.h to be included some ugly way as in: > i18npool/source/breakiterator/Makefile:37 > > Because there is also possibility to use SYSTEM_MOZILLA_HEADERS. > I don't know if anybody use that but if yes, we would need somehow get > path to the npapi.h file. > I guess that could be doable.
argh, there is a SYSTEM_MOZILLA_HEADERS? completely forgot about that, but i guess in that case changing the header isn't such a good idea after all :( hmm... i guess in that case the least ugly way is to resurrect the .def file for Windows, and add #ifdef UNX SAL_DLLPUBLIC_EXPORT for the other platforms. _______________________________________________ LibreOffice mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/libreoffice
