compilerplugins/clang/test/passstuffbyref.cxx | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)
New commits: commit cc033ec70ad91180c9d5c8ee081be933973f1f07 Author: Stephan Bergmann <[email protected]> Date: Tue Jan 9 18:20:50 2018 +0100 Don't use non-Windows sys/time.h (The comment what the test wants to check quotes noelgrandin on #libreoffice- dev.) Change-Id: I8e8980902c8113eb75d24064e68a47e70bc483d6 Reviewed-on: https://gerrit.libreoffice.org/47676 Tested-by: Jenkins <[email protected]> Reviewed-by: Stephan Bergmann <[email protected]> diff --git a/compilerplugins/clang/test/passstuffbyref.cxx b/compilerplugins/clang/test/passstuffbyref.cxx index f6277b4bbf07..3f0efb1d106e 100644 --- a/compilerplugins/clang/test/passstuffbyref.cxx +++ b/compilerplugins/clang/test/passstuffbyref.cxx @@ -8,7 +8,6 @@ */ #include <rtl/ustring.hxx> -#include <sys/time.h> #include <o3tl/cow_wrapper.hxx> #include <vector> @@ -57,10 +56,11 @@ struct S2 { // no warning expected -timeval &operator -= ( timeval &t1, const timeval &t2 ); -timeval operator-( const timeval &t1, const timeval &t2 ) +// Don't flag stuff where the local var is hidden behind a self-returning operation like -=: +S2 &operator -= ( S2 &t1, const S2 &t2 ); +S2 operator-( const S2 &t1, const S2 &t2 ) { - timeval t0 = t1; + S2 t0 = t1; return t0 -= t2; } _______________________________________________ Libreoffice-commits mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
