Hello,
On cppcheck report, there were 2 "Same expression on both sides of '&&'" on
b2dpolypolygoncutter.cxx
I don't know how this part works so I recognize it's just guessing.
diff --git a/basegfx/source/polygon/b2dpolypolygoncutter.cxx
b/basegfx/source/polygon/b2dpolypolygoncutter.cxx
index d32ee87..8745241 100644
--- a/basegfx/source/polygon/b2dpolypolygoncutter.cxx
+++ b/basegfx/source/polygon/b2dpolypolygoncutter.cxx
@@ -282,7 +282,7 @@ namespace basegfx
bOnEdge = false;
}
}
- while(bOnEdge && pPNa2 != &rPNa && pPNa2 != &rPNa);
+ while(bOnEdge && pPNa2 != &rPNa && pPNb2 != &rPNb);
if(bOnEdge)
{
@@ -408,7 +408,7 @@ namespace basegfx
bOnEdge = false;
}
}
- while(bOnEdge && pPNa2 != &rPNa && pPNa2 != &rPNa);
+ while(bOnEdge && pPNa2 != &rPNa && pPNb2 != &rPNb);
if(bOnEdge)
{
Does it seem ok ? (If yes, I can commit and push it on master branch)
Julien
--
View this message in context:
http://nabble.documentfoundation.org/REVIEW-Patch-for-Same-expression-on-both-sides-of-in-basegfx-module-tp3617335p3617335.html
Sent from the Dev mailing list archive at Nabble.com.
_______________________________________________
LibreOffice mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/libreoffice
