solenv/bin/bin_library_info.sh | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)
New commits: commit 68d7364dfbed50a802e61bf94493510405367b31 Author: Yeliz TaneroÄlu <[email protected]> Date: Fri May 19 17:46:21 2017 +0300 tdf#105204 fix shellcheck warning in solenv/bin/bin_library_info.sh Change-Id: I1c212966f9dc9157fd23ef6c71924d4d96af7e9f SC2086: Double quote to prevent globbing and word splitting. Reviewed-on: https://gerrit.libreoffice.org/37831 Reviewed-by: Chris Sherlock <[email protected]> Tested-by: Chris Sherlock <[email protected]> diff --git a/solenv/bin/bin_library_info.sh b/solenv/bin/bin_library_info.sh index 94bc262c0bc3..65c40ee23254 100755 --- a/solenv/bin/bin_library_info.sh +++ b/solenv/bin/bin_library_info.sh @@ -26,15 +26,15 @@ exit 0; die() { - [ $V ] && echo "Error:" "$@" + [ "$V" ] && echo "Error:" "$@" exit -1; } get_config_sha() { - pushd ${SRCDIR?} > /dev/null - git hash-object ${BUILDDIR?}/config_host.mk + pushd "${SRCDIR?}" > /dev/null + git hash-object "${BUILDDIR?}"/config_host.mk popd > /dev/null } @@ -42,7 +42,7 @@ get_library_gbuild_sha() { local module="$1" - pushd ${SRCDIR?} > /dev/null + pushd "${SRCDIR?}" > /dev/null if [ -d "${SRCDIR}/external/${module?}" ] ; then git ls-tree -d HEAD "external/${module?}" | cut -f 1 | cut -d " " -f 3 else
_______________________________________________ Libreoffice-commits mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
