Hi,
Please find the latest report on new defect(s) introduced to LibreOffice found
with Coverity Scan.
8 new defect(s) introduced to LibreOffice found with Coverity Scan.
3 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent
build analyzed by Coverity Scan.
New defect(s) Reported-by: Coverity Scan
Showing 8 of 8 defect(s)
** CID 1405477: Uninitialized members (UNINIT_CTOR)
/cui/source/tabpages/tpgradnt.cxx: 135 in
SvxGradientTabPage::SvxGradientTabPage(vcl::Window *, const SfxItemSet &)()
________________________________________________________________________________________________________
*** CID 1405477: Uninitialized members (UNINIT_CTOR)
/cui/source/tabpages/tpgradnt.cxx: 135 in
SvxGradientTabPage::SvxGradientTabPage(vcl::Window *, const SfxItemSet &)()
129 m_pLbColorTo->SetSelectHdl( aLink3 );
130
131 // #i76307# always paint the preview in LTR, because this is what
the document does
132 m_pCtlPreview->EnableRTL( false );
133
134 setPreviewsToSamePlace(pParent, this);
>>> CID 1405477: Uninitialized members (UNINIT_CTOR)
>>> Non-static class member "m_pPos" is not initialized in this constructor
>>> nor in any functions that it calls.
135 }
136
137 SvxGradientTabPage::~SvxGradientTabPage()
138 {
139 disposeOnce();
140 }
** CID 1405476: Uninitialized members (UNINIT_CTOR)
/cui/source/tabpages/tphatch.cxx: 130 in
SvxHatchTabPage::SvxHatchTabPage(vcl::Window *, const SfxItemSet &)()
________________________________________________________________________________________________________
*** CID 1405476: Uninitialized members (UNINIT_CTOR)
/cui/source/tabpages/tphatch.cxx: 130 in
SvxHatchTabPage::SvxHatchTabPage(vcl::Window *, const SfxItemSet &)()
124
125 m_pBtnAdd->SetClickHdl( LINK( this, SvxHatchTabPage,
ClickAddHdl_Impl ) );
126 m_pBtnModify->SetClickHdl( LINK( this, SvxHatchTabPage,
ClickModifyHdl_Impl ) );
127
128 m_pCtlPreview->SetDrawMode(
GetSettings().GetStyleSettings().GetHighContrastMode() ?
OUTPUT_DRAWMODE_CONTRAST : OUTPUT_DRAWMODE_COLOR );
129
>>> CID 1405476: Uninitialized members (UNINIT_CTOR)
>>> Non-static class member "m_pPos" is not initialized in this constructor
>>> nor in any functions that it calls.
130 }
131
132 SvxHatchTabPage::~SvxHatchTabPage()
133 {
134 disposeOnce();
135 }
** CID 1405475: Uninitialized members (UNINIT_CTOR)
/chart2/qa/extras/PivotChartTest.cxx: 139 in <unnamed>::Value::Value(const
rtl::OUString &)()
________________________________________________________________________________________________________
*** CID 1405475: Uninitialized members (UNINIT_CTOR)
/chart2/qa/extras/PivotChartTest.cxx: 139 in <unnamed>::Value::Value(const
rtl::OUString &)()
133 double mfValue;
134 bool mbIsValue;
135
136 Value(OUString const & rString)
137 : maString(rString)
138 , mbIsValue(false)
>>> CID 1405475: Uninitialized members (UNINIT_CTOR)
>>> Non-static class member "mfValue" is not initialized in this
>>> constructor nor in any functions that it calls.
139 {}
140
141 Value(double fValue)
142 : mfValue(fValue)
143 , mbIsValue(true)
144 {}
** CID 1405474: Integer handling issues (SIGN_EXTENSION)
/sw/inc/htmltbl.hxx: 429 in SwHTMLTableLayout::GetCell(unsigned short, unsigned
short) const()
________________________________________________________________________________________________________
*** CID 1405474: Integer handling issues (SIGN_EXTENSION)
/sw/inc/htmltbl.hxx: 429 in SwHTMLTableLayout::GetCell(unsigned short, unsigned
short) const()
423 {
424 m_aColumns[nCol] = std::move(pCol);
425 }
426
427 inline SwHTMLTableLayoutCell *SwHTMLTableLayout::GetCell( sal_uInt16
nRow, sal_uInt16 nCol ) const
428 {
>>> CID 1405474: Integer handling issues (SIGN_EXTENSION)
>>> Suspicious implicit sign extension: "this->m_nCols" with type
>>> "sal_uInt16" (16 bits, unsigned) is promoted in "nRow * this->m_nCols +
>>> nCol" to type "int" (32 bits, signed), then sign-extended to type "unsigned
>>> long" (64 bits, unsigned). If "nRow * this->m_nCols + nCol" is greater
>>> than 0x7FFFFFFF, the upper bits of the result will all be 1.
429 return m_aCells[nRow*m_nCols+nCol].get();
430 }
431
432 inline void SwHTMLTableLayout::SetCell(
std::unique_ptr<SwHTMLTableLayoutCell> pCell,
433 sal_uInt16 nRow, sal_uInt16 nCol )
434 {
** CID 1405473: Integer handling issues (SIGN_EXTENSION)
/sw/inc/htmltbl.hxx: 429 in SwHTMLTableLayout::GetCell(unsigned short, unsigned
short) const()
________________________________________________________________________________________________________
*** CID 1405473: Integer handling issues (SIGN_EXTENSION)
/sw/inc/htmltbl.hxx: 429 in SwHTMLTableLayout::GetCell(unsigned short, unsigned
short) const()
423 {
424 m_aColumns[nCol] = std::move(pCol);
425 }
426
427 inline SwHTMLTableLayoutCell *SwHTMLTableLayout::GetCell( sal_uInt16
nRow, sal_uInt16 nCol ) const
428 {
>>> CID 1405473: Integer handling issues (SIGN_EXTENSION)
>>> Suspicious implicit sign extension: "nRow" with type "sal_uInt16" (16
>>> bits, unsigned) is promoted in "nRow * this->m_nCols + nCol" to type "int"
>>> (32 bits, signed), then sign-extended to type "unsigned long" (64 bits,
>>> unsigned). If "nRow * this->m_nCols + nCol" is greater than 0x7FFFFFFF,
>>> the upper bits of the result will all be 1.
429 return m_aCells[nRow*m_nCols+nCol].get();
430 }
431
432 inline void SwHTMLTableLayout::SetCell(
std::unique_ptr<SwHTMLTableLayoutCell> pCell,
433 sal_uInt16 nRow, sal_uInt16 nCol )
434 {
** CID 1405472: Integer handling issues (SIGN_EXTENSION)
/sw/inc/htmltbl.hxx: 435 in
SwHTMLTableLayout::SetCell(std::unique_ptr<SwHTMLTableLayoutCell,
std::default_delete<SwHTMLTableLayoutCell>>, unsigned short, unsigned short)()
________________________________________________________________________________________________________
*** CID 1405472: Integer handling issues (SIGN_EXTENSION)
/sw/inc/htmltbl.hxx: 435 in
SwHTMLTableLayout::SetCell(std::unique_ptr<SwHTMLTableLayoutCell,
std::default_delete<SwHTMLTableLayoutCell>>, unsigned short, unsigned short)()
429 return m_aCells[nRow*m_nCols+nCol].get();
430 }
431
432 inline void SwHTMLTableLayout::SetCell(
std::unique_ptr<SwHTMLTableLayoutCell> pCell,
433 sal_uInt16 nRow, sal_uInt16 nCol )
434 {
>>> CID 1405472: Integer handling issues (SIGN_EXTENSION)
>>> Suspicious implicit sign extension: "this->m_nCols" with type
>>> "sal_uInt16" (16 bits, unsigned) is promoted in "nRow * this->m_nCols +
>>> nCol" to type "int" (32 bits, signed), then sign-extended to type "unsigned
>>> long" (64 bits, unsigned). If "nRow * this->m_nCols + nCol" is greater
>>> than 0x7FFFFFFF, the upper bits of the result will all be 1.
435 m_aCells[nRow*m_nCols+nCol] = std::move(pCell);
436 }
437
438 inline long SwHTMLTableLayout::GetBrowseWidthMin() const
439 {
440 return (long)( (!m_nWidthOption || m_bPrcWidthOption) ? m_nMin :
m_nRelTabWidth );
** CID 1405471: Integer handling issues (SIGN_EXTENSION)
/sw/inc/htmltbl.hxx: 435 in
SwHTMLTableLayout::SetCell(std::unique_ptr<SwHTMLTableLayoutCell,
std::default_delete<SwHTMLTableLayoutCell>>, unsigned short, unsigned short)()
________________________________________________________________________________________________________
*** CID 1405471: Integer handling issues (SIGN_EXTENSION)
/sw/inc/htmltbl.hxx: 435 in
SwHTMLTableLayout::SetCell(std::unique_ptr<SwHTMLTableLayoutCell,
std::default_delete<SwHTMLTableLayoutCell>>, unsigned short, unsigned short)()
429 return m_aCells[nRow*m_nCols+nCol].get();
430 }
431
432 inline void SwHTMLTableLayout::SetCell(
std::unique_ptr<SwHTMLTableLayoutCell> pCell,
433 sal_uInt16 nRow, sal_uInt16 nCol )
434 {
>>> CID 1405471: Integer handling issues (SIGN_EXTENSION)
>>> Suspicious implicit sign extension: "nRow" with type "sal_uInt16" (16
>>> bits, unsigned) is promoted in "nRow * this->m_nCols + nCol" to type "int"
>>> (32 bits, signed), then sign-extended to type "unsigned long" (64 bits,
>>> unsigned). If "nRow * this->m_nCols + nCol" is greater than 0x7FFFFFFF,
>>> the upper bits of the result will all be 1.
435 m_aCells[nRow*m_nCols+nCol] = std::move(pCell);
436 }
437
438 inline long SwHTMLTableLayout::GetBrowseWidthMin() const
439 {
440 return (long)( (!m_nWidthOption || m_bPrcWidthOption) ? m_nMin :
m_nRelTabWidth );
** CID 1405470: Null pointer dereferences (FORWARD_NULL)
/chart2/source/controller/main/ControllerCommandDispatch.cxx: 416 in
chart::impl::ModelState::update(const
com::sun::star::uno::Reference<com::sun::star::frame::XModel> &)()
________________________________________________________________________________________________________
*** CID 1405470: Null pointer dereferences (FORWARD_NULL)
/chart2/source/controller/main/ControllerCommandDispatch.cxx: 416 in
chart::impl::ModelState::update(const
com::sun::star::uno::Reference<com::sun::star::frame::XModel> &)()
410 bSupportsAxes = ChartTypeHelper::isSupportingMainAxis(
xFirstChartType, nDimensionCount, 0 );
411
412 bIsThreeD = (nDimensionCount == 3);
413 if (xChartDoc.is())
414 {
415 ChartModel* pModel = dynamic_cast<ChartModel*>(xChartDoc.get());
>>> CID 1405470: Null pointer dereferences (FORWARD_NULL)
>>> Passing null pointer "pModel" to "hasInternalDataProvider", which
>>> dereferences it. (The dereference happens because this is a virtual
>>> function call.)
416 bHasOwnData = pModel->hasInternalDataProvider();
417 bHasDataFromPivotTable = pModel->isDataFromPivotTable();
418 }
419
420 bHasMainTitle = TitleHelper::getTitle( TitleHelper::MAIN_TITLE,
xModel ).is();
421 bHasSubTitle = TitleHelper::getTitle( TitleHelper::SUB_TITLE,
xModel ).is();
________________________________________________________________________________________________________
To view the defects in Coverity Scan visit,
https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V05UPxvVjWch-2Bd2MGckcRZBnDJeNb0HijxaS4JNJPxk3kpyAm2AYqo71yXmnOxB72ibeUH-2F-2F1Lhi9AZq3dRu-2F4-3D_g-2BrHdvqzaBa155F-2F8AmPhpJzY63UzWDisJV95WUBpGhqFw1ICExHG8aMaV2EoFpy9Bt6qqM9a5w-2FF0bnTRcHcDEYKe8k8CFx5Vq-2B5iNTTFHFc1ufETyPQ4O-2FkUKnNJCrBsL3I6wlzAUyBHL1-2FyJbEV-2BnUYyUVKba38TtVAvSbEHwlJ8KWdBhfoeZmRReY4l0qpUbgzChUcEivIDLCceBFfw7oA11SOiDuNo10q3SA4U-3D
To manage Coverity Scan email notifications for
"[email protected]", click
https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V05UPxvVjWch-2Bd2MGckcRbVDbis712qZDP-2FA8y06Nq4k1FZJSDV-2FTHi5VQof9xGafB4oBwGYxuHHknceo2QLpCrZ44Ciy7AqBR2QyX6OCB5N5X-2B1MAElavPQhH6nLwozJzqOkt2k8uOkYf2ZoppNa9QVe0T3fEZVQ7Kky1tOkLz_g-2BrHdvqzaBa155F-2F8AmPhpJzY63UzWDisJV95WUBpGhqFw1ICExHG8aMaV2EoFpy9Bt6qqM9a5w-2FF0bnTRcHcN345kgpxIPFrXPJsYxYluhNL-2FymW1gkmBDR54ftUgYONxOboL-2B-2BSs7D-2BJF-2BWZODX-2F32QQvs1bgQuZ2-2FIj2YNVWizKuN7gAjUczScbl-2BW9gujOZJGot2-2Fi-2BzWNynUPdh4NNLl6V-2FnhRkrIWV44tAddo-3D
_______________________________________________
LibreOffice mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/libreoffice
