Yes, I know. I will not fix firebird's code, they will hopefully do it "soon". I can add some work-around compiler flags, though.
I found out about GCC_VERSION and am now using that to conditionally enable the work-around compiler flags. On Wed, Aug 17, 2016 at 07:28:19PM +0200, Luc Castermans wrote: > actually case 1 is wrong code. Compiler is correct and code should be > corrected. > > regards, > > Luc > > Op 17 aug. 2016 19:18 schreef "Lionel Elie Mamane" <[email protected]>: > > > Hi, > > > > Short version: do we have a way to include compiler flags only with > > some compiler version? > > > > Long version: So, firebird currently is incompatible with GCC 6. AFAIK > > there are two breaker issues: > > > > 1) compiled code aborts in free() because it free()s an address that > > was not malloc()ed > > > > 2) code that does not compile > > > > > > Issue 1 is fixed by adding > > -fno-sized-deallocation -fno-delete-null-pointer-checks > > to CXXFLAGS. > > > > Issue 2 is fixed by backporting an upstream commit from their master > > branch. > > > > Number 2 I can do, no problem. But number 1 I feel I shouldn't do > > unconditionally, because another compiler than GCC 6 probably will not > > know these flags? Any advice there? > > > > -- > > Lionel > > _______________________________________________ > > LibreOffice mailing list > > [email protected] > > https://lists.freedesktop.org/mailman/listinfo/libreoffice > > _______________________________________________ LibreOffice mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/libreoffice
