loolwsd/PROBLEMS | 7 +++++++
1 file changed, 7 insertions(+)
New commits:
commit 6ca6bf0da68957b143d32c6d02a020830e7b5d76
Author: Tor Lillqvist <[email protected]>
Date: Fri Apr 15 12:26:56 2016 +0300
Rant about over-use of variables where literals would work
diff --git a/loolwsd/PROBLEMS b/loolwsd/PROBLEMS
index 6f72e28..687fae9 100644
--- a/loolwsd/PROBLEMS
+++ b/loolwsd/PROBLEMS
@@ -23,4 +23,11 @@
to kill it with SIGKILL. Which of course leaves all the chroot jails
around.
+- There are lots of places where a std::string variable is defined,
+ initialised with a value, that is never changed. (In many cases it
+ is const, so could of course not be changed.) Then the variable is
+ used just once or twice, passed as a parameter to a function, or
+ used in a comparisin expression. This is fairly pointless and just
+ makes the code harder to read. Use string literals instead.
+
- ASCII art? Seriously?
_______________________________________________
Libreoffice-commits mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
