On Sun, Sep 18, 2011 at 4:53 PM, Michael Stahl <[email protected]> wrote: > On 18.09.2011 23:07, Peter Foley wrote: >> I've attached two gbuild conversions. I'd appreciate it if someone could >> check if I've missed anything before I commit these. > > hi Peter, > > looking pretty good, just a bit of nitpicking below :) > > >> -ob bean : javaunohelper jurt ridljar unoil offapi udkapi NULL > [...] >> +ob bean : NULL >
another nitpick: --- a/tail_build/prj/build.lst +++ b/tail_build/prj/build.lst @@ -1,2 +1,2 @@ -tb tail_build : BERKELEYDB:berkeleydb BOOST:boost LIBXML2:libxml2 LIBXSLT:libxslt LIBWPG:libwpg LIBWPS:libwps LIBWPD:libwpd LIBVISIO:libvisio LPSOLVE:lpsolve MDDS:mdds OPENSSL:openssl REDLAND:redland TRANSLATIONS:translations avmedia basegfx basic canvas comphelper connectivity cppcanvas cppu cppuhelper filter fpicker offapi officecfg oovbaapi package qadevOOo DESKTOP:rdbmaker sal sax sfx2 soltools sot stoc svtools svx sysui test toolkit tools ucbhelper unoil unotools ure vbahelper vcl xmlhelp xmloff xmlscript solenv NULL +tb tail_build : BERKELEYDB:berkeleydb BOOST:boost LIBXML2:libxml2 LIBXSLT:libxslt LIBWPG:libwpg LIBWPS:libwps LIBWPD:libwpd LIBVISIO:libvisio LPSOLVE:lpsolve MDDS:mdds OPENSSL:openssl REDLAND:redland TRANSLATIONS:translations avmedia basegfx basic canvas comphelper connectivity cppcanvas cppu cppuhelper filter fpicker offapi officecfg oovbaapi package qadevOOo DESKTOP:rdbmaker sal sax sfx2 soltools sot stoc svtools svx sysui test toolkit tools ucbhelper unoil unotools ure vbahelper vcl xmlhelp xmloff xmlscript solenv javaunohelper jurt ridljar udkapi NULL tb tail_build\prj nmake - all tb_prj NULL Try to keep the addition in alphabetic order... roughly right now it is 'conditional' first, then non-conditional, in alphabetic order. that make stuff easier when merging other module to tail_build Norbert _______________________________________________ LibreOffice mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/libreoffice
