https://bugs.documentfoundation.org/show_bug.cgi?id=87743
--- Comment #14 from Björn Michaelsen <[email protected]> --- Also from #playonlinux: > petch2: quick script review: http://pastebin.com/raw/RcsgwRJ7 (copied below for archive): TITLE="LibreOffice 4.4.3" $TITLE will have to match the script name in the repository, so I'd recommend against including the version here, or the script will have to be renamed when the version changes PREFIX="LibreOffice_4.4.3" Similarly, unless you want to support installing different versions side-by-side, I'd recommend not including version in the prefix name (or say not the whole version if you want to support installing different major versions). On the other hand it could be useful to store the version in some variable to avoid repeating it in several places in the script. POL_SetupWindow_browse "Please select the setup file to run." "$TITLE" All user oriented messages must support localization mechanism http://wiki.playonlinux.com/index.php/Scripting_-_Chapter_10:_Script_Translation POL_Wine_WaitBefore "$TITLE" POL_SetupWindow_wait "$(eval_gettext 'Installation in progress.')" "$TITLE" POL_Wine_WaitBefore displays a standard wait message, the POL_SetupWindow_wait is redundan -- You are receiving this mail because: You are on the CC list for the bug.
_______________________________________________ LibreOffice mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/libreoffice
