Hi all,

I'm trying to add unit tests to webdav, for the time being limited to member function that are used internally, that is that don't need a server to interact with.

Member functions in library ucpdav1 are not exported (so I gather...).

Is the following method allowed to make externally visible member function that I intend to test? Any downside?

Limited to webdav_ucp::NeonUri as the first to be checked:

diff --git a/ucb/source/ucp/webdav-neon/NeonUri.hxx b/ucb/source/ucp/webdav-neon/NeonUri.hxx
index cd9fbe9..c5cea8c 100644
--- a/ucb/source/ucp/webdav-neon/NeonUri.hxx
+++ b/ucb/source/ucp/webdav-neon/NeonUri.hxx
@@ -41,7 +41,8 @@ namespace webdav_ucp
 #define DEFAULT_FTP_PORT        21

 // A URI implementation for use with the neon/expat library
-class NeonUri
+// Added SAL_DLLPUBLIC_EXPORT to implement cppunit test
+class SAL_DLLPUBLIC_EXPORT NeonUri
 {
     private:
         OUString mURI;

Thanks,
--
Kind Regards,
Giuseppe Castagno aka beppec56
Acca Esse http://www.acca-esse.eu
giuseppe.castagno at acca-esse.eu
_______________________________________________
LibreOffice mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Reply via email to