framework/source/accelerators/globalacceleratorconfiguration.cxx | 2 - framework/source/fwe/dispatch/interaction.cxx | 2 - framework/source/fwe/helper/documentundoguard.cxx | 2 - framework/source/fwe/helper/undomanagerhelper.cxx | 6 ++--- framework/source/jobs/jobdispatch.cxx | 2 - framework/source/jobs/jobexecutor.cxx | 2 - framework/source/layoutmanager/layoutmanager.cxx | 2 - framework/source/loadenv/loadenv.cxx | 2 - framework/source/services/autorecovery.cxx | 2 - framework/source/services/frame.cxx | 2 - framework/source/services/modulemanager.cxx | 2 - framework/source/services/pathsettings.cxx | 2 - framework/source/services/sessionlistener.cxx | 2 - framework/source/services/substitutepathvars.cxx | 2 - framework/source/services/tabwindowservice.cxx | 2 - framework/source/services/taskcreatorsrv.cxx | 2 - framework/source/uiconfiguration/globalsettings.cxx | 2 - framework/source/uiconfiguration/imagemanagerimpl.hxx | 2 - hwpfilter/source/hwpreader.hxx | 2 - sc/source/ui/docshell/documentlinkmgr.cxx | 4 +-- sc/source/ui/vba/vbarange.cxx | 4 +-- scripting/source/stringresource/stringresource.cxx | 2 - sd/source/ui/framework/configuration/ChangeRequestQueueProcessor.hxx | 2 - svx/source/form/tabwin.cxx | 2 - sw/source/core/unocore/unosett.cxx | 6 +---- sw/source/core/unocore/unostyle.cxx | 4 +-- sw/source/core/unocore/unotbl.cxx | 6 ++--- sw/source/uibase/sidebar/StylePresetsPanel.hxx | 2 - vcl/opengl/gdiimpl.cxx | 2 - vcl/source/app/svapp.cxx | 7 +++--- vcl/unx/gtk/a11y/atkwrapper.cxx | 11 +++++----- vcl/unx/gtk3/gtk3gtkframe.cxx | 2 - xmloff/source/meta/MetaImportComponent.cxx | 2 - xmlscript/source/xmlflat_imexp/xmlbas_export.hxx | 2 - 34 files changed, 50 insertions(+), 50 deletions(-)
New commits: commit f6a2deda724a0a23eb72820d9710b682d7f4cf44 Author: Caolán McNamara <[email protected]> Date: Tue Dec 29 19:33:57 2015 +0000 cppcheck: allocaCalled Change-Id: I97374357f27dc26fc67412f5cec7b96ad9bce9c2 diff --git a/vcl/unx/gtk/a11y/atkwrapper.cxx b/vcl/unx/gtk/a11y/atkwrapper.cxx index 5def4fe..0d4618a 100644 --- a/vcl/unx/gtk/a11y/atkwrapper.cxx +++ b/vcl/unx/gtk/a11y/atkwrapper.cxx @@ -56,7 +56,6 @@ #include <rtl/ref.hxx> #include <osl/diagnose.h> -#include <sal/alloca.h> #include <cppuhelper/factory.hxx> #include <cppuhelper/queryinterface.hxx> @@ -66,6 +65,7 @@ #include "atktextattributes.hxx" #include <string.h> +#include <vector> using namespace ::com::sun::star; @@ -502,18 +502,19 @@ wrapper_ref_relation_set( AtkObject *atk_obj ) { accessibility::AccessibleRelation aRelation = xRelationSet->getRelation( n ); sal_uInt32 nTargetCount = aRelation.TargetSet.getLength(); - AtkObject **pTargets = static_cast<AtkObject **>(alloca( nTargetCount * sizeof(AtkObject *) )); - for( sal_uInt32 i = 0; i < nTargetCount; i++ ) + std::vector<AtkObject*> aTargets; + + for (sal_uInt32 i = 0; i < nTargetCount; ++i) { uno::Reference< accessibility::XAccessible > xAccessible( aRelation.TargetSet[i], uno::UNO_QUERY ); - pTargets[i] = atk_object_wrapper_ref( xAccessible ); + aTargets.push_back(atk_object_wrapper_ref(xAccessible)); } AtkRelation *pRel = atk_relation_new( - pTargets, nTargetCount, + aTargets.data(), nTargetCount, mapRelationType( aRelation.RelationType ) ); atk_relation_set_add( pSet, pRel ); commit bea8a7ad63e6e00c757909702f0439b2ffd3b48a Author: Caolán McNamara <[email protected]> Date: Tue Dec 29 19:27:43 2015 +0000 cppcheck: noExplicitConstructor Change-Id: Ib43e53d5b6c9c130adb765ac9b769f58060ac640 diff --git a/framework/source/accelerators/globalacceleratorconfiguration.cxx b/framework/source/accelerators/globalacceleratorconfiguration.cxx index 942c2f0..eb7dded 100644 --- a/framework/source/accelerators/globalacceleratorconfiguration.cxx +++ b/framework/source/accelerators/globalacceleratorconfiguration.cxx @@ -52,7 +52,7 @@ public: @param xSMGR reference to an uno service manager, which is used internally. */ - GlobalAcceleratorConfiguration(const css::uno::Reference< css::uno::XComponentContext >& xContext); + explicit GlobalAcceleratorConfiguration(const css::uno::Reference< css::uno::XComponentContext >& xContext); /** TODO */ virtual ~GlobalAcceleratorConfiguration() {} diff --git a/framework/source/fwe/dispatch/interaction.cxx b/framework/source/fwe/dispatch/interaction.cxx index 1a0aabe..f97b18b 100644 --- a/framework/source/fwe/dispatch/interaction.cxx +++ b/framework/source/fwe/dispatch/interaction.cxx @@ -86,7 +86,7 @@ OUString SAL_CALL ContinuationFilterSelect::getFilter() throw( css::uno::Runtime class RequestFilterSelect_Impl : public ::cppu::WeakImplHelper< css::task::XInteractionRequest > { public: - RequestFilterSelect_Impl( const OUString& sURL ); + explicit RequestFilterSelect_Impl(const OUString& rURL); bool isAbort () const; OUString getFilter() const; diff --git a/framework/source/fwe/helper/documentundoguard.cxx b/framework/source/fwe/helper/documentundoguard.cxx index bd29d5d..c65d94b 100644 --- a/framework/source/fwe/helper/documentundoguard.cxx +++ b/framework/source/fwe/helper/documentundoguard.cxx @@ -51,7 +51,7 @@ namespace framework class UndoManagerContextListener : public UndoManagerContextListener_Base { public: - UndoManagerContextListener( const Reference< XUndoManager >& i_undoManager ) + explicit UndoManagerContextListener( const Reference< XUndoManager >& i_undoManager ) :m_xUndoManager( i_undoManager ) ,m_nRelativeContextDepth( 0 ) ,m_documentDisposed( false ) diff --git a/framework/source/fwe/helper/undomanagerhelper.cxx b/framework/source/fwe/helper/undomanagerhelper.cxx index 91a7e44..952b17f 100644 --- a/framework/source/fwe/helper/undomanagerhelper.cxx +++ b/framework/source/fwe/helper/undomanagerhelper.cxx @@ -69,7 +69,7 @@ namespace framework class UndoActionWrapper : public SfxUndoAction { public: - UndoActionWrapper( + explicit UndoActionWrapper( Reference< XUndoAction > const& i_undoAction ); virtual ~UndoActionWrapper(); @@ -138,7 +138,7 @@ namespace framework class UndoManagerRequest : public ::comphelper::AnyEvent { public: - UndoManagerRequest( ::std::function<void ()> const& i_request ) + explicit UndoManagerRequest( ::std::function<void ()> const& i_request ) :m_request( i_request ) ,m_caughtException() ,m_finishCondition() @@ -211,7 +211,7 @@ namespace framework ::osl::Mutex& getMutex() { return m_aMutex; } public: - UndoManagerHelper_Impl( IUndoManagerImplementation& i_undoManagerImpl ) + explicit UndoManagerHelper_Impl( IUndoManagerImplementation& i_undoManagerImpl ) :m_aMutex() ,m_aQueueMutex() ,m_disposed( false ) diff --git a/framework/source/jobs/jobdispatch.cxx b/framework/source/jobs/jobdispatch.cxx index 07fcef4..022b204 100644 --- a/framework/source/jobs/jobdispatch.cxx +++ b/framework/source/jobs/jobdispatch.cxx @@ -76,7 +76,7 @@ private: public: - JobDispatch( const css::uno::Reference< css::uno::XComponentContext >& xContext ); + explicit JobDispatch(const css::uno::Reference< css::uno::XComponentContext >& xContext); virtual ~JobDispatch(); void impl_dispatchEvent ( const OUString& sEvent , diff --git a/framework/source/jobs/jobexecutor.cxx b/framework/source/jobs/jobexecutor.cxx index 7091256..05fd77d 100644 --- a/framework/source/jobs/jobexecutor.cxx +++ b/framework/source/jobs/jobexecutor.cxx @@ -83,7 +83,7 @@ private: public: - JobExecutor( const css::uno::Reference< css::uno::XComponentContext >& xContext ); + explicit JobExecutor(const css::uno::Reference< css::uno::XComponentContext >& xContext); virtual ~JobExecutor(); virtual OUString SAL_CALL getImplementationName() diff --git a/framework/source/layoutmanager/layoutmanager.cxx b/framework/source/layoutmanager/layoutmanager.cxx index 36a2d54..9ed8382 100644 --- a/framework/source/layoutmanager/layoutmanager.cxx +++ b/framework/source/layoutmanager/layoutmanager.cxx @@ -3132,7 +3132,7 @@ namespace detail private: ::cppu::OPropertyArrayHelper *m_pInfoHelper; public: - InfoHelperBuilder(const LayoutManager &rManager) + explicit InfoHelperBuilder(const LayoutManager &rManager) { uno::Sequence< beans::Property > aProperties; rManager.describeProperties(aProperties); diff --git a/framework/source/loadenv/loadenv.cxx b/framework/source/loadenv/loadenv.cxx index 0bed592..323926a 100644 --- a/framework/source/loadenv/loadenv.cxx +++ b/framework/source/loadenv/loadenv.cxx @@ -102,7 +102,7 @@ class LoadEnvListener : public ::cppu::WeakImplHelper< css::frame::XLoadEventLis public: - LoadEnvListener(LoadEnv* pLoadEnv) + explicit LoadEnvListener(LoadEnv* pLoadEnv) : m_bWaitingResult(true) , m_pLoadEnv(pLoadEnv) { diff --git a/framework/source/services/autorecovery.cxx b/framework/source/services/autorecovery.cxx index 26e174a..e45ebdc 100644 --- a/framework/source/services/autorecovery.cxx +++ b/framework/source/services/autorecovery.cxx @@ -447,7 +447,7 @@ private: public: - AutoRecovery(const css::uno::Reference< css::uno::XComponentContext >& xContext); + explicit AutoRecovery(const css::uno::Reference< css::uno::XComponentContext >& xContext); virtual ~AutoRecovery( ); virtual OUString SAL_CALL getImplementationName() diff --git a/framework/source/services/frame.cxx b/framework/source/services/frame.cxx index 69692ec..615bae9 100644 --- a/framework/source/services/frame.cxx +++ b/framework/source/services/frame.cxx @@ -144,7 +144,7 @@ class Frame : // interfaces { public: - Frame( const css::uno::Reference< css::uno::XComponentContext >& xContext ); + explicit Frame(const css::uno::Reference< css::uno::XComponentContext >& xContext); virtual ~Frame(); /// Initialization function after having acquire()'d. diff --git a/framework/source/services/modulemanager.cxx b/framework/source/services/modulemanager.cxx index 942e6cf..e558ed0 100644 --- a/framework/source/services/modulemanager.cxx +++ b/framework/source/services/modulemanager.cxx @@ -62,7 +62,7 @@ private: public: - ModuleManager(const css::uno::Reference< css::uno::XComponentContext >& xContext); + explicit ModuleManager(const css::uno::Reference< css::uno::XComponentContext >& xContext); virtual ~ModuleManager(); diff --git a/framework/source/services/pathsettings.cxx b/framework/source/services/pathsettings.cxx index 83543c6..063966f 100644 --- a/framework/source/services/pathsettings.cxx +++ b/framework/source/services/pathsettings.cxx @@ -180,7 +180,7 @@ public: Attention: It's necessary for right function of this class, that the order of base classes is the right one. Because we transfer information from one base to another during this ctor runs! */ - PathSettings(const css::uno::Reference< css::uno::XComponentContext >& xContext); + explicit PathSettings(const css::uno::Reference< css::uno::XComponentContext >& xContext); /** free all used resources ... if it was not already done. */ virtual ~PathSettings(); diff --git a/framework/source/services/sessionlistener.cxx b/framework/source/services/sessionlistener.cxx index 8ba90ab..851a657 100644 --- a/framework/source/services/sessionlistener.cxx +++ b/framework/source/services/sessionlistener.cxx @@ -107,7 +107,7 @@ private: void QuitSessionQuietly(); public: - SessionListener( const css::uno::Reference< css::uno::XComponentContext >& xContext ); + explicit SessionListener(const css::uno::Reference< css::uno::XComponentContext >& xContext); virtual ~SessionListener(); diff --git a/framework/source/services/substitutepathvars.cxx b/framework/source/services/substitutepathvars.cxx index 3bf6c89..7d4dc86 100644 --- a/framework/source/services/substitutepathvars.cxx +++ b/framework/source/services/substitutepathvars.cxx @@ -227,7 +227,7 @@ class SubstitutePathVariables : private cppu::BaseMutex, friend class SubstitutePathVariables_Impl; public: - SubstitutePathVariables( const css::uno::Reference< css::uno::XComponentContext >& xContext ); + explicit SubstitutePathVariables(const css::uno::Reference< css::uno::XComponentContext >& xContext); virtual ~SubstitutePathVariables(); virtual OUString SAL_CALL getImplementationName() diff --git a/framework/source/services/tabwindowservice.cxx b/framework/source/services/tabwindowservice.cxx index dde0162..a31de09 100644 --- a/framework/source/services/tabwindowservice.cxx +++ b/framework/source/services/tabwindowservice.cxx @@ -57,7 +57,7 @@ struct TTabPageInfo , m_lProperties ( ) {} - TTabPageInfo(::sal_Int32 nID) + explicit TTabPageInfo(::sal_Int32 nID) : m_nIndex ( nID ) , m_bCreated (false) , m_pPage ( nullptr ) diff --git a/framework/source/services/taskcreatorsrv.cxx b/framework/source/services/taskcreatorsrv.cxx index d46b9ba..6f73c4d 100644 --- a/framework/source/services/taskcreatorsrv.cxx +++ b/framework/source/services/taskcreatorsrv.cxx @@ -63,7 +63,7 @@ private: public: - TaskCreatorService(const css::uno::Reference< css::uno::XComponentContext >& xContext); + explicit TaskCreatorService(const css::uno::Reference< css::uno::XComponentContext >& xContext); virtual ~TaskCreatorService( ); virtual OUString SAL_CALL getImplementationName() diff --git a/framework/source/uiconfiguration/globalsettings.cxx b/framework/source/uiconfiguration/globalsettings.cxx index e9076b0..80ec574 100644 --- a/framework/source/uiconfiguration/globalsettings.cxx +++ b/framework/source/uiconfiguration/globalsettings.cxx @@ -56,7 +56,7 @@ class GlobalSettings_Access : public ::cppu::WeakImplHelper< css::lang::XEventListener> { public: - GlobalSettings_Access( const css::uno::Reference< css::uno::XComponentContext >& rxContext ); + explicit GlobalSettings_Access( const css::uno::Reference< css::uno::XComponentContext >& rxContext ); virtual ~GlobalSettings_Access(); // XComponent diff --git a/framework/source/uiconfiguration/imagemanagerimpl.hxx b/framework/source/uiconfiguration/imagemanagerimpl.hxx index f756f0b..9b4af25 100644 --- a/framework/source/uiconfiguration/imagemanagerimpl.hxx +++ b/framework/source/uiconfiguration/imagemanagerimpl.hxx @@ -76,7 +76,7 @@ namespace framework class GlobalImageList : public CmdImageList, public salhelper::SimpleReferenceObject { public: - GlobalImageList( const css::uno::Reference< css::uno::XComponentContext >& rxContext ); + explicit GlobalImageList(const css::uno::Reference< css::uno::XComponentContext >& rxContext); virtual ~GlobalImageList(); virtual Image getImageFromCommandURL( sal_Int16 nImageType, const OUString& rCommandURL ) override; diff --git a/hwpfilter/source/hwpreader.hxx b/hwpfilter/source/hwpreader.hxx index 3353bdd..d11870e 100644 --- a/hwpfilter/source/hwpreader.hxx +++ b/hwpfilter/source/hwpreader.hxx @@ -152,7 +152,7 @@ private: class HwpImportFilter : public WeakImplHelper< XFilter, XImporter, XServiceInfo, XExtendedFilterDetection > { public: - HwpImportFilter(const Reference< XMultiServiceFactory >& rFact); + explicit HwpImportFilter(const Reference< XMultiServiceFactory >& rFact); virtual ~HwpImportFilter(); public: diff --git a/sc/source/ui/docshell/documentlinkmgr.cxx b/sc/source/ui/docshell/documentlinkmgr.cxx index 9609781..24e156a 100644 --- a/sc/source/ui/docshell/documentlinkmgr.cxx +++ b/sc/source/ui/docshell/documentlinkmgr.cxx @@ -37,8 +37,8 @@ struct DocumentLinkManagerImpl : boost::noncopyable std::unique_ptr<DataStream> mpDataStream; std::unique_ptr<sfx2::LinkManager> mpLinkManager; - DocumentLinkManagerImpl( SfxObjectShell* pShell ) : - mpShell(pShell), mpDataStream(nullptr), mpLinkManager(nullptr) {} + explicit DocumentLinkManagerImpl(SfxObjectShell* pShell) + : mpShell(pShell), mpDataStream(nullptr), mpLinkManager(nullptr) {} ~DocumentLinkManagerImpl() { diff --git a/sc/source/ui/vba/vbarange.cxx b/sc/source/ui/vba/vbarange.cxx index 378f5b7..ad2ddbf 100644 --- a/sc/source/ui/vba/vbarange.cxx +++ b/sc/source/ui/vba/vbarange.cxx @@ -295,7 +295,7 @@ class SingleRangeEnumeration : public EnumerationHelper_BASE bool bHasMore; public: - SingleRangeEnumeration( const uno::Reference< table::XCellRange >& xRange ) throw ( uno::RuntimeException ) : m_xRange( xRange ), bHasMore( true ) { } + explicit SingleRangeEnumeration( const uno::Reference< table::XCellRange >& xRange ) throw ( uno::RuntimeException ) : m_xRange( xRange ), bHasMore( true ) { } virtual sal_Bool SAL_CALL hasMoreElements( ) throw (uno::RuntimeException, std::exception) override { return bHasMore; } virtual uno::Any SAL_CALL nextElement( ) throw (container::NoSuchElementException, lang::WrappedTargetException, uno::RuntimeException, std::exception) override { @@ -316,7 +316,7 @@ private: uno::Reference< table::XCellRange > m_xRange; public: - SingleRangeIndexAccess( const uno::Reference< table::XCellRange >& xRange ) : m_xRange( xRange ) {} + explicit SingleRangeIndexAccess( const uno::Reference< table::XCellRange >& xRange ) : m_xRange( xRange ) {} // XIndexAccess virtual ::sal_Int32 SAL_CALL getCount() throw (::uno::RuntimeException, std::exception) override { return 1; } virtual uno::Any SAL_CALL getByIndex( ::sal_Int32 Index ) throw (lang::IndexOutOfBoundsException, lang::WrappedTargetException, uno::RuntimeException, std::exception) override diff --git a/scripting/source/stringresource/stringresource.cxx b/scripting/source/stringresource/stringresource.cxx index 0e383b0..5a93fc7 100644 --- a/scripting/source/stringresource/stringresource.cxx +++ b/scripting/source/stringresource/stringresource.cxx @@ -1250,7 +1250,7 @@ class BinaryOutput Reference< io::XOutputStream > m_xOutputStream; public: - BinaryOutput( Reference< XComponentContext > xContext ); + explicit BinaryOutput( Reference< XComponentContext > xContext ); Reference< io::XOutputStream > getOutputStream() const { return m_xOutputStream; } diff --git a/sd/source/ui/framework/configuration/ChangeRequestQueueProcessor.hxx b/sd/source/ui/framework/configuration/ChangeRequestQueueProcessor.hxx index 214efb5..725b799 100644 --- a/sd/source/ui/framework/configuration/ChangeRequestQueueProcessor.hxx +++ b/sd/source/ui/framework/configuration/ChangeRequestQueueProcessor.hxx @@ -54,7 +54,7 @@ public: ConfigurationController so that its UpdateConfiguration() method can be called when the queue becomes empty. */ - ChangeRequestQueueProcessor ( + explicit ChangeRequestQueueProcessor ( const std::shared_ptr<ConfigurationUpdater>& rpUpdater); ~ChangeRequestQueueProcessor(); diff --git a/svx/source/form/tabwin.cxx b/svx/source/form/tabwin.cxx index bc3ee57..c2ba42a 100644 --- a/svx/source/form/tabwin.cxx +++ b/svx/source/form/tabwin.cxx @@ -76,7 +76,7 @@ namespace { struct ColumnInfo { OUString sColumnName; - ColumnInfo(const OUString& i_sColumnName) + explicit ColumnInfo(const OUString& i_sColumnName) : sColumnName(i_sColumnName) { } diff --git a/sw/source/core/unocore/unosett.cxx b/sw/source/core/unocore/unosett.cxx index b3a5571..16c42bf 100644 --- a/sw/source/core/unocore/unosett.cxx +++ b/sw/source/core/unocore/unosett.cxx @@ -1050,19 +1050,17 @@ OSL_FAIL("not implemented"); static const char aInvalidStyle[] = "__XXX___invalid"; - class SwXNumberingRules::Impl : public SwClient { private: SwXNumberingRules& m_rParent; public: - Impl(SwXNumberingRules& rParent) : m_rParent(rParent) {} + explicit Impl(SwXNumberingRules& rParent) : m_rParent(rParent) {} protected: //SwClient - virtual void Modify( const SfxPoolItem* pOld, const SfxPoolItem *pNew) override; + virtual void Modify( const SfxPoolItem* pOld, const SfxPoolItem *pNew) override; }; - bool SwXNumberingRules::isInvalidStyle(const OUString &rName) { return rName == aInvalidStyle; diff --git a/sw/source/core/unocore/unostyle.cxx b/sw/source/core/unocore/unostyle.cxx index 390352d..ffb0f0f 100644 --- a/sw/source/core/unocore/unostyle.cxx +++ b/sw/source/core/unocore/unostyle.cxx @@ -376,7 +376,7 @@ public: SwDoc* pDoc, const OUString& rStyleName) : SwXStyle(&rPool, SFX_STYLE_FAMILY_FRAME, pDoc, rStyleName){} - SwXFrameStyle( SwDoc *pDoc ); + explicit SwXFrameStyle(SwDoc *pDoc); virtual ~SwXFrameStyle(); virtual void SAL_CALL acquire( ) throw() override {SwXStyle::acquire();} @@ -409,7 +409,7 @@ protected: public: SwXPageStyle(SfxStyleSheetBasePool& rPool, SwDocShell* pDocSh, SfxStyleFamily eFam, const OUString& rStyleName); - SwXPageStyle(SwDocShell* pDocSh); + explicit SwXPageStyle(SwDocShell* pDocSh); virtual ~SwXPageStyle(); virtual void SAL_CALL setPropertyValue( const OUString& aPropertyName, const css::uno::Any& aValue ) throw(css::beans::UnknownPropertyException, css::beans::PropertyVetoException, css::lang::IllegalArgumentException, css::lang::WrappedTargetException, css::uno::RuntimeException, std::exception) override; diff --git a/sw/source/core/unocore/unotbl.cxx b/sw/source/core/unocore/unotbl.cxx index bd7403f..2bf55f1 100644 --- a/sw/source/core/unocore/unotbl.cxx +++ b/sw/source/core/unocore/unotbl.cxx @@ -3777,7 +3777,7 @@ void SwXCellRange::Modify( const SfxPoolItem* pOld, const SfxPoolItem *pNew) class SwXTableRows::Impl : public SwClient { public: - Impl(SwFrameFormat& rFrameFormat) : SwClient(&rFrameFormat) {} + explicit Impl(SwFrameFormat& rFrameFormat) : SwClient(&rFrameFormat) {} protected: //SwClient virtual void Modify( const SfxPoolItem* pOld, const SfxPoolItem *pNew) override; @@ -3944,10 +3944,10 @@ void SwXTableRows::Impl::Modify( const SfxPoolItem* pOld, const SfxPoolItem *pNe class SwXTableColumns::Impl : public SwClient { public: - Impl(SwFrameFormat& rFrameFormat) : SwClient(&rFrameFormat) {} + explicit Impl(SwFrameFormat& rFrameFormat) : SwClient(&rFrameFormat) {} protected: //SwClient - virtual void Modify( const SfxPoolItem* pOld, const SfxPoolItem *pNew) override; + virtual void Modify( const SfxPoolItem* pOld, const SfxPoolItem *pNew) override; }; OUString SwXTableColumns::getImplementationName() throw( uno::RuntimeException, std::exception ) diff --git a/sw/source/uibase/sidebar/StylePresetsPanel.hxx b/sw/source/uibase/sidebar/StylePresetsPanel.hxx index d0ca775..552e96c 100644 --- a/sw/source/uibase/sidebar/StylePresetsPanel.hxx +++ b/sw/source/uibase/sidebar/StylePresetsPanel.hxx @@ -58,7 +58,7 @@ public: private: struct TemplateEntry { - TemplateEntry(OUString& rURL) + explicit TemplateEntry(const OUString& rURL) : maURL(rURL) {} diff --git a/vcl/opengl/gdiimpl.cxx b/vcl/opengl/gdiimpl.cxx index 1c6be71..549f8ae 100644 --- a/vcl/opengl/gdiimpl.cxx +++ b/vcl/opengl/gdiimpl.cxx @@ -43,7 +43,7 @@ class OpenGLFlushIdle : public Idle { OpenGLSalGraphicsImpl *m_pImpl; public: - OpenGLFlushIdle( OpenGLSalGraphicsImpl *pImpl ) + explicit OpenGLFlushIdle( OpenGLSalGraphicsImpl *pImpl ) : Idle( "gl idle swap" ) , m_pImpl( pImpl ) { diff --git a/vcl/source/app/svapp.cxx b/vcl/source/app/svapp.cxx index d26a350..ab18d70 100644 --- a/vcl/source/app/svapp.cxx +++ b/vcl/source/app/svapp.cxx @@ -88,9 +88,10 @@ void InitSettings(ImplSVData* pSVData); class ImplReservedKey { public: - ImplReservedKey( vcl::KeyCode aKeyCode ) : - mKeyCode(aKeyCode) - {} + explicit ImplReservedKey( vcl::KeyCode aKeyCode ) + : mKeyCode(aKeyCode) + { + } vcl::KeyCode mKeyCode; }; diff --git a/vcl/unx/gtk3/gtk3gtkframe.cxx b/vcl/unx/gtk3/gtk3gtkframe.cxx index 17f81a0..fea19c9 100644 --- a/vcl/unx/gtk3/gtk3gtkframe.cxx +++ b/vcl/unx/gtk3/gtk3gtkframe.cxx @@ -339,7 +339,7 @@ namespace { /// Decouple SalFrame lifetime from damagetracker lifetime struct DamageTracker : public basebmp::IBitmapDeviceDamageTracker { - DamageTracker(GtkSalFrame& rFrame) : m_rFrame(rFrame) + explicit DamageTracker(GtkSalFrame& rFrame) : m_rFrame(rFrame) {} virtual ~DamageTracker() {} diff --git a/xmloff/source/meta/MetaImportComponent.cxx b/xmloff/source/meta/MetaImportComponent.cxx index ed54444..c9af8af 100644 --- a/xmloff/source/meta/MetaImportComponent.cxx +++ b/xmloff/source/meta/MetaImportComponent.cxx @@ -37,7 +37,7 @@ private: public: // XMLMetaImportComponent() throw(); - XMLMetaImportComponent( + explicit XMLMetaImportComponent( const css::uno::Reference< css::uno::XComponentContext >& xContext ) throw(); diff --git a/xmlscript/source/xmlflat_imexp/xmlbas_export.hxx b/xmlscript/source/xmlflat_imexp/xmlbas_export.hxx index 2747599..199528b 100644 --- a/xmlscript/source/xmlflat_imexp/xmlbas_export.hxx +++ b/xmlscript/source/xmlflat_imexp/xmlbas_export.hxx @@ -48,7 +48,7 @@ namespace xmlscript bool m_bOasis; public: - XMLBasicExporterBase(bool bOasis ); + explicit XMLBasicExporterBase(bool bOasis); virtual ~XMLBasicExporterBase(); // XServiceInfo
_______________________________________________ Libreoffice-commits mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
