Re: [Libreoffice-commits] core.git: Revert "ToolBox: Remove unused methods"

Thu, 19 Nov 2015 01:17:34 -0800 

On 11/18/2015 09:32 PM, Maxim Monastirsky wrote:

commit 78214c982e1fab18b9f6c694a3b56c520da1724d
Author: Maxim Monastirsky <[email protected]>
Date:   Wed Nov 18 22:26:32 2015 +0200

     Revert "ToolBox: Remove unused methods"

     The ImplLoadRes method *is* used in
     ToolBox::ToolBox( vcl::Window* pParent, const ResId& rResId ).
     This change breaks the navigator panel, and therefore the
     JunitTest_toolkit_unoapi_1 test.

     This reverts commit 99648095012187ef284d0a9399a8e12878b2a370.
By the way, a good way to check whether a function is really unused is to temporarily define it as deleted. 
_______________________________________________
LibreOffice mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Reply via email to