On 2015-03-18 03:01 PM, Piet van Oostrum wrote:
About a week ago I submitted a patch to gerrit
(https://gerrit.libreoffice.org/#/c/14841/). However, the build failed on
Windows, due to a unit test failing. I looked in the log file and it seems to
me that the unit test failure is not related to my patch. So what should I do
next?
Shall I resubmit the patch, possibly after rebasing it to the current master?
This is the first time I am doing this, so I have no experience. I also don't
know if the patch will be reviewed, given that the build failed. Or will it be
considered anyway?
Unit test failures are not really a problem, unless it is obvious that you
introduced them.
However, I note that Miklos asked you to add a unit test. Doing that would
probably ensure that your change is committed :-)
_______________________________________________
LibreOffice mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/libreoffice
