sal/osl/unx/pipe.cxx | 4 ++++
1 file changed, 4 insertions(+)
New commits:
commit 2975abf7964de1f4b705204caac722b3ea69cb8b
Author: Stephan Bergmann <[email protected]>
Date: Fri Nov 21 12:29:24 2014 +0100
Silence false cid#1255391 TOCTOU warning
Change-Id: Ifc35c379d5c68fb363ae3507ccb5bff37c8cd9aa
diff --git a/sal/osl/unx/pipe.cxx b/sal/osl/unx/pipe.cxx
index b1b5a76..ecddb66 100644
--- a/sal/osl/unx/pipe.cxx
+++ b/sal/osl/unx/pipe.cxx
@@ -311,6 +311,10 @@ oslPipe SAL_CALL osl_psz_createPipe(const sal_Char
*pszPipeName, oslPipeOptions
if ( listen(pPipe->m_Socket, 5) < 0 )
{
OSL_TRACE("osl_createPipe failed to listen. Errno: %d;
%s",errno,strerror(errno));
+ // coverity[toctou] cid#1255391 warns about unlink(name) after
+ // stat(name, &status) above, but the intervening call to bind
makes
+ // those two clearly unrelated, as it would fail if name existed at
+ // that point in time:
unlink(name); /* remove filesystem entry */
close (pPipe->m_Socket);
__osl_destroyPipeImpl(pPipe);
_______________________________________________
Libreoffice-commits mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
