include/vcl/animate.hxx | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-)
New commits: commit 65f41639e219470c80f896129731f9ed6f072b6b Author: Chris Sherlock <[email protected]> Date: Mon Nov 17 21:59:28 2014 +1100 vcl: remove AnimViewList_impl typedef also Another typedef that destroys code readibility. I've removed AnimViewList_impl because it's just a vector of ImplAnimView pointers. Change-Id: I97e5867e1a7aeae575e45989ba7436867da9c808 diff --git a/include/vcl/animate.hxx b/include/vcl/animate.hxx index dae31a9..e966e3f 100644 --- a/include/vcl/animate.hxx +++ b/include/vcl/animate.hxx @@ -122,7 +122,6 @@ struct AInfo }; class ImplAnimView; -typedef ::std::vector< ImplAnimView* > AnimViewList_impl; class VCL_DLLPUBLIC Animation { @@ -217,8 +216,8 @@ public: private: SAL_DLLPRIVATE static sal_uLong mnAnimCount; - std::vector< AnimationBitmap* >maList; - AnimViewList_impl maViewList; + std::vector< AnimationBitmap* > maList; + std::vector< ImplAnimView* > maViewList; Link maNotifyLink; BitmapEx maBitmapEx; commit 725150f4ad8bcbe4c9706eea264238c1e3159915 Author: Chris Sherlock <[email protected]> Date: Mon Nov 17 21:55:47 2014 +1100 vcl: remove AnimationBitmapList_impl typedef Severe overuse of typedefs makes baby Torvalds sad. :-) AnimationBitmapList_impl is just a typedef to a vector of AnimationBitmap pointers. It's used precisely once in the code - in animate.hxx. This just makes reading the code more difficult - too many layers of abstraction. Change-Id: If84892dc90220c7dfe8c071d629268efa226f069 diff --git a/include/vcl/animate.hxx b/include/vcl/animate.hxx index 25f10f0..dae31a9 100644 --- a/include/vcl/animate.hxx +++ b/include/vcl/animate.hxx @@ -122,7 +122,6 @@ struct AInfo }; class ImplAnimView; -typedef ::std::vector< AnimationBitmap* > AnimationBitmapList_impl; typedef ::std::vector< ImplAnimView* > AnimViewList_impl; class VCL_DLLPUBLIC Animation @@ -218,7 +217,7 @@ public: private: SAL_DLLPRIVATE static sal_uLong mnAnimCount; - AnimationBitmapList_impl maList; + std::vector< AnimationBitmap* >maList; AnimViewList_impl maViewList; Link maNotifyLink; _______________________________________________ Libreoffice-commits mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
