On Thu, 2011-07-07 at 23:02 -0400, Kohei Yoshida wrote:

> Now, a slightly bigger issue.  The sheet prefix option input box doesn't
> check for valid sheet name.

A little follow-up on this.  I see that you *do* do naming fallback in
case the custom name is not a valid name.  But instead of doing this in
ScDocument::GetFallBackPrefix(), it's better to not allow an invalid
name in the option page in the first place.  Otherwise the behavior
would become a bit confusing.

Kohei

-- 
Kohei Yoshida, LibreOffice hacker, Calc
<[email protected]>

_______________________________________________
LibreOffice mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Reply via email to