sc/inc/token.hxx | 2 ++ sc/source/filter/oox/addressconverter.cxx | 6 +++++- sc/source/filter/oox/formulaparser.cxx | 22 +++++++++++++++++++++- 3 files changed, 28 insertions(+), 2 deletions(-)
New commits: commit 2ec4c8b07427af868e32e14aaefd20649c1135d6 Author: Eike Rathke <[email protected]> Date: Fri Oct 31 16:11:44 2014 +0100 converity#1249470 Uninitialized scalar field comment it's unnecessary Change-Id: Iebf2d1dbed1f9c1e2e09144f47e73d9628355f2e diff --git a/sc/inc/token.hxx b/sc/inc/token.hxx index 7eb4ef0..da4f9e9 100644 --- a/sc/inc/token.hxx +++ b/sc/inc/token.hxx @@ -383,6 +383,8 @@ public: { pS = 0; pD = rT.GetDoubleRef(); + // aDub intentionally not initialized, unnecessary + // because unused. } } SingleDoubleRefModifier( ScSingleRefData& rS ) commit 4c3dbdd2afafa6d112e8262b448ce9462472ee49 Author: Eike Rathke <[email protected]> Date: Fri Oct 31 15:53:52 2014 +0100 converity#707956 Uninitialized scalar field Change-Id: Ic341502383de8a5b0843d2c4c15e7388818a6027 diff --git a/sc/source/filter/oox/addressconverter.cxx b/sc/source/filter/oox/addressconverter.cxx index 75d5d33..c3a8fb7 100644 --- a/sc/source/filter/oox/addressconverter.cxx +++ b/sc/source/filter/oox/addressconverter.cxx @@ -123,6 +123,7 @@ AddressConverter::AddressConverter( const WorkbookHelper& rHelper ) : { case FILTER_OOXML: initializeMaxPos( OOX_MAXTAB, OOX_MAXCOL, OOX_MAXROW ); + maLinkChars.set( 0xFFFF, 0xFFFF, 0xFFFF, 0xFFFF, 0xFFFF ); break; case FILTER_BIFF: switch( getBiff() ) { @@ -149,7 +150,10 @@ AddressConverter::AddressConverter( const WorkbookHelper& rHelper ) : case BIFF_UNKNOWN: break; } break; - case FILTER_UNKNOWN: break; + case FILTER_UNKNOWN: + initializeMaxPos( 0, 0, 0 ); + maLinkChars.set( 0xFFFF, 0xFFFF, 0xFFFF, 0xFFFF, 0xFFFF ); + break; } } commit eeec20ddb3034bd2aef775d614d9d80019c7493f Author: Eike Rathke <[email protected]> Date: Fri Oct 31 15:42:14 2014 +0100 converity#738797 Uninitialized pointer field Change-Id: I84cd8b6542d2b52df620d56eb6492139a1d60c10 diff --git a/sc/source/filter/oox/formulaparser.cxx b/sc/source/filter/oox/formulaparser.cxx index 9909818..ba99aa6 100644 --- a/sc/source/filter/oox/formulaparser.cxx +++ b/sc/source/filter/oox/formulaparser.cxx @@ -2046,7 +2046,27 @@ BiffFormulaParserImpl::BiffFormulaParserImpl( const FormulaParser& rParent ) : mnMemFuncSize = 2; mnRefIdSize = 0; break; - case BIFF_UNKNOWN: break; + case BIFF_UNKNOWN: + mpImportStrToken = NULL; + mpImportSpaceToken = NULL; + mpImportSheetToken = NULL; + mpImportEndSheetToken = NULL; + mpImportNlrToken = NULL; + mpImportRefToken = NULL; + mpImportAreaToken = NULL; + mpImportRef3dToken = NULL; + mpImportArea3dToken = NULL; + mpImportNameXToken = NULL; + mpImportFuncToken = NULL; + mpImportFuncVarToken = NULL; + mpImportFuncCEToken = NULL; + mnAttrDataSize = 0; + mnArraySize = 0; + mnNameSize = 0; + mnMemAreaSize = 0; + mnMemFuncSize = 0; + mnRefIdSize = 0; + break; } } _______________________________________________ Libreoffice-commits mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
