On Wed, 22 Jun 2011 09:23:48 -0500
Norbert Thiebaud <[email protected]>
wrote:

> Never-the-less I still think it is a 'Bad Thing(tm)' to have a
> pre-commit hook altering on the fly what need to be committed... so I
> suggest we stick with the 'warn but do no harm' approach (rather than
> merely fixing/reverting the commit above).

As somebody bitten hard by this behavior I can only say: Yes, please.

No hook should ever think itself to be clever enough to change state
without backup(*), even if it would be bugfree.

Best,

Bjoern

(*) And some obscure named file silently created in /tmp is not a
backup ....


-- 
https://launchpad.net/~bjoern-michaelsen


_______________________________________________
LibreOffice mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Reply via email to