On Fri, 2011-06-17 at 12:06 +0200, Petr Mladek wrote: > cbosdonnat píše v Pá 17. 06. 2011 v 01:12 -0700: > > Caolán McNamara wrote: > > > > > > On Thu, 2011-06-16 at 18:39 +0200, Andras Timar wrote: > > >> Hi, > > >> > > >> Writer requires a password with <random number> characters. Instead of > > >> fixing the code in Writer (SfxPasswordDialog::SetMinLen was not called > > >> somewhere) I set a default minimum password length in constructor of > > >> the dialog. Please review it for 3-4 and 3-4-1. > > >> > > >> http://cgit.freedesktop.org/libreoffice/libs-core/commit/?id=6ab5952f6d952e5f96428b631e91a208ea21d4aa > > > > > > Looks sane, +1, one more needed for 3.4.1. > > > > > > > Looks sane to me too. > > This was 3rd review and I see it pushed in libreoffice-3-4-1 branch.
Sorry, I didn't mark it when I sent the email and did it after. but yes I cherry-picked it. -- Cédric Bosdonnat LibreOffice hacker http://documentfoundation.org OOo Eclipse Integration developer http://cedric.bosdonnat.free.fr _______________________________________________ LibreOffice mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/libreoffice
