Hi Michael, *,
On Fri, May 20, 2011 at 4:36 PM, Michael Meeks <[email protected]> wrote:
> On Tue, 2011-05-10 at 23:25 +0200, Christian Lohmaier wrote:
> [lotuswordpro bigendian problem]
>> If the code used
>> *pStream >> nTag;
>> instead, the comparison would result in the correct result.
>
> can we commit that at least - and then turn off the test for big-endian
> machines ?
Caolan did push some bigendianfixes for lotuswordpro filter that
includes the above change, not sure how long it would take to fully
make it compatible/working on bigendian..
> [ in the absence of more PPCs around that seems like it might
> be the easiest approach ].
See attached the patch to disable the cppunit test for Mac/PPC
(without the dummytarget (i.e. just replacing the cppunit eval with
the warning message would print the warning message three times.)
ciao
Christian
diff --git a/lotuswordpro/Module_lotuswordpro.mk b/lotuswordpro/Module_lotuswordpro.mk
index d523bda..f198d94 100644
--- a/lotuswordpro/Module_lotuswordpro.mk
+++ b/lotuswordpro/Module_lotuswordpro.mk
@@ -31,8 +31,19 @@ $(eval $(call gb_Module_add_targets,lotuswordpro,\
Library_lwpft \
))
+ifeq ($(OS)$(CPUNAME),MACOSXPOWERPC)
+# add dummytargets to print warning only once
+$(call gb_Library_get_target,lwpft): $(WORKDIR)/lotuswordpro_dummytarget
+$(WORKDIR)/lotuswordpro_dummytarget:
+ $(eval $(call gb_Output_warn,error/ToDo/FIXME - lotuswordprofilter is broken on PPC - just skipping checks!,avoid buildbreaker))
+ touch $@
+clean: lotuswordpro_dummyclean
+lotuswordpro_dummyclean:
+ rm -f $(WORKDIR)/lotuswordpro_dummytarget
+else
$(eval $(call gb_Module_add_check_targets,lotuswordpro,\
CppunitTest_lotuswordpro_test_lotuswordpro \
))
+endif
# vim: set noet ts=4 sw=4:
_______________________________________________
LibreOffice mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/libreoffice
