2011/5/4 Kohei Yoshida <[email protected]> > On Wed, 2011-05-04 at 18:23 +0200, Markus Mohrhard wrote: > > I'm fine with nearly everything. And your suggestion looks even a bit > > better than mine, except for the setByTable method. > > > > I was thinking about adding the table index too, but stumbled over the > > case when the table index does not match the table the db data refers > > to. > > Ok. I still wonder in what situations the table index differs from the > table of the db data, but I'll take your word for it. >
At the moment there is no case where this happens, but there may be someone in the future who will think of this as a good idea to solve a problem. It's the same reason made me write the lines that check for the index of the table: as long as something is possible someone will try it. > > We have a similar problem in our code base, but as long as we are > > aware of it there are no problems. But with the new uno api there > > might be an add-on developer who doesn't know that the range and the > > table index must match. > > So I would prefer to get the information which table is used by the db > > range itself. It will still be possible to check for the index to be > > out of bounds. > > Ok. I'm fine with that. Let's go with your suggestion. > > Kohei > >
_______________________________________________ LibreOffice mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/libreoffice
