Hi Muthu, David, On Mon, 2011-03-07 at 21:46 +0530, Muthu Subramanian K wrote: > Hi David, > > Thank you for you patch. > The general rule is to keep the "i####" kind of numbers - these are > issuezilla ids. But, in this case I would prefer to go with you to > remove most of these - since, in this patch context, the ids seem to > have been added to every line. > > On the other hand, I would prefer another person reviewing before I push > these changes - cedric?
I would keep the #i91601# before one FN_UNO_LIST_ID to show it has been added to fix that bug, but remove the other instances. IMHO quite a lot of #i123456# comments would be lost: these need to be kept in at least some strategic places. -- Cédric Bosdonnat LibreOffice hacker http://documentfoundation.org OOo Eclipse Integration developer http://cedric.bosdonnat.free.fr _______________________________________________ LibreOffice mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/libreoffice
