On Thu, 2011-02-24 at 21:31 +0100, Pierre-André Jacquod wrote: > On 02/24/2011 08:33 PM, Kohei Yoshida wrote: > > On Thu, 2011-02-24 at 19:46 +0100, Jonathan Aquilina wrote: > > >> Martin i think it would be easier as well as not to end up having ur > >> email black listed for sending out large amounts of emails, but if its > >> for a single module i would attach them all in one email. > > > > For the record this is what git send-email --thread --no-change-reply-to > > does, which the guideline mentions. > > yes.... but it does not recommend to make a commit per file for the same > task within the same directory... > > Looking at the patches, there are some with 1 line changed in one file. > In this case, I would recommend to have one commit for translation > within a directory.
Yup, a good suggestion. I somehow overlooked that his patches were one per file. We indeed want to avoid per-file patches. I also agree with the rest of your suggestion. Thanks! Kohei -- Kohei Yoshida, LibreOffice hacker, Calc <[email protected]> _______________________________________________ LibreOffice mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/libreoffice
