On Mon, Oct 25, 2010 at 1:39 PM, Tor Lillqvist <[email protected]> wrote: > Isn't that wrong? Assuming there are non-Windows platforms where the bundled > ICU is used (generic Linux build, other Unixes?), previously that #include > <iostream> has been used on all of them, but after your change it will be > used only on MSVC versions earlier than 10. > > Or is that OK, is the <iostream> functionality actually needed in that source > file just for those earlier MSVC versions, but <iostream> has previously been > included out of laziness on all platforms?
Yes, the ifdef condition is wrong. I am not sure if the include is needed in other platforms, but I guess most of them are using a system icu instead of the old internal one. -- Jesús Corrius <[email protected]> Document Foundation founding member Skype: jcorrius | Twitter: @jcorrius _______________________________________________ LibreOffice mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/libreoffice
