https://bugs.documentfoundation.org/show_bug.cgi?id=159109

            Bug ID: 159109
           Summary: FILEOPEN PPTX: sourceLinked ignored for axis - should
                    be 0.00% from data series formatcode
           Product: LibreOffice
           Version: 4.4 all versions
          Hardware: All
                OS: All
            Status: UNCONFIRMED
          Keywords: filter:pptx, implementationError
          Severity: normal
          Priority: medium
         Component: Chart
          Assignee: [email protected]
          Reporter: [email protected]
                CC: [email protected]
        Depends on: 142108
            Blocks: 75057

Created attachment 191850
  --> https://bugs.documentfoundation.org/attachment.cgi?id=191850&action=edit
chart2/qa/extras/data/pptx/percentage-number-formats.pptx

In chart2/qa/extras/chart2import.cxx, Matúš Kukan wrote
    // FIXME: This should be in fact "0.00%".

He did a lot of work in the LO 4.4 timeframe related to formatting of the axis.
I suspect that much of this is ultimately incorrect, although it served its
purpose at the time.

With bug 137691, the import and export of the data series should be correct.
This is what sourceLinked is referring to. I assume it means that if the data
series have a formatCode, then use that instead of the axis' numFmt formatCode.
(TODO - what if the first series has no formatCode, but the second one does?)

Of course, this can only work if we can trust that the data series have
properly imported the formatcode - depends on bug 142108.


Specifically, oox/source/drawingml/chart/objectformatter.cxx should be
obsolete:        // Setting "LinkNumberFormatToSource" does not really work, at
least not for axis :-/

and there probably are many more hacks in the code as well.
perhaps 4744400afc9c2be99f62b12180fa33b43acef564
and other portions of 7c3dd4a9c1a05bbb6867ca6db6229da38f5f68ed are suspicious?

Steps to reproduce the problem.
1.) open percentage-number-formats.pptx and see that the Y axis is 0.0%, not
0.00%.

Prior to 4.4 commit c8cc89ff802d86b1f3a69afe1b4835b7df7f70c7, this was
(correctly) using the data-series (incorrect, General) format and displayed as
0.00 (no percentage). So it wasn't every actually correct - not a regression.


I started work on this, but ran out of time.
https://gerrit.libreoffice.org/c/core/+/161825


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=75057
[Bug 75057] [META] OOXML Chart object issues
https://bugs.documentfoundation.org/show_bug.cgi?id=142108
[Bug 142108] Calc chart loses data number formatting in new source Data Table
when copied to non calc LibO document (Writer, Draw)
-- 
You are receiving this mail because:
You are the assignee for the bug.

Reply via email to