https://bugs.documentfoundation.org/show_bug.cgi?id=161637
Justin L <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |[email protected] --- Comment #8 from Justin L <[email protected]> --- Created attachment 203774 --> https://bugs.documentfoundation.org/attachment.cgi?id=203774&action=edit 1bec9b2.diff: the abandoned patch (In reply to Justin L from comment #6) > That idea is explored at https://gerrit.libreoffice.org/c/core/+/192760 Spell checking is language based. A document might have multiple languages in it, with multiple rules about how quotes should be handled. On the other hand, autocorrect is not at all language-aware. So it doesn't seem appropriate to me to implement this. Besides, there are no languages (AFAICS) that do not have a GetLocaleDataWrapper( nLanguage ).getQuotationMarkEnd() and thus my patch would have affected almost nothing... This patch would have affected the following languages - which have an apostrophe as the quote character: i18npool/source/localedata/data$ git grep "<QuotationEnd" | grep "'" ar_OM.xml: <QuotationEnd>'</QuotationEnd> #Arabic, Omani Spoken en_GH.xml: <QuotationEnd>'</QuotationEnd> #English, Ghana eo.xml: <QuotationEnd>'</QuotationEnd> #Esperanto hi_IN.xml: <QuotationEnd>'</QuotationEnd> #Hindi, India hr_HR.xml: <QuotationEnd>'</QuotationEnd> #Croatian km_KH.xml: <QuotationEnd>'</QuotationEnd> #Khmer, Cambodia lg_UG.xml: <QuotationEnd>'</QuotationEnd> #Ganda, Uganda lo_LA.xml: <QuotationEnd>'</QuotationEnd> #Lao, Laos mos_BF.xml:<QuotationEnd>'</QuotationEnd> #Mòoré, Burkina Faso ne_NP.xml: <QuotationEnd>'</QuotationEnd> #Nepali pa_IN.xml: <QuotationEnd>'</QuotationEnd> #Punjabi I had assumed that locale info is imported into autocorrect, so that either it is turned off, or else it replaces apostrophe with apostrophe. However, that does not seem to be the case. In all cases, apostrophe-replace is turned on with U+2019 as the replacement - even in the languages below. The other set of "irregular" QuotationEnds is represented by ug_CN.xml: QuotationEnd U+00ab /QuotationEnd « bg_BG.xml: QuotationEnd U+00bb /QuotationEnd » de_DE.xml: QuotationEnd U+2018 /QuotationEnd ‘ ru_RU.xml: QuotationEnd U+201c /QuotationEnd “ tpi_PG.xml: QuotationEnd U+201d /QuotationEnd ” de_CH.xml: QuotationEnd U+203a /QuotationEnd › zh_TW.xml: QuotationEnd U+300d /QuotationEnd 」 There are no languages without a QuotationEnd defined AFAICS. -- You are receiving this mail because: You are the assignee for the bug.
